svn commit: r1789046 - /ofbiz/ofbiz-plugins/trunk/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayFeedback.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1789046 - /ofbiz/ofbiz-plugins/trunk/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayFeedback.java

jleroux@apache.org
Author: jleroux
Date: Tue Mar 28 05:38:43 2017
New Revision: 1789046

URL: http://svn.apache.org/viewvc?rev=1789046&view=rev
Log:
Fixes a bug I just put in with r1789043 EbayFeedback is a service class not an
even class :/

Modified:
    ofbiz/ofbiz-plugins/trunk/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayFeedback.java

Modified: ofbiz/ofbiz-plugins/trunk/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayFeedback.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayFeedback.java?rev=1789046&r1=1789045&r2=1789046&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/trunk/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayFeedback.java (original)
+++ ofbiz/ofbiz-plugins/trunk/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayFeedback.java Tue Mar 28 05:38:43 2017
@@ -196,14 +196,11 @@ public class EbayFeedback {
                 }
             }
         } catch (ApiException e) {
-            request.setAttribute("_ERROR_MESSAGE_","ApiException ".concat(e.getMessage()));
-            return "error";
+            result = ServiceUtil.returnError("ApiException ".concat(e.getMessage()));
         } catch (SdkException e) {
-            request.setAttribute("_ERROR_MESSAGE_","SdkException ".concat(e.getMessage()));
-            return "error";
+            result = ServiceUtil.returnError("SdkException ".concat(e.getMessage()));
         } catch (Exception e) {
-            request.setAttribute("_ERROR_MESSAGE_","Exception ".concat(e.getMessage()));
-            return "error";
+            result = ServiceUtil.returnError("Exception ".concat(e.getMessage()));
         }
         String successMsg = UtilProperties.getMessage(resource, "EbayLoadEbayFeedbackSuccessful", locale);
         result = ServiceUtil.returnSuccess(successMsg);
@@ -253,14 +250,11 @@ public class EbayFeedback {
             }
             result.put("itemsAwaitingFeedback", itemsResult);
         } catch (ApiException e) {
-            // TODO Auto-generated catch block
-            e.printStackTrace();
+            result = ServiceUtil.returnError("ApiException ".concat(e.getMessage()));
         } catch (SdkException e) {
-            // TODO Auto-generated catch block
-            e.printStackTrace();
+            result = ServiceUtil.returnError("SdkException ".concat(e.getMessage()));
         } catch (Exception e) {
-            // TODO Auto-generated catch block
-            e.printStackTrace();
+            result = ServiceUtil.returnError("Exception ".concat(e.getMessage()));
         }
         return result;
     }
@@ -377,14 +371,11 @@ public class EbayFeedback {
                 leaveFeedbackCall.leaveFeedback();
             }
         } catch (ApiException e) {
-            request.setAttribute("_ERROR_MESSAGE_","ApiException ".concat(e.getMessage()));
-            return "error";
+            result = ServiceUtil.returnError("ApiException ".concat(e.getMessage()));
         } catch (SdkException e) {
-            request.setAttribute("_ERROR_MESSAGE_","SdkException ".concat(e.getMessage()));
-            return "error";
+            result = ServiceUtil.returnError("SdkException ".concat(e.getMessage()));
         } catch (Exception e) {
-            request.setAttribute("_ERROR_MESSAGE_","Exception ".concat(e.getMessage()));
-            return "error";
+            result = ServiceUtil.returnError("Exception ".concat(e.getMessage()));
         }
         result = ServiceUtil.returnSuccess();
         return result;