svn commit: r1794504 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/conversion/test/MiscTests.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1794504 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/conversion/test/MiscTests.java

jleroux@apache.org
Author: jleroux
Date: Tue May  9 08:11:55 2017
New Revision: 1794504

URL: http://svn.apache.org/viewvc?rev=1794504&view=rev
Log:
No functional change.

When Adrian removed finished removing Javolution from the base component at
r1635910 https://s.apache.org/cwfE he routinely changed FastList to LinkedList
and FastMap to HashMap.

Actually those are just duplicates of ArrayList for LinkedList and strictly
HashMap for, er, HashMap.

This removes those useless line from the tests.

I wodered about it, but I hope noone will argue that we should keep LinkedList,
obviously ArrayList is enough there as a List implementation.

With this change the words fastlist and fastmap (case insensitive) no longer
exists in any OOTB files.

Modified:
    ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/conversion/test/MiscTests.java

Modified: ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/conversion/test/MiscTests.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/conversion/test/MiscTests.java?rev=1794504&r1=1794503&r2=1794504&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/conversion/test/MiscTests.java (original)
+++ ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/conversion/test/MiscTests.java Tue May  9 08:11:55 2017
@@ -22,7 +22,6 @@ import java.math.BigDecimal;
 import java.net.URL;
 import java.util.ArrayList;
 import java.util.HashMap;
-import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
 
@@ -77,27 +76,20 @@ public class MiscTests extends GenericTe
         List<String> baseList = UtilMisc.toList("a", "1", "b", "2", "c", "3");
         List<String> arrayList = new ArrayList<String>();
         arrayList.addAll(baseList);
-        List<String> fastList = new LinkedList<String>();
-        fastList.addAll(baseList);
         Map<String, String> baseMap = UtilMisc.toMap("a", "1", "b", "2", "c", "3");
         Map<String, String> hashMap = new HashMap<String, String>();
         hashMap.putAll(baseMap);
-        Map<String, String> fastMap = new HashMap<String, String>();
-        fastMap.putAll(baseMap);
         Object[] testObjects = new Object[] {
             string,
             bigDecimal,
             url,
             arrayList,
-            fastList,
-            hashMap,
-            fastMap,
+            hashMap
         };
         for (Object testObject: testObjects) {
             assertPassThru(testObject, testObject.getClass());
         }
-        assertPassThru(fastList, fastList.getClass(), List.class);
-        assertPassThru(fastMap, fastMap.getClass(), Map.class);
+        assertPassThru(arrayList, arrayList.getClass(), List.class);
         assertPassThru(hashMap, hashMap.getClass(), Map.class);
     }
 }