svn commit: r1804315 - in /ofbiz/ofbiz-framework/trunk: applications/party/minilang/party/ applications/party/servicedef/ applications/party/src/main/java/org/apache/ofbiz/party/party/ framework/images/webapp/images/

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1804315 - in /ofbiz/ofbiz-framework/trunk: applications/party/minilang/party/ applications/party/servicedef/ applications/party/src/main/java/org/apache/ofbiz/party/party/ framework/images/webapp/images/

jleroux@apache.org
Author: jleroux
Date: Mon Aug  7 10:00:55 2017
New Revision: 1804315

URL: http://svn.apache.org/viewvc?rev=1804315&view=rev
Log:
Completed: Remove the never implemented deleteParty (pre Apache era)
(OFBIZ-9556)

In dev ML in this thread https://s.apache.org/pc90 
I suggested to remove the never implemented deleteParty (pre Apache era)

Modified:
    ofbiz/ofbiz-framework/trunk/applications/party/minilang/party/PartySimpleEvents.xml
    ofbiz/ofbiz-framework/trunk/applications/party/servicedef/services.xml
    ofbiz/ofbiz-framework/trunk/applications/party/src/main/java/org/apache/ofbiz/party/party/PartyServices.java
    ofbiz/ofbiz-framework/trunk/framework/images/webapp/images/OfbizUtil.js

Modified: ofbiz/ofbiz-framework/trunk/applications/party/minilang/party/PartySimpleEvents.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/party/minilang/party/PartySimpleEvents.xml?rev=1804315&r1=1804314&r2=1804315&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/party/minilang/party/PartySimpleEvents.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/party/minilang/party/PartySimpleEvents.xml Mon Aug  7 10:00:55 2017
@@ -20,19 +20,6 @@ under the License.
 
 <simple-methods xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xmlns="http://ofbiz.apache.org/Simple-Method" xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method http://ofbiz.apache.org/dtds/simple-methods.xsd">
-    <!-- Party events -->
-    <simple-method method-name="deleteParty" short-description="Delete Person">
-        <call-map-processor in-map-name="parameters" out-map-name="context">
-            <simple-map-processor name="deleteParty">
-                <process field="partyId"><copy/></process>
-            </simple-map-processor>
-        </call-map-processor>
-        <check-errors/>
-        <call-service service-name="deleteParty" in-map-name="context">
-            <default-message resource="PartyUiLabels" property="PartyPartySuccessfullyDeleted"/>
-        </call-service>
-    </simple-method>
-
     <!-- Person events -->
     <simple-method method-name="createPerson" short-description="Create Person">
         <call-map-processor xml-resource="component://party/minilang/party/PartyMapProcs.xml"

Modified: ofbiz/ofbiz-framework/trunk/applications/party/servicedef/services.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/party/servicedef/services.xml?rev=1804315&r1=1804314&r2=1804315&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/party/servicedef/services.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/party/servicedef/services.xml Mon Aug  7 10:00:55 2017
@@ -52,11 +52,6 @@ under the License.
     </service>
 
     <!-- Party services -->
-    <service name="deleteParty" engine="java"
-            location="org.apache.ofbiz.party.party.PartyServices" invoke="deleteParty" auth="true">
-        <description>Delete a Party</description>
-        <attribute name="partyId" type="String" mode="IN" optional="true"/>
-    </service>
     <service name="setPartyStatus" engine="java"
             location="org.apache.ofbiz.party.party.PartyServices" invoke="setPartyStatus" auth="true">
         <description>Set the party status. Requires PARTYMGR_UPDATE or PARTYMGR_STS_UPDATE permission. The change to statusId must be defined in StatusValidChange, otherwise

Modified: ofbiz/ofbiz-framework/trunk/applications/party/src/main/java/org/apache/ofbiz/party/party/PartyServices.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/party/src/main/java/org/apache/ofbiz/party/party/PartyServices.java?rev=1804315&r1=1804314&r2=1804315&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/party/src/main/java/org/apache/ofbiz/party/party/PartyServices.java (original)
+++ ofbiz/ofbiz-framework/trunk/applications/party/src/main/java/org/apache/ofbiz/party/party/PartyServices.java Mon Aug  7 10:00:55 2017
@@ -72,34 +72,6 @@ public class PartyServices {
     public static final String resourceError = "PartyErrorUiLabels";
 
     /**
-     * Deletes a Party.
-     * @param ctx The DispatchContext that this service is operating in.
-     * @param context Map containing the input parameters.
-     * @return Map with the result of the service, the output parameters.
-     */
-    public static Map<String, Object> deleteParty(DispatchContext ctx, Map<String, ? extends Object> context) {
-
-        Locale locale = (Locale) context.get("locale");
-
-        /*
-         * pretty serious operation, would delete:
-         * - Party
-         * - PartyRole
-         * - PartyRelationship: from and to
-         * - PartyDataObject
-         * - Person or PartyGroup
-         * - PartyContactMech, but not ContactMech itself
-         * - PartyContactMechPurpose
-         * - Order?
-         *
-         * We may want to not allow this, but rather have some sort of delete flag for it if it's REALLY that big of a deal...
-         */
-
-        return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
-                "partyservices.cannot_delete_party_not_implemented", locale));
-    }
-
-    /**
      * Creates a Person.
      * If no partyId is specified a numeric partyId is retrieved from the Party sequence.
      * @param ctx The DispatchContext that this service is operating in.

Modified: ofbiz/ofbiz-framework/trunk/framework/images/webapp/images/OfbizUtil.js
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/images/webapp/images/OfbizUtil.js?rev=1804315&r1=1804314&r2=1804315&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/framework/images/webapp/images/OfbizUtil.js (original)
+++ ofbiz/ofbiz-framework/trunk/framework/images/webapp/images/OfbizUtil.js Mon Aug  7 10:00:55 2017
@@ -253,7 +253,7 @@ function changeObjectVisibility(objectId
     }
 }
 
-// To use this in a link use a URL like this: javascript:confirmActionLink('You want to delete this party?', 'deleteParty?partyId=${partyId}')
+// To use this in a link use a URL like this: javascript:confirmActionLink('You want to delete this example?', 'deleteExample?exampleId=${exampleId}')
 function confirmActionLink(msg, newLocation) {
     if (msg == null) {
         msg = "Are you sure you want to do this?";
@@ -264,7 +264,7 @@ function confirmActionLink(msg, newLocat
     }
 }
 
-// To use this in a link use a URL like this: javascript:confirmActionFormLink('You want to update this party?', 'updateParty')
+// To use this in a link use a URL like this: javascript:confirmActionFormLink('You want to update this example?', 'updateExample')
 function confirmActionFormLink(msg, formName) {
     if (msg == null) {
         msg = "Are you sure you want to do this?";