svn commit: r1806261 - in /ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa: CommonScreens.xml SfaMenus.xml forms/ContactForms.xml forms/LeadForms.xml forms/OpportunityForms.xml

[pranayp]

Author: pranayp
Date: Sat Aug 26 06:23:57 2017
New Revision: 1806261

URL: http://svn.apache.org/viewvc?rev=1806261&view=rev
Log:
Fixed: Lead Profile URL not working properly in SFA.
(OFBIZ-9512)

Fixed it at all the places found in SFA where roleTypeId wasn't being passed and creating the issue.

Thanks Jagpreet Kaur for reporting and verifying the issue, thanks Parakh Maheshwari and Devanshu Vyas for reviewing and providing details on their finding and thanks Aditya Sharma for providing the patch.


Modified:
    ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/CommonScreens.xml
    ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/SfaMenus.xml
    ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/ContactForms.xml
    ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml
    ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml

Modified: ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/CommonScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/CommonScreens.xml?rev=1806261&r1=1806260&r2=1806261&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/CommonScreens.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/CommonScreens.xml Sat Aug 26 06:23:57 2017
@@ -222,6 +222,7 @@ under the License.
                                         <container style="button-bar button-style-2">
                                             <link target="viewprofile" text="${uiLabelMap.PartyHideOld}">
                                                 <parameter param-name="partyId" from-field="party.partyId"/>
+                                                <parameter param-name="roleTypeId" from-field="parameters.roleTypeId"/>
                                             </link>
                                         </container>
                                     </widgets>
@@ -229,6 +230,7 @@ under the License.
                                         <container style="button-bar button-style-2">
                                             <link target="viewprofile" text="${uiLabelMap.PartyShowOld}">
                                                 <parameter param-name="partyId" from-field="party.partyId"/>
+                                                <parameter param-name="roleTypeId" from-field="parameters.roleTypeId"/>
                                                 <parameter param-name="SHOW_OLD" value="true"/>
                                             </link>
                                         </container>

Modified: ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/SfaMenus.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/SfaMenus.xml?rev=1806261&r1=1806260&r2=1806261&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/SfaMenus.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/SfaMenus.xml Sat Aug 26 06:23:57 2017
@@ -139,6 +139,7 @@ under the License.
             </condition>
             <link target="viewprofile">
                 <parameter param-name="partyId" from-field="parameters.partyId"/>
+                <parameter param-name="roleTypeId" from-field="parameters.roleTypeId"/>
             </link>
         </menu-item>
     </menu>

Modified: ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/ContactForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/ContactForms.xml?rev=1806261&r1=1806260&r2=1806261&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/ContactForms.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/ContactForms.xml Sat Aug 26 06:23:57 2017
@@ -102,6 +102,12 @@ under the License.
                 <field-map field-name="distinct" value="Y"/>
             </service>
         </actions>
+        <field name="partyId" title="${uiLabelMap.PartyPartyId}">
+            <hyperlink description="${partyName} [${partyId}]" target="viewprofile" >
+                <parameter param-name="partyId"/>
+                <parameter param-name="roleTypeId" from-field="roleTypeIdTo"/>
+            </hyperlink>
+        </field>
         <field name="assignToMe"><hidden/></field>
     </form>
     <form name="NewContact" type="single" target="createContact" header-row-style="header-row" default-table-style="basic-table">

Modified: ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml?rev=1806261&r1=1806260&r2=1806261&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml Sat Aug 26 06:23:57 2017
@@ -233,6 +233,12 @@ under the License.
                 <field-map field-name="distinct" value="Y"/>
             </service>
         </actions>
+        <field name="partyId" title="${uiLabelMap.PartyPartyId}">
+            <hyperlink description="${partyName} [${partyId}]" target="viewprofile" >
+                <parameter param-name="partyId"/>
+                <parameter param-name="roleTypeId" from-field="roleTypeIdTo"/>
+            </hyperlink>
+        </field>
         <field name="assignToMe"><hidden/></field>
     </form>
     <form name="AddRelatedCompany" type="single" target="createPartyRelationship">

Modified: ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml?rev=1806261&r1=1806260&r2=1806261&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml Sat Aug 26 06:23:57 2017
@@ -77,6 +77,7 @@ under the License.
             <display-entity entity-name="PartyNameView" description="${firstName} ${lastName} ${middleName} ${groupName}" key-field-name="partyId">
                 <sub-hyperlink target="viewprofile" description=" [${partyId}]">
                     <parameter param-name="partyId" from-field="partyId"/>
+                    <parameter param-name="roleTypeId" from-field="roleTypeId"/>
                 </sub-hyperlink>
             </display-entity>
         </field>