svn commit: r1816937 - /ofbiz/ofbiz-framework/trunk/applications/marketing/src/main/java/org/apache/ofbiz/marketing/tracking/TrackingCodeEvents.java

[mbrohl]

Author: mbrohl
Date: Sat Dec  2 09:37:54 2017
New Revision: 1816937

URL: http://svn.apache.org/viewvc?rev=1816937&view=rev
Log:
Improved: TrackingCodeEvents#checkTrackingCodeUrlParam returns "error"
if tracking code is not available.
(OFBIZ-10030)

The loglevel is set from error to info, a misleading comment is removed
and the method returns "success" in case of a tracking code which cannot
be found.

Modified:
    ofbiz/ofbiz-framework/trunk/applications/marketing/src/main/java/org/apache/ofbiz/marketing/tracking/TrackingCodeEvents.java

Modified: ofbiz/ofbiz-framework/trunk/applications/marketing/src/main/java/org/apache/ofbiz/marketing/tracking/TrackingCodeEvents.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/marketing/src/main/java/org/apache/ofbiz/marketing/tracking/TrackingCodeEvents.java?rev=1816937&r1=1816936&r2=1816937&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/marketing/src/main/java/org/apache/ofbiz/marketing/tracking/TrackingCodeEvents.java (original)
+++ ofbiz/ofbiz-framework/trunk/applications/marketing/src/main/java/org/apache/ofbiz/marketing/tracking/TrackingCodeEvents.java Sat Dec  2 09:37:54 2017
@@ -69,9 +69,8 @@ public class TrackingCodeEvents {
             }
 
             if (trackingCode == null) {
-                Debug.logError("TrackingCode not found for trackingCodeId [" + trackingCodeId + "], ignoring this trackingCodeId.", module);
-                //this return value will be ignored, but we'll designate this as an error anyway
-                return "error";
+                Debug.logInfo("TrackingCode not found for trackingCodeId [" + trackingCodeId + "], ignoring this trackingCodeId.", module);
+                return "success";
             }
 
             return processTrackingCode(trackingCode, request, response, "TKCDSRC_URL_PARAM");