svn commit: r1817552 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/connection/DBCPConnectionFactory.java

[mbrohl]

Author: mbrohl
Date: Fri Dec  8 19:44:27 2017
New Revision: 1817552

URL: http://svn.apache.org/viewvc?rev=1817552&view=rev
Log:
Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.entity.connection.
(OFBIZ-9718)

Thanks Julian Leichert for reporting and providing the patch.

Modified:
    ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/connection/DBCPConnectionFactory.java

Modified: ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/connection/DBCPConnectionFactory.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/connection/DBCPConnectionFactory.java?rev=1817552&r1=1817551&r2=1817552&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/connection/DBCPConnectionFactory.java (original)
+++ ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/connection/DBCPConnectionFactory.java Fri Dec  8 19:44:27 2017
@@ -166,7 +166,7 @@ public class DBCPConnectionFactory imple
     public static Map<String, Object> getDataSourceInfo(String helperName) {
         Map<String, Object> dataSourceInfo = new HashMap<String, Object>();
         DebugManagedDataSource mds = dsCache.get(helperName);
-        if (mds instanceof DebugManagedDataSource) {
+        if (mds != null) {
             dataSourceInfo = mds.getInfo();
         }
         return dataSourceInfo;