svn commit: r1817645 - /ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/subscription/SubscriptionServices.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1817645 - /ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/subscription/SubscriptionServices.java

mbrohl
Author: mbrohl
Date: Sat Dec  9 17:58:59 2017
New Revision: 1817645

URL: http://svn.apache.org/viewvc?rev=1817645&view=rev
Log:
Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.product.subscription.
(OFBIZ-9786)

Thanks Julian Leichert for reporting and providing the patch.

Modified:
    ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/subscription/SubscriptionServices.java

Modified: ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/subscription/SubscriptionServices.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/subscription/SubscriptionServices.java?rev=1817645&r1=1817644&r2=1817645&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/subscription/SubscriptionServices.java (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/subscription/SubscriptionServices.java Sat Dec  9 17:58:59 2017
@@ -354,7 +354,7 @@ public class SubscriptionServices {
                             } else {
                                 Debug.logWarning("Don't know anything about gracePeriodOnExpiryUomId [" + gracePeriodOnExpiryUomId + "], defaulting to month", module);
                             }
-                            endDateSubscription.add(field, Integer.valueOf(gracePeriodOnExpiry).intValue());
+                            endDateSubscription.add(field, Integer.parseInt(gracePeriodOnExpiry));
                         }
                         if ((currentDate.after(endDateSubscription) || currentDate.equals(endDateSubscription)) && serviceNameOnExpiry != null) {
                             if (userLogin != null) {