svn commit: r1818583 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1818583 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java

mbrohl
Author: mbrohl
Date: Mon Dec 18 15:10:58 2017
New Revision: 1818583

URL: http://svn.apache.org/viewvc?rev=1818583&view=rev
Log:
Improved: Fixing defects reported by code analysis tools, package
org.apache.ofbiz.accounting.thirdparty.authorizedotnet.
(OFBIZ-9453)

Thanks Kyra Pritzel-Hentley for reporting.

Modified:
    ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java

Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java?rev=1818583&r1=1818582&r2=1818583&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java (original)
+++ ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java Mon Dec 18 15:10:58 2017
@@ -20,6 +20,7 @@
 package org.apache.ofbiz.accounting.thirdparty.authorizedotnet;
 
 import java.math.BigDecimal;
+import java.util.Arrays;
 
 import org.apache.ofbiz.base.util.UtilValidate;
 
@@ -112,8 +113,9 @@ public class AuthorizeResponse {
 
     private String getResponseField(String field) {
         int position = pos.getPosition(field);
-        if (position == -1)
+        if (position == -1) {
             return null;
+        }
         return getResponseField(position);
     }
     
@@ -128,7 +130,7 @@ public class AuthorizeResponse {
       
     @Override
     public String toString() {
-        return response.toString();
+        return Arrays.toString(response);
     }
     
     public static abstract class RespPositions {