svn commit: r1820160 - /ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/data/DataEvents.java

Author: jleroux
Date: Thu Jan  4 17:55:10 2018
New Revision: 1820160

URL: http://svn.apache.org/viewvc?rev=1820160&view=rev
Log:
Improved: DataEvents.java API
(OFBIZ-10144)

Thanks: Wai

Modified:
    ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/data/DataEvents.java

Modified: ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/data/DataEvents.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/data/DataEvents.java?rev=1820160&r1=1820159&r2=1820160&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/data/DataEvents.java (original)
+++ ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/data/DataEvents.java Thu Jan  4 17:55:10 2018
@@ -58,7 +58,10 @@ public class DataEvents {
         return DataResourceWorker.uploadAndStoreImage(request, "dataResourceId", "imageData");
     }
 
-    /** Streams any binary content data to the browser */
+    /**
+     * Streams any binary content data to the browser.
+     * <p>Supercedes {@link org.apache.ofbiz.content.data.DataEvents#serveImage(HttpServletRequest, HttpServletResponse) DataEvents#serveImage()}</p>
+     */
     public static String serveObjectData(HttpServletRequest request, HttpServletResponse response) {
         Delegator delegator = (Delegator) request.getAttribute("delegator");
         LocalDispatcher dispatcher = (LocalDispatcher) request.getAttribute("dispatcher");
@@ -222,8 +225,11 @@ public class DataEvents {
         return "success";
     }
 
-    /** Streams ImageDataResource data to the output. */
-    // TODO: remove this method in favor of serveObjectData
+    /**
+     * Streams ImageDataResource data to the output.
+     * <p>Superceded by {@link org.apache.ofbiz.content.data.DataEvents#serveObjectData(HttpServletRequest, HttpServletResponse) DataEvents#serveObjectData}</p>
+     */
+    @Deprecated
     public static String serveImage(HttpServletRequest request, HttpServletResponse response) {
         HttpSession session = request.getSession();
         ServletContext application = session.getServletContext();