svn commit: r1820956 - in /ofbiz/ofbiz-framework/branches/release17.12: ./ applications/humanres/widget/forms/EmplPositionForms.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1820956 - in /ofbiz/ofbiz-framework/branches/release17.12: ./ applications/humanres/widget/forms/EmplPositionForms.xml

jleroux@apache.org
Author: jleroux
Date: Fri Jan 12 08:41:52 2018
New Revision: 1820956

URL: http://svn.apache.org/viewvc?rev=1820956&view=rev
Log:
"Applied fix from trunk for revision: 1820949"
------------------------------------------------------------------------
r1820949 | paulfoxworthy | 2018-01-12 07:50:17 +0100 (ven., 12 janv. 2018) | 8 lines

Fixed: Find Employee Position does not allow "don't care" for boolean fields (OFBIZ-10158)

In the demo app, go to https://demo-stable.ofbiz.apache.org/humanres/control/FindEmplPositions, click on New Employee Position, and toggle one of the four flags, e.g. set Temporary Flag to N.

Now on the Find screen, there is no way to find all employee positions: it insists on a Yes or No for the flags. This patch allows a blank "don't care" option.

Thanks: Larissa Zanoni at Blockfreight for discovering this issue.

------------------------------------------------------------------------


Modified:
    ofbiz/ofbiz-framework/branches/release17.12/   (props changed)
    ofbiz/ofbiz-framework/branches/release17.12/applications/humanres/widget/forms/EmplPositionForms.xml

Propchange: ofbiz/ofbiz-framework/branches/release17.12/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Jan 12 08:41:52 2018
@@ -10,4 +10,4 @@
 /ofbiz/branches/json-integration-refactoring:1634077-1635900
 /ofbiz/branches/multitenant20100310:921280-927264
 /ofbiz/branches/release13.07:1547657
-/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820862
+/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820862,1820949

Modified: ofbiz/ofbiz-framework/branches/release17.12/applications/humanres/widget/forms/EmplPositionForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/applications/humanres/widget/forms/EmplPositionForms.xml?rev=1820956&r1=1820955&r2=1820956&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/branches/release17.12/applications/humanres/widget/forms/EmplPositionForms.xml (original)
+++ ofbiz/ofbiz-framework/branches/release17.12/applications/humanres/widget/forms/EmplPositionForms.xml Fri Jan 12 08:41:52 2018
@@ -276,25 +276,25 @@ under the License.
         <auto-fields-entity entity-name="EmplPosition" default-field-type="find"/>
         <field name="noConditionFind"><hidden value="Y"/><!-- if this isn't there then with all fields empty no query will be done --></field>
         <field name="salaryFlag">
-            <drop-down allow-empty="false" current="selected">
+            <drop-down allow-empty="true" current="selected">
                 <option key="Y" description="${uiLabelMap.CommonYes}"/>
                 <option key="N" description="${uiLabelMap.CommonNo}"/>
             </drop-down>
         </field>
         <field name="exemptFlag">
-            <drop-down allow-empty="false" current="selected">
+            <drop-down allow-empty="true" current="selected">
                 <option key="Y" description="${uiLabelMap.CommonYes}"/>
                 <option key="N" description="${uiLabelMap.CommonNo}"/>
             </drop-down>
         </field>
         <field name="fulltimeFlag">
-            <drop-down allow-empty="false" current="selected">
+            <drop-down allow-empty="true" current="selected">
                 <option key="Y" description="${uiLabelMap.CommonYes}"/>
                 <option key="N" description="${uiLabelMap.CommonNo}"/>
             </drop-down>
         </field>
         <field name="temporaryFlag">
-            <drop-down allow-empty="false" current="selected">
+            <drop-down allow-empty="true" current="selected">
                 <option key="Y" description="${uiLabelMap.CommonYes}"/>
                 <option key="N" description="${uiLabelMap.CommonNo}"/>
             </drop-down>