svn commit: r1834201 - /ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreEvents.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1834201 - /ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreEvents.java

Arun Patidar-4
Author: arunpatidar
Date: Sat Jun 23 12:53:56 2018
New Revision: 1834201

URL: http://svn.apache.org/viewvc?rev=1834201&view=rev
Log:
Improved: Define generic types in
(OFBIZ-10355)

Thanks Mathieu for your contribution

Modified:
    ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreEvents.java

Modified: ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreEvents.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreEvents.java?rev=1834201&r1=1834200&r2=1834201&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreEvents.java (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreEvents.java Sat Jun 23 12:53:56 2018
@@ -56,7 +56,7 @@ public class ProductStoreEvents {
                 if (UtilValidate.isNotEmpty(children)) {
                     for (GenericValue child : children ) {
                         String productStoreGroupId = child.getString("productStoreGroupId");
-                        Map josonMap = new HashMap();
+                        Map<String, Object> josonMap = new HashMap<>();
                         List<GenericValue> childList = null;
                         // Get the child list of chosen category
                         childList = EntityQuery.use(delegator).from("ProductStoreGroupRollupAndChild").where("parentGroupId", productStoreGroupId).cache(true).filterByDate().queryList();
@@ -64,8 +64,8 @@ public class ProductStoreEvents {
                         if (UtilValidate.isNotEmpty(childList)) {
                             josonMap.put("state", "closed");
                         }
-                        Map dataMap = new HashMap();
-                        Map dataAttrMap = new HashMap();
+                        Map<String, Object> dataMap = new HashMap<>();
+                        Map<String, String> dataAttrMap = new HashMap<>();
 
                         dataAttrMap.put("onClick", onclickFunction + "('" + productStoreGroupId + "')");
                         String hrefStr = "EditProductStoreGroupAndAssoc";
@@ -74,7 +74,7 @@ public class ProductStoreEvents {
                         dataMap.put("attr", dataAttrMap);
                         dataMap.put("title", child.get("productStoreGroupName") + " [" + child.get("productStoreGroupId") + "]");
                         josonMap.put("data", dataMap);
-                        Map attrMap = new HashMap();
+                        Map<String, String> attrMap = new HashMap<>();
                         attrMap.put("parentGroupId", productStoreGroupId);
                         josonMap.put("attr",attrMap);
                         josonMap.put("sequenceNum",child.get("sequenceNum"));