svn commit: r1838665 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java

Author: jleroux
Date: Wed Aug 22 16:59:59 2018
New Revision: 1838665

URL: http://svn.apache.org/viewvc?rev=1838665&view=rev
Log:
Fixed: Fix Default or Empty Catch block in Java and Groovy files
(OFBIZ-8341)

I was waiting for months to do more on this, but got caught recently with this
pending change merged with a patch I tested. Better to get rid of it now.

Modified:
    ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java

Modified: ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java?rev=1838665&r1=1838664&r2=1838665&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java (original)
+++ ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java Wed Aug 22 16:59:59 2018
@@ -643,7 +643,9 @@ public class ShoppingCartHelper {
                     } catch (CartItemModifyException e) {
                         errorMsgs.add(e.getMessage());
                     }
-                } catch (NumberFormatException nfe) {}
+                } catch (NumberFormatException nfe) {
+                    Debug.logError("Error deleting from cart: " + nfe.getMessage(), module);
+                }
             }
         }