svn commit: r1839787 - in /ofbiz/ofbiz-framework/trunk/applications/product: minilang/shipment/shipment/ShipmentServices.xml servicedef/services_shipment.xml

[nmalin]

Author: nmalin
Date: Fri Aug 31 19:17:39 2018
New Revision: 1839787

URL: http://svn.apache.org/viewvc?rev=1839787&view=rev
Log:
Improved: Add shipmentIds list parameter on quickShipPurchaseOrder service return
(OFBIZ-9376)

Service "quickShipPurchaseOrder" allows to create a reception for every ship group of a purchasing order. This work correctly but it didn't return shipments reference that has been created during the receptions.
Now we can obtains the shipmentIds list after a receipt to help the follow.

Thanks to Pierre Gaudin for this proposal

Modified:
    ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml
    ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_shipment.xml

Modified: ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml?rev=1839787&r1=1839786&r2=1839787&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml Fri Aug 31 19:17:39 2018
@@ -1364,7 +1364,8 @@ under the License.
         <entity-one entity-name="Facility" value-field="facility"/>
         <call-simple-method method-name="getOrderItemShipGroupLists"/>
         <call-simple-method method-name="createShipmentForFacilityAndShipGroup"/>
-        <log level="info" message="Finished quickShipPurchaseOrder for orderId ${parameters.orderId} and destination facilityId ${parameters.facilityId}"/>
+        <log level="info" message="Finished quickShipPurchaseOrder for orderId ${parameters.orderId} and destination facilityId ${parameters.facilityId} shipment created ${shipmentIds}"/>
+        <field-to-result field="shipmentIds" result-name="shipmentIds"/>
     </simple-method>
 
     <simple-method method-name="getOrderItemShipGroupLists"
@@ -1545,9 +1546,11 @@ under the License.
                 <set field="argListNames[]" from-field="shipmentShipGroupFacility.facilityId"/>
                 <property-to-field property="FacilityShipmentIdCreated" resource="ProductUiLabels" field="successMessage" arg-list-name="argListNames"/>
                 <clear-field field="shipmentShipGroupFacility"/>
+                <set field="shipmentIds[]" from-field="shipment.shipmentId"/>
             </else>
             </if-empty>
         </iterate>
+        <field-to-result field="shipmentIds" result-name="shipmentIds"/>
     </simple-method>
 
     <simple-method method-name="createOrderShipmentPlan" short-description="Create Shipment, ShipmentItems and OrderShipment">

Modified: ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_shipment.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_shipment.xml?rev=1839787&r1=1839786&r2=1839787&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_shipment.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_shipment.xml Fri Aug 31 19:17:39 2018
@@ -73,6 +73,7 @@ under the License.
         <attribute name="eventDate" type="Timestamp" mode="IN" optional="true"/>
         <!-- A List of Maps, each with a shipmentId,a facilityId, and a shipGroupSeqId for each shipment created -->
         <attribute name="shipmentShipGroupFacilityList" type="List" mode="OUT" optional="false"/>
+        <attribute name="shipmentIds" type="List" mode="OUT" optional="true"/>
     </service>
     <service name="quickShipOrderByItem" engine="simple"
             location="component://product/minilang/shipment/shipment/ShipmentServices.xml" invoke="quickShipOrderByItem" auth="true">
@@ -93,6 +94,7 @@ under the License.
         </description>
         <attribute name="orderId" type="String" mode="IN" optional="false"/>
         <attribute name="facilityId" type="String" mode="IN" optional="false"/>
+        <attribute name="shipmentIds" type="List" mode="OUT" optional="true"/>
     </service>
     <service name="createShipmentForReturn" default-entity-name="ReturnHeader" engine="simple"
             location="component://product/minilang/shipment/shipment/ShipmentServices.xml" invoke="createShipmentForReturn">