svn commit: r1845074 - in /ofbiz/ofbiz-framework/trunk/applications/accounting/servicedef: secas_invoice.xml secas_payment.xml

[surajk]

Author: surajk
Date: Mon Oct 29 06:29:17 2018
New Revision: 1845074

URL: http://svn.apache.org/viewvc?rev=1845074&view=rev
Log:
Improved: Consistency and Readability improvements for condition tag.
(OFBIZ-8991)
Thanks Ankush Upadhyay for reporting and Devanshu Vyas for providing the updated patch.

Modified:
    ofbiz/ofbiz-framework/trunk/applications/accounting/servicedef/secas_invoice.xml
    ofbiz/ofbiz-framework/trunk/applications/accounting/servicedef/secas_payment.xml

Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/servicedef/secas_invoice.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/servicedef/secas_invoice.xml?rev=1845074&r1=1845073&r2=1845074&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/accounting/servicedef/secas_invoice.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/accounting/servicedef/secas_invoice.xml Mon Oct 29 06:29:17 2018
@@ -37,13 +37,13 @@ under the License.
     </eca>
 
     <eca service="setInvoiceStatus" event="commit">
-        <condition operator="equals" field-name="statusId" value="INVOICE_APPROVED"/>
-        <condition operator="not-equals" field-name="oldStatusId" value="INVOICE_APPROVED"/>
+        <condition field-name="statusId" operator="equals" value="INVOICE_APPROVED"/>
+        <condition field-name="oldStatusId" operator="not-equals" value="INVOICE_APPROVED"/>
         <action service="createMatchingPaymentApplication" mode="sync"/>
     </eca>
     <eca service="setInvoiceStatus" event="return">
-        <condition operator="equals" field-name="statusId" value="INVOICE_READY"/>
-        <condition operator="equals" field-name="oldStatusId" value="INVOICE_IN_PROCESS"/>
+        <condition field-name="statusId" operator="equals" value="INVOICE_READY"/>
+        <condition field-name="oldStatusId" operator="equals" value="INVOICE_IN_PROCESS"/>
         <action service="createMatchingPaymentApplication" mode="sync"/>
     </eca>
 

Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/servicedef/secas_payment.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/servicedef/secas_payment.xml?rev=1845074&r1=1845073&r2=1845074&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/accounting/servicedef/secas_payment.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/accounting/servicedef/secas_payment.xml Mon Oct 29 06:29:17 2018
@@ -69,14 +69,14 @@ under the License.
      </eca>
 
     <eca service="setPaymentStatus" event="commit">
-        <condition operator="equals" field-name="statusId" value="PMNT_RECEIVED"/>
-        <condition operator="not-equals" field-name="oldStatusId" value="PMNT_RECEIVED"/>
+        <condition field-name="statusId" operator="equals" value="PMNT_RECEIVED"/>
+        <condition field-name="oldStatusId" operator="not-equals" value="PMNT_RECEIVED"/>
         <action service="createMatchingPaymentApplication" mode="sync"/>
     </eca>
 
     <eca service="setPaymentStatus" event="commit">
-        <condition operator="equals" field-name="statusId" value="PMNT_SENT"/>
-        <condition operator="not-equals" field-name="oldStatusId" value="PMNT_SENT"/>
+        <condition field-name="statusId" operator="equals" value="PMNT_SENT"/>
+        <condition field-name="oldStatusId" operator="not-equals" value="PMNT_SENT"/>
         <action service="createMatchingPaymentApplication" mode="sync"/>
     </eca>