svn commit: r1845081 - in /ofbiz/ofbiz-framework/trunk/applications/accounting/widget: GlForms.xml GlSetupForms.xml ReportFinancialSummaryForms.xml

[surajk]

Author: surajk
Date: Mon Oct 29 08:02:45 2018
New Revision: 1845081

URL: http://svn.apache.org/viewvc?rev=1845081&view=rev
Log:
Improved: Consistency and Readability improvements for option (form widget) tag.
(OFBIZ-8930)
Thanks Devanshu Vyas for providing the updated patch.

Modified:
    ofbiz/ofbiz-framework/trunk/applications/accounting/widget/GlForms.xml
    ofbiz/ofbiz-framework/trunk/applications/accounting/widget/GlSetupForms.xml
    ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml

Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/widget/GlForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/widget/GlForms.xml?rev=1845081&r1=1845080&r2=1845081&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/accounting/widget/GlForms.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/accounting/widget/GlForms.xml Mon Oct 29 08:02:45 2018
@@ -51,8 +51,8 @@ under the License.
         </field>
         <field name="isPosted"  position="1">
             <drop-down allow-empty="true">
-                <option description="${uiLabelMap.CommonNo}" key="N"/>
-                <option description="${uiLabelMap.CommonYes}" key="Y"/>
+                <option key="N" description="${uiLabelMap.CommonNo}"/>
+                <option key="Y" description="${uiLabelMap.CommonYes}"/>
             </drop-down>
         </field>
         <field name="invoiceId" position="2"><lookup target-form-name="LookupInvoice" size="20" maxlength="20"/></field>
@@ -228,8 +228,8 @@ under the License.
         </field>
         <field name="isPosted">
             <drop-down allow-empty="true">
-                <option description="${uiLabelMap.CommonNo}" key="N"/>
-                <option description="${uiLabelMap.CommonYes}" key="Y"/>
+                <option key="N" description="${uiLabelMap.CommonNo}"/>
+                <option key="Y" description="${uiLabelMap.CommonYes}"/>
             </drop-down>
         </field>
         <field name="partyId" title="${uiLabelMap.PartyPartyId}">
@@ -245,8 +245,8 @@ under the License.
         <field name="performSearch"><hidden value="Y"/></field>
         <field name="reportType">
             <drop-down allow-empty="false">
-                <option description="${uiLabelMap.AccountingByAccount}" key="byAccount"/>
-                <option description="${uiLabelMap.AccountingByDate}" key="byDate"/>
+                <option key="byAccount" description="${uiLabelMap.AccountingByAccount}"/>
+                <option key="byDate" description="${uiLabelMap.AccountingByDate}"/>
             </drop-down>
         </field>
         <field name="submitButton" title="${uiLabelMap.CommonFind}" widget-style="buttontext"><submit button-type="text-link"/></field>
@@ -587,8 +587,8 @@ under the License.
         </field>
         <field name="debitCreditFlag" position="1" entry-name="resetFieldValue">
             <drop-down current="selected">
-                <option description="${uiLabelMap.FormFieldTitle_credit}" key="C"/>
-                <option description="${uiLabelMap.FormFieldTitle_debit}" key="D"/>
+                <option key="C" description="${uiLabelMap.FormFieldTitle_credit}"/>
+                <option key="D" description="${uiLabelMap.FormFieldTitle_debit}"/>
             </drop-down>
         </field>
         <field name="partyId" position="2"><text size="30"/></field>
@@ -673,8 +673,8 @@ under the License.
         <field name="isSummary"><display/></field>
         <field name="debitCreditFlag">
             <drop-down current="selected">
-                <option description="${uiLabelMap.FormFieldTitle_credit}" key="C"/>
-                <option description="${uiLabelMap.FormFieldTitle_debit}" key="D"/>
+                <option key="C" description="${uiLabelMap.FormFieldTitle_credit}"/>
+                <option key="D" description="${uiLabelMap.FormFieldTitle_debit}"/>
             </drop-down>
         </field>
         <field name="origAmount"><display type="currency" currency="${origCurrencyUomId}"/></field>
@@ -737,8 +737,8 @@ under the License.
         <field name="scheduledPostingDate"  position="2"></field>
         <field name="isPosted"  position="1">
             <drop-down allow-empty="true">
-                <option description="${uiLabelMap.CommonNo}" key="N"/>
-                <option description="${uiLabelMap.CommonYes}" key="Y"/>
+                <option key="N" description="${uiLabelMap.CommonNo}"/>
+                <option key="Y" description="${uiLabelMap.CommonYes}"/>
             </drop-down>
         </field>
         <field name="postedDate" position="2"><date-time/></field>

Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/widget/GlSetupForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/widget/GlSetupForms.xml?rev=1845081&r1=1845080&r2=1845081&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/accounting/widget/GlSetupForms.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/accounting/widget/GlSetupForms.xml Mon Oct 29 08:02:45 2018
@@ -802,8 +802,8 @@ under the License.
         <field name="organizationPartyId"><hidden value="${organizationPartyId}"/></field>
         <field name="isClosed">
             <drop-down>
-                <option description="${uiLabelMap.CommonNo}" key="N"/>
-                <option description="${uiLabelMap.CommonYes}" key="Y"/>
+                <option key="N" description="${uiLabelMap.CommonNo}"/>
+                <option key="Y" description="${uiLabelMap.CommonYes}"/>
             </drop-down>
         </field>
         <field name="parentPeriodId">

Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml?rev=1845081&r1=1845080&r2=1845081&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml Mon Oct 29 08:02:45 2018
@@ -503,9 +503,9 @@ under the License.
         </field>
         <field name="isPosted">
             <drop-down>
-                <option description="${uiLabelMap.CommonYes}" key="Y"/>
-                <option description="${uiLabelMap.CommonNo}" key="N"/>
-                <option description="${uiLabelMap.CommonAll}" key="ALL"/>
+                <option key="Y" description="${uiLabelMap.CommonYes}"/>
+                <option key="N" description="${uiLabelMap.CommonNo}"/>
+                <option key="ALL" description="${uiLabelMap.CommonAll}"/>
             </drop-down>
         </field>
         <field name="submitButton" widget-style="buttontext"><submit button-type="text-link"/></field>