svn commit: r1848447 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/eway/GatewayResponse.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1848447 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/eway/GatewayResponse.java

mbrohl
Author: mbrohl
Date: Sat Dec  8 09:39:29 2018
New Revision: 1848447

URL: http://svn.apache.org/viewvc?rev=1848447&view=rev
Log:
Fallthrough in switch-case of eway/GatewayResponse.java
(OFBIZ-10642)

There were breaks missing in the switch case.

Thanks Benjamin Jugl for providing the patch.

Modified:
    ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/eway/GatewayResponse.java

Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/eway/GatewayResponse.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/eway/GatewayResponse.java?rev=1848447&r1=1848446&r2=1848447&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/eway/GatewayResponse.java (original)
+++ ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/eway/GatewayResponse.java Sat Dec  8 09:39:29 2018
@@ -157,30 +157,40 @@ public class GatewayResponse {
             switch(name) {
             case "ewayTrxnError":
                 txTrxnError = value;
+                break;
             case "ewayTrxnStatus":
                 if ("true".equals(value.toLowerCase(Locale.getDefault()).trim())) {
                     txTrxnStatus = true;
                 }
+                break;
             case "ewayTrxnNumber":
                 txTrxnNumber = value;
+                break;
             case "ewayTrxnOption1":
                 txTrxnOption1 = value;
+                break;
             case "ewayTrxnOption2":
                 txTrxnOption2 = value;
+                break;
             case "ewayTrxnOption3":
                 txTrxnOption3 = value;
+                break;
             case "ewayReturnAmount":
                 if (!value.equals("")) {
                     txReturnAmount = Integer.parseInt(value);
                 }
+                break;
             case "ewayAuthCode":
                 txAuthCode = value;
+                break;
             case "ewayTrxnReference":
                 txTrxnReference = value;
+                break;
             case "ewayBeagleScore":
                 if (!value.equals("")) {
                     txBeagleScore = Double.parseDouble(value);
                 }
+                break;
             default:
                 throw new Exception("Unknown field in response: " + name);
             }