svn commit: r1850958 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java

[mbrohl]

Author: mbrohl
Date: Thu Jan 10 16:19:10 2019
New Revision: 1850958

URL: http://svn.apache.org/viewvc?rev=1850958&view=rev
Log:
Improved: ‘EntityOperator#getId()’ is not used in the framework
(OFBIZ-10607)

Thanks Mathieu Lirzin for reporting and providing the patch.

Modified:
    ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java

Modified: ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java?rev=1850958&r1=1850957&r2=1850958&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java (original)
+++ ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java Thu Jan 10 16:19:10 2019
@@ -28,7 +28,6 @@ import java.util.Iterator;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
-import java.util.concurrent.atomic.AtomicInteger;
 
 import org.apache.ofbiz.base.util.UtilGenerics;
 import org.apache.ofbiz.entity.Delegator;
@@ -60,7 +59,6 @@ public abstract class EntityOperator<L,
     public static final int ID_NOT_IN = 13;
     public static final int ID_NOT_LIKE = 14;
 
-    private static final AtomicInteger dynamicId = new AtomicInteger();
     private static HashMap<String, EntityOperator<?,?,?>> registry = new HashMap<>();
 
     private static <L,R,T> void registerCase(String name, EntityOperator<L,R,T> operator) {
@@ -94,10 +92,6 @@ public abstract class EntityOperator<L,
         return UtilGenerics.cast(operator);
     }
 
-    public static int requestId() {
-        return dynamicId.get();
-    }
-
     public static final EntityComparisonOperator<?,?> EQUALS = new ComparableEntityComparisonOperator<Object>(ID_EQUALS, "=") {
         @Override
         public boolean compare(Comparable<Object> lhs, Object rhs) { return EntityComparisonOperator.compareEqual(lhs, rhs); }