svn commit: r1851321 - in /ofbiz/ofbiz-framework/branche
Locked
svn commit: r1851321 - in /ofbiz/ofbiz-framework/branche
 
|
Author: jleroux
Date: Tue Jan 15 07:44:33 2019 New Revision: 1851321 URL: http://svn.apache.org/viewvc?rev=1851321&view=rev Log: "Applied fix from trunk for revision: 1851319" ------------------------------------------------------------------------ r1851319 | jleroux | 2019-01-15 08:43:36 +0100 (mar. 15 janv. 2019) | 12 lignes Fixed: partyId misses in EditEftAccount.ftl (party) when you create an EFT account from the quick finalize page (OFBIZ-10680) If you split the payment and want to create an EFT account you get an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is missing. Adds the patch to add the partyId field that was missing while creating an EFT account or credit card in split payment mode. Added proper checks to avoid the broken screen in case the parameter is missing. Thanks: Ankit Joshi for the fix ------------------------------------------------------------------------ Modified: ofbiz/ofbiz-framework/branches/release17.12/ (props changed) ofbiz/ofbiz-framework/branches/release17.12/applications/order/template/entry/CheckoutPayment.ftl ofbiz/ofbiz-framework/branches/release17.12/applications/party/template/party/EditCreditCard.ftl ofbiz/ofbiz-framework/branches/release17.12/applications/party/template/party/EditEftAccount.ftl Propchange: ofbiz/ofbiz-framework/branches/release17.12/ ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Jan 15 07:44:33 2019 @@ -10,4 +10,4 @@ /ofbiz/branches/json-integration-refactoring:1634077-1635900 /ofbiz/branches/multitenant20100310:921280-927264 /ofbiz/branches/release13.07:1547657 -/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,1840189,1840199,1840828,1841657,1841662,1842372,1842921,1843225,1843893,1844943,1845418,1845420,1845466,1845544,1845552,1845558,1845933,1845995,1846097,1846107,1846214,1846594,1846632,1847398,1847478,1847670,1847715, 1847890,1848263,1848336,1848386,1848398,1848441,1848444,1848447,1848449,1848467,1848469,1848745,1848849-1848850,1849021,1849191,1849193,1849275,1849467,1849528,1849540,1849567,1849693,1850015,1850023,1850530,1850647,1850685,1850694,1850914,1850918,1850948,1850953,1851006,1851068,1851074,1851130,1851158,1851163,1851200,1851247 +/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,1840189,1840199,1840828,1841657,1841662,1842372,1842921,1843225,1843893,1844943,1845418,1845420,1845466,1845544,1845552,1845558,1845933,1845995,1846097,1846107,1846214,1846594,1846632,1847398,1847478,1847670,1847715, 1847890,1848263,1848336,1848386,1848398,1848441,1848444,1848447,1848449,1848467,1848469,1848745,1848849-1848850,1849021,1849191,1849193,1849275,1849467,1849528,1849540,1849567,1849693,1850015,1850023,1850530,1850647,1850685,1850694,1850914,1850918,1850948,1850953,1851006,1851068,1851074,1851130,1851158,1851163,1851200,1851247,1851319 Modified: ofbiz/ofbiz-framework/branches/release17.12/applications/order/template/entry/CheckoutPayment.ftl URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/applications/order/template/entry/CheckoutPayment.ftl?rev=1851321&r1=1851320&r2=1851321&view=diff ============================================================================== --- ofbiz/ofbiz-framework/branches/release17.12/applications/order/template/entry/CheckoutPayment.ftl (original) +++ ofbiz/ofbiz-framework/branches/release17.12/applications/order/template/entry/CheckoutPayment.ftl Tue Jan 15 07:44:33 2019 @@ -32,7 +32,7 @@ function submitForm(form, mode, value) { form.submit(); } else if ("NC" == mode) { // new credit card - form.action="<@ofbizUrl>updateCheckoutOptions/editcreditcard?DONE_PAGE=checkoutpayment</@ofbizUrl>"; + form.action="<@ofbizUrl>updateCheckoutOptions/editcreditcard?DONE_PAGE=checkoutpayment&partyId=${shoppingCart.getPartyId()}</@ofbizUrl>"; form.submit(); } else if ("EC" == mode) { // edit credit card @@ -40,19 +40,19 @@ function submitForm(form, mode, value) { form.submit(); } else if ("GC" == mode) { // edit gift card - form.action="<@ofbizUrl>updateCheckoutOptions/editgiftcard?paymentMethodId="+value+"</@ofbizUrl>"; + form.action="<@ofbizUrl>updateCheckoutOptions/editgiftcard?partyId=${shoppingCart.getPartyId()}&paymentMethodId="+value+"</@ofbizUrl>"; form.submit(); } else if ("NE" == mode) { // new eft account - form.action="<@ofbizUrl>updateCheckoutOptions/editeftaccount?DONE_PAGE=checkoutpayment</@ofbizUrl>"; + form.action="<@ofbizUrl>updateCheckoutOptions/editeftaccount?DONE_PAGE=checkoutpayment&partyId=${shoppingCart.getPartyId()}</@ofbizUrl>"; form.submit(); } else if ("EE" == mode) { // edit eft account - form.action="<@ofbizUrl>updateCheckoutOptions/editeftaccount?DONE_PAGE=checkoutpayment&paymentMethodId="+value+"</@ofbizUrl>"; + form.action="<@ofbizUrl>updateCheckoutOptions/editeftaccount?DONE_PAGE=checkoutpayment&partyId=${shoppingCart.getPartyId()}&paymentMethodId="+value+"</@ofbizUrl>"; form.submit(); }else if(mode = "EG") //edit gift card - form.action="<@ofbizUrl>updateCheckoutOptions/editgiftcard?DONE_PAGE=checkoutpayment&paymentMethodId="+value+"</@ofbizUrl>"; + form.action="<@ofbizUrl>updateCheckoutOptions/editgiftcard?DONE_PAGE=checkoutpayment&partyId=${shoppingCart.getPartyId()}&paymentMethodId="+value+"</@ofbizUrl>"; form.submit(); } //]]> Modified: ofbiz/ofbiz-framework/branches/release17.12/applications/party/template/party/EditCreditCard.ftl URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/applications/party/template/party/EditCreditCard.ftl?rev=1851321&r1=1851320&r2=1851321&view=diff ============================================================================== --- ofbiz/ofbiz-framework/branches/release17.12/applications/party/template/party/EditCreditCard.ftl (original) +++ ofbiz/ofbiz-framework/branches/release17.12/applications/party/template/party/EditCreditCard.ftl Tue Jan 15 07:44:33 2019 @@ -28,7 +28,7 @@ under the License. </div> <div class="screenlet-body"> <div class="button-bar"> - <a href="<@ofbizUrl>${donePage}?partyId=${partyId}</@ofbizUrl>" class="smallSubmit">${uiLabelMap.CommonCancelDone}</a> + <a href="<@ofbizUrl>${donePage}?partyId=${partyId!}</@ofbizUrl>" class="smallSubmit">${uiLabelMap.CommonCancelDone}</a> <a href="javascript:document.editcreditcardform.submit()" class="smallSubmit">${uiLabelMap.CommonSave}</a> </div> <#if !creditCard??> @@ -37,7 +37,7 @@ under the License. <form method="post" action="<@ofbizUrl>updateCreditCard?DONE_PAGE=${donePage}</@ofbizUrl>" name="editcreditcardform" style="margin: 0;"> <input type="hidden" name="paymentMethodId" value="${paymentMethodId}" /> </#if> - <input type="hidden" name="partyId" value="${partyId}"/> + <input type="hidden" name="partyId" value="${partyId!}"/> <table class="basic-table" cellspacing="0"> ${screens.render("component://accounting/widget/CommonScreens.xml#creditCardFields")} Modified: ofbiz/ofbiz-framework/branches/release17.12/applications/party/template/party/EditEftAccount.ftl URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/applications/party/template/party/EditEftAccount.ftl?rev=1851321&r1=1851320&r2=1851321&view=diff ============================================================================== --- ofbiz/ofbiz-framework/branches/release17.12/applications/party/template/party/EditEftAccount.ftl (original) +++ ofbiz/ofbiz-framework/branches/release17.12/applications/party/template/party/EditEftAccount.ftl Tue Jan 15 07:44:33 2019 @@ -28,7 +28,7 @@ under the License. </div> <div class="screenlet-body"> <div class="button-bar"> - <a href="<@ofbizUrl>${donePage}?partyId=${partyId}</@ofbizUrl>" class="smallSubmit">${uiLabelMap.CommonCancelDone}</a> + <a href="<@ofbizUrl>${donePage}?partyId=${partyId!}</@ofbizUrl>" class="smallSubmit">${uiLabelMap.CommonCancelDone}</a> <a href="javascript:document.editeftaccountform.submit()" class="smallSubmit">${uiLabelMap.CommonSave}</a> </div> <#if !eftAccount??> @@ -37,7 +37,7 @@ under the License. <form method="post" action='<@ofbizUrl>updateEftAccount?DONE_PAGE=${donePage}</@ofbizUrl>' name="editeftaccountform" style='margin: 0;'> <input type="hidden" name='paymentMethodId' value='${paymentMethodId}' /> </#if> - <input type="hidden" name="partyId" value="${partyId}"/> + <input type="hidden" name="partyId" value="${partyId!}"/> <table class="basic-table" cellspacing="0"> <tr> <td class="label">${uiLabelMap.AccountingNameAccount}</td> |
«
Return to OFBiz - Commits
|
1 view|%1 views
| Free forum by Nabble | Edit this page |