svn commit: r1857814 - in /ofbiz/ofbiz-framework/branches/release18.12: ./ applications/product/entitydef/eecas.xml

[Swapnil M Mane]

Author: swapnilmmane
Date: Fri Apr 19 14:08:07 2019
New Revision: 1857814

URL: http://svn.apache.org/viewvc?rev=1857814&view=rev
Log:
Applied fix from trunk for revision: 1857813
===

Fixed: If the picklist cancelation process failed, the picklist item shouldn't be marked as cancel
(OFBIZ-4690)

When a transaction is running in which Picklist entity is updated (i.e. canceled), now if the transaction is rollback the picklist status will not be changed but as per previous code, the picklist item's status will get updated i.e. marked as cancel because we called the cancelPicklistAndItems service in async mode

So the situation here was the Picklist is not canceled, but the Picklist items were marked as cancel.

Thus to fix it, call the cancelPicklistAndItems service in sync mode.

Thanks:  Jacques Le Roux for your thoughts.

Modified:
    ofbiz/ofbiz-framework/branches/release18.12/   (props changed)
    ofbiz/ofbiz-framework/branches/release18.12/applications/product/entitydef/eecas.xml

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Apr 19 14:08:07 2019
@@ -10,4 +10,4 @@
 /ofbiz/branches/json-integration-refactoring:1634077-1635900
 /ofbiz/branches/multitenant20100310:921280-927264
 /ofbiz/branches/release13.07:1547657
-/ofbiz/ofbiz-framework/trunk:1849931,1850015,1850023,1850530,1850647,1850685,1850694,1850711,1850914,1850918,1850921,1850948,1850953,1851006,1851013,1851068,1851074,1851130,1851158,1851200,1851224,1851247,1851254,1851315,1851319,1851350,1851353,1851433,1851500,1851805,1851885,1851998,1852503,1852587,1852818,1852882,1853070,1853109,1853691,1853745,1853750,1854306,1854457,1854683,1855078,1855083,1855287,1855371,1855403,1855488,1855492,1855497,1855501,1855898,1856212,1856405,1856455,1856459-1856460,1856484,1856598,1856610,1856613,1856617,1856667,1857099,1857152,1857154,1857173,1857180,1857213,1857392,1857617,1857692
+/ofbiz/ofbiz-framework/trunk:1849931,1850015,1850023,1850530,1850647,1850685,1850694,1850711,1850914,1850918,1850921,1850948,1850953,1851006,1851013,1851068,1851074,1851130,1851158,1851200,1851224,1851247,1851254,1851315,1851319,1851350,1851353,1851433,1851500,1851805,1851885,1851998,1852503,1852587,1852818,1852882,1853070,1853109,1853691,1853745,1853750,1854306,1854457,1854683,1855078,1855083,1855287,1855371,1855403,1855488,1855492,1855497,1855501,1855898,1856212,1856405,1856455,1856459-1856460,1856484,1856598,1856610,1856613,1856617,1856667,1857099,1857152,1857154,1857173,1857180,1857213,1857392,1857617,1857692,1857813

Modified: ofbiz/ofbiz-framework/branches/release18.12/applications/product/entitydef/eecas.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release18.12/applications/product/entitydef/eecas.xml?rev=1857814&r1=1857813&r2=1857814&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/branches/release18.12/applications/product/entitydef/eecas.xml (original)
+++ ofbiz/ofbiz-framework/branches/release18.12/applications/product/entitydef/eecas.xml Fri Apr 19 14:08:07 2019
@@ -73,7 +73,7 @@ under the License.
     <!-- If the Picklist status is Cancelled then cancel all the PicklistItems -->
     <eca entity="Picklist" operation="create-store" event="return">
         <condition field-name="statusId" operator="equals" value="PICKLIST_CANCELLED"/>
-        <action service="cancelPicklistAndItems" mode="async"/>
+        <action service="cancelPicklistAndItems" mode="sync"/>
     </eca>
 
     <!-- Product GroupOrder ECAs -->