Author: mthl
Date: Sun Apr 21 14:22:36 2019 New Revision: 1857913 URL: http://svn.apache.org/viewvc?rev=1857913&view=rev Log: Improved: Remove unnecessary declared exceptions for ‘ContainerException’ (OFBIZ-10938) Modified: ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/container/ComponentContainer.java ofbiz/ofbiz-framework/trunk/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/DelegatorContainer.java ofbiz/ofbiz-framework/trunk/framework/entityext/src/main/java/org/apache/ofbiz/entityext/data/EntityDataLoadContainer.java ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/ServiceContainer.java ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/mail/JavaMailContainer.java ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/rmi/RmiServiceContainer.java ofbiz/ofbiz-framework/trunk/framework/testtools/src/main/java/org/apache/ofbiz/testtools/TestRunContainer.java Modified: ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/container/ComponentContainer.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/container/ComponentContainer.java?rev=1857913&r1=1857912&r2=1857913&view=diff ============================================================================== --- ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/container/ComponentContainer.java (original) +++ ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/container/ComponentContainer.java Sun Apr 21 14:22:36 2019 @@ -83,7 +83,7 @@ public class ComponentContainer implemen /** * @see org.apache.ofbiz.base.container.Container#start() */ - public boolean start() throws ContainerException { + public boolean start() { return loaded.get(); } @@ -92,9 +92,8 @@ public class ComponentContainer implemen * and set the classloader as the context classloader * * @param componentsClassPath a list of classpaths for all components - * @throws ContainerException */ - private void loadClassPathForAllComponents(List<Classpath> componentsClassPath) throws ContainerException { + private void loadClassPathForAllComponents(List<Classpath> componentsClassPath) { List<URL> allComponentUrls = new ArrayList<>(); for(Classpath classPath : componentsClassPath) { try { @@ -365,7 +364,7 @@ public class ComponentContainer implemen /** * @see org.apache.ofbiz.base.container.Container#stop() */ - public void stop() throws ContainerException { + public void stop() { } public String getName() { Modified: ofbiz/ofbiz-framework/trunk/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java?rev=1857913&r1=1857912&r2=1857913&view=diff ============================================================================== --- ofbiz/ofbiz-framework/trunk/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java (original) +++ ofbiz/ofbiz-framework/trunk/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java Sun Apr 21 14:22:36 2019 @@ -147,7 +147,7 @@ public class CatalinaContainer implement return true; } - public void stop() throws ContainerException { + public void stop() { try { tomcat.stop(); } catch (LifecycleException e) { Modified: ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/DelegatorContainer.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/DelegatorContainer.java?rev=1857913&r1=1857912&r2=1857913&view=diff ============================================================================== --- ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/DelegatorContainer.java (original) +++ ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/DelegatorContainer.java Sun Apr 21 14:22:36 2019 @@ -45,7 +45,7 @@ public class DelegatorContainer implemen } @Override - public boolean start() throws ContainerException { + public boolean start() { if (UtilValidate.isEmpty(preloadedDelegatorNames)) { return true; } @@ -58,7 +58,7 @@ public class DelegatorContainer implemen } @Override - public void stop() throws ContainerException { + public void stop() { } @Override Modified: ofbiz/ofbiz-framework/trunk/framework/entityext/src/main/java/org/apache/ofbiz/entityext/data/EntityDataLoadContainer.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/entityext/src/main/java/org/apache/ofbiz/entityext/data/EntityDataLoadContainer.java?rev=1857913&r1=1857912&r2=1857913&view=diff ============================================================================== --- ofbiz/ofbiz-framework/trunk/framework/entityext/src/main/java/org/apache/ofbiz/entityext/data/EntityDataLoadContainer.java (original) +++ ofbiz/ofbiz-framework/trunk/framework/entityext/src/main/java/org/apache/ofbiz/entityext/data/EntityDataLoadContainer.java Sun Apr 21 14:22:36 2019 @@ -118,12 +118,12 @@ public class EntityDataLoadContainer imp } @Override - public boolean start() throws ContainerException { + public boolean start() { return true; } @Override - public void stop() throws ContainerException { + public void stop() { } @Override Modified: ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/ServiceContainer.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/ServiceContainer.java?rev=1857913&r1=1857912&r2=1857913&view=diff ============================================================================== --- ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/ServiceContainer.java (original) +++ ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/ServiceContainer.java Sun Apr 21 14:22:36 2019 @@ -61,12 +61,12 @@ public class ServiceContainer implements } @Override - public boolean start() throws ContainerException { + public boolean start() { return true; } @Override - public void stop() throws ContainerException { + public void stop() { JobManager.shutDown(); Set<String> dispatcherNames = getAllDispatcherNames(); for (String dispatcherName: dispatcherNames) { Modified: ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/mail/JavaMailContainer.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/mail/JavaMailContainer.java?rev=1857913&r1=1857912&r2=1857913&view=diff ============================================================================== --- ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/mail/JavaMailContainer.java (original) +++ ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/mail/JavaMailContainer.java Sun Apr 21 14:22:36 2019 @@ -75,7 +75,7 @@ public class JavaMailContainer implement private String name; @Override - public void init(List<StartupCommand> ofbizCommands, String name, String configFile) throws ContainerException { + public void init(List<StartupCommand> ofbizCommands, String name, String configFile) { this.name = name; this.configFile = configFile; this.stores = new LinkedHashMap<>(); @@ -126,7 +126,7 @@ public class JavaMailContainer implement } @Override - public void stop() throws ContainerException { + public void stop() { // stop the poller this.pollTimer.shutdown(); Debug.logWarning("stop JavaMail poller", module); Modified: ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/rmi/RmiServiceContainer.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/rmi/RmiServiceContainer.java?rev=1857913&r1=1857912&r2=1857913&view=diff ============================================================================== --- ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/rmi/RmiServiceContainer.java (original) +++ ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/rmi/RmiServiceContainer.java Sun Apr 21 14:22:36 2019 @@ -174,7 +174,8 @@ public class RmiServiceContainer impleme return true; } - public void stop() throws ContainerException { + @Override + public void stop() { remote.deregister(); } Modified: ofbiz/ofbiz-framework/trunk/framework/testtools/src/main/java/org/apache/ofbiz/testtools/TestRunContainer.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/testtools/src/main/java/org/apache/ofbiz/testtools/TestRunContainer.java?rev=1857913&r1=1857912&r2=1857913&view=diff ============================================================================== --- ofbiz/ofbiz-framework/trunk/framework/testtools/src/main/java/org/apache/ofbiz/testtools/TestRunContainer.java (original) +++ ofbiz/ofbiz-framework/trunk/framework/testtools/src/main/java/org/apache/ofbiz/testtools/TestRunContainer.java Sun Apr 21 14:22:36 2019 @@ -102,7 +102,7 @@ public class TestRunContainer implements return true; } - public void stop() throws ContainerException { + public void stop() { } public String getName() { |
Free forum by Nabble | Edit this page |