svn commit: r1858242 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/template/reports/ order/template/order/ product/template/facility/ product/template/shipment/

[surajk]

Author: surajk
Date: Sat Apr 27 06:15:14 2019
New Revision: 1858242

URL: http://svn.apache.org/viewvc?rev=1858242&view=rev
Log:
Improved: Use code128 instead of code39 for barcode generation.
(OFBIZ-10896)
Currently, we are using code39 to generate barcodes but there are some limitations of code39 as it only able to encrypt letters from A to Z, digits from 0 to 9 and an additional set of special characters – “. $ % + – / *”.
Thanks Pawan Verma for reporting, analysis and providing the patch. Thanks everyone else for providing their inputs during discussion on Dev ML.

Modified:
    ofbiz/ofbiz-framework/trunk/applications/manufacturing/template/reports/PRunsProductsStacks.fo.ftl
    ofbiz/ofbiz-framework/trunk/applications/manufacturing/template/reports/PackageContentsAndOrder.fo.ftl
    ofbiz/ofbiz-framework/trunk/applications/order/template/order/ShipGroups.fo.ftl
    ofbiz/ofbiz-framework/trunk/applications/product/template/facility/Picklist.fo.ftl
    ofbiz/ofbiz-framework/trunk/applications/product/template/facility/PrintPickSheets.fo.ftl
    ofbiz/ofbiz-framework/trunk/applications/product/template/shipment/PackingSlipShipmentBarCode.fo.ftl
    ofbiz/ofbiz-framework/trunk/applications/product/template/shipment/ShipmentBarCode.fo.ftl

Modified: ofbiz/ofbiz-framework/trunk/applications/manufacturing/template/reports/PRunsProductsStacks.fo.ftl
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/manufacturing/template/reports/PRunsProductsStacks.fo.ftl?rev=1858242&r1=1858241&r2=1858242&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/manufacturing/template/reports/PRunsProductsStacks.fo.ftl (original)
+++ ofbiz/ofbiz-framework/trunk/applications/manufacturing/template/reports/PRunsProductsStacks.fo.ftl Sat Apr 27 06:15:14 2019
@@ -163,9 +163,9 @@ under the License.
                                   <barcode:barcode
                                         xmlns:barcode="http://barcode4j.krysalis.org/ns"
                                         message="${productionRun.productionRun.workEffortId}">
-                                    <barcode:code39>
+                                    <barcode:code128>
                                       <barcode:height>8mm</barcode:height>
-                                    </barcode:code39>
+                                    </barcode:code128>
                                   </barcode:barcode>
                                 </fo:instream-foreign-object>
                             </fo:block>
@@ -245,9 +245,9 @@ under the License.
                                 <barcode:barcode
                                       xmlns:barcode="http://barcode4j.krysalis.org/ns"
                                       message="${stackInfo.qty}">
-                                  <barcode:code39>
+                                  <barcode:code128>
                                     <barcode:height>8mm</barcode:height>
-                                  </barcode:code39>
+                                  </barcode:code128>
                                 </barcode:barcode>
                               </fo:instream-foreign-object>
                             </fo:block>

Modified: ofbiz/ofbiz-framework/trunk/applications/manufacturing/template/reports/PackageContentsAndOrder.fo.ftl
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/manufacturing/template/reports/PackageContentsAndOrder.fo.ftl?rev=1858242&r1=1858241&r2=1858242&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/manufacturing/template/reports/PackageContentsAndOrder.fo.ftl (original)
+++ ofbiz/ofbiz-framework/trunk/applications/manufacturing/template/reports/PackageContentsAndOrder.fo.ftl Sat Apr 27 06:15:14 2019
@@ -126,9 +126,9 @@ Doc.B
                                   <barcode:barcode
                                         xmlns:barcode="http://barcode4j.krysalis.org/ns"
                                         message="${package.orderShipment.shipmentId}${package.packageId}">
-                                    <barcode:code39>
+                                    <barcode:code128>
                                       <barcode:height>8mm</barcode:height>
-                                    </barcode:code39>
+                                    </barcode:code128>
                                   </barcode:barcode>
                                 </fo:instream-foreign-object>
                             </fo:block>

Modified: ofbiz/ofbiz-framework/trunk/applications/order/template/order/ShipGroups.fo.ftl
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/template/order/ShipGroups.fo.ftl?rev=1858242&r1=1858241&r2=1858242&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/order/template/order/ShipGroups.fo.ftl (original)
+++ ofbiz/ofbiz-framework/trunk/applications/order/template/order/ShipGroups.fo.ftl Sat Apr 27 06:15:14 2019
@@ -36,7 +36,7 @@ under the License.
           <fo:block text-align="right">
             <fo:instream-foreign-object>
               <barcode:barcode xmlns:barcode="http://barcode4j.krysalis.org/ns" message="${shipGroup.orderId}">
-                <barcode:code39><barcode:height>8mm</barcode:height></barcode:code39>
+                <barcode:code128><barcode:height>8mm</barcode:height></barcode:code128>
               </barcode:barcode>
             </fo:instream-foreign-object>
           </fo:block>
@@ -50,7 +50,7 @@ under the License.
           <fo:block text-align="right">
             <fo:instream-foreign-object>
               <barcode:barcode xmlns:barcode="http://barcode4j.krysalis.org/ns" message="${shipGroup.shipGroupSeqId}">
-                <barcode:code39><barcode:height>8mm</barcode:height></barcode:code39>
+                <barcode:code128><barcode:height>8mm</barcode:height></barcode:code128>
               </barcode:barcode>
             </fo:instream-foreign-object>
           </fo:block>

Modified: ofbiz/ofbiz-framework/trunk/applications/product/template/facility/Picklist.fo.ftl
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/template/facility/Picklist.fo.ftl?rev=1858242&r1=1858241&r2=1858242&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/template/facility/Picklist.fo.ftl (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/template/facility/Picklist.fo.ftl Sat Apr 27 06:15:14 2019
@@ -207,9 +207,9 @@ under the License.
                 <fo:instream-foreign-object>
                     <barcode:barcode xmlns:barcode="http://barcode4j.krysalis.org/ns"
                             message="${picklistBinInfo.primaryOrderHeader.orderId}/${picklistBinInfo.primaryOrderItemShipGroup.shipGroupSeqId}">
-                        <barcode:code39>
+                        <barcode:code128>
                             <barcode:height>8mm</barcode:height>
-                        </barcode:code39>
+                        </barcode:code128>
                     </barcode:barcode>
                 </fo:instream-foreign-object>
             </fo:block>

Modified: ofbiz/ofbiz-framework/trunk/applications/product/template/facility/PrintPickSheets.fo.ftl
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/template/facility/PrintPickSheets.fo.ftl?rev=1858242&r1=1858241&r2=1858242&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/template/facility/PrintPickSheets.fo.ftl (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/template/facility/PrintPickSheets.fo.ftl Sat Apr 27 06:15:14 2019
@@ -49,9 +49,9 @@ under the License.
                                 <fo:instream-foreign-object>
                                     <barcode:barcode xmlns:barcode="http://barcode4j.krysalis.org/ns"
                                             message="${orderId}/${shipGroupSeqId}">
-                                        <barcode:code39>
+                                        <barcode:code128>
                                             <barcode:height>8mm</barcode:height>
-                                        </barcode:code39>
+                                        </barcode:code128>
                                     </barcode:barcode>
                                 </fo:instream-foreign-object>
                             </fo:block>

Modified: ofbiz/ofbiz-framework/trunk/applications/product/template/shipment/PackingSlipShipmentBarCode.fo.ftl
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/template/shipment/PackingSlipShipmentBarCode.fo.ftl?rev=1858242&r1=1858241&r2=1858242&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/template/shipment/PackingSlipShipmentBarCode.fo.ftl (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/template/shipment/PackingSlipShipmentBarCode.fo.ftl Sat Apr 27 06:15:14 2019
@@ -22,9 +22,9 @@ under the License.
                 <fo:instream-foreign-object>
                     <barcode:barcode xmlns:barcode="http://barcode4j.krysalis.org/ns"
                             message="${shipment.shipmentId}">
-                        <barcode:code39>
+                        <barcode:code128>
                             <barcode:height>8mm</barcode:height>
-                        </barcode:code39>
+                        </barcode:code128>
                     </barcode:barcode>
                 </fo:instream-foreign-object>
             </fo:block>

Modified: ofbiz/ofbiz-framework/trunk/applications/product/template/shipment/ShipmentBarCode.fo.ftl
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/template/shipment/ShipmentBarCode.fo.ftl?rev=1858242&r1=1858241&r2=1858242&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/template/shipment/ShipmentBarCode.fo.ftl (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/template/shipment/ShipmentBarCode.fo.ftl Sat Apr 27 06:15:14 2019
@@ -35,10 +35,10 @@ under the License.
                 <fo:instream-foreign-object>
                     <barcode:barcode xmlns:barcode="http://barcode4j.krysalis.org/ns"
                                      message="${shipmentId}">
-                        <barcode:code39>
+                        <barcode:code128>
                             <barcode:height>3in</barcode:height>
                             <barcode:module-width>1.5mm</barcode:module-width>
-                        </barcode:code39>
+                        </barcode:code128>
                         <barcode:human-readable>
                             <barcode:placement>bottom</barcode:placement>
                             <barcode:font-name>Helvetica</barcode:font-name>