svn commit: r1859920 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1859920 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java

mthl
Author: mthl
Date: Sat May 25 09:10:12 2019
New Revision: 1859920

URL: http://svn.apache.org/viewvc?rev=1859920&view=rev
Log:
Improved: Remove useless ‘StringUtil#join’ overload
(OFBIZ-11014)

‘List’ extends ‘Collection’ so there is no need to overload
‘StringUtil#join(Collection,String)’ with ‘StringUtil#join(List,String)’.

Modified:
    ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java

Modified: ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java?rev=1859920&r1=1859919&r2=1859920&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java (original)
+++ ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java Sat May 25 09:10:12 2019
@@ -100,16 +100,6 @@ public class StringUtil {
     }
 
     /**
-     * Creates a single string from a List of strings seperated by a delimiter.
-     * @param list a list of strings to join
-     * @param delim the delimiter character(s) to use. (null value will join with no delimiter)
-     * @return a String of all values in the list seperated by the delimiter
-     */
-    public static String join(List<?> list, String delim) {
-        return join ((Collection<?>) list, delim);
-    }
-
-    /**
      * Creates a single string from a Collection of strings seperated by a delimiter.
      * @param col a collection of strings to join
      * @param delim the delimiter character(s) to use. (null value will join with no delimiter)