svn commit: r1863390 - /ofbiz/ofbiz-plugins/trunk/webpos/src/main/java/org/apache/ofbiz/webpos/WebPosEvents.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1863390 - /ofbiz/ofbiz-plugins/trunk/webpos/src/main/java/org/apache/ofbiz/webpos/WebPosEvents.java

mthl
Author: mthl
Date: Fri Jul 19 13:38:49 2019
New Revision: 1863390

URL: http://svn.apache.org/viewvc?rev=1863390&view=rev
Log:
Improved: Do not use ‘UtilMisc#toList’
(OFBIZ-11140)

Modified:
    ofbiz/ofbiz-plugins/trunk/webpos/src/main/java/org/apache/ofbiz/webpos/WebPosEvents.java

Modified: ofbiz/ofbiz-plugins/trunk/webpos/src/main/java/org/apache/ofbiz/webpos/WebPosEvents.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/webpos/src/main/java/org/apache/ofbiz/webpos/WebPosEvents.java?rev=1863390&r1=1863389&r2=1863390&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/trunk/webpos/src/main/java/org/apache/ofbiz/webpos/WebPosEvents.java (original)
+++ ofbiz/ofbiz-plugins/trunk/webpos/src/main/java/org/apache/ofbiz/webpos/WebPosEvents.java Fri Jul 19 13:38:49 2019
@@ -197,8 +197,7 @@ public class WebPosEvents {
                                         if (UtilValidate.isNotEmpty(variantTree)) {
                                             request.setAttribute("variantTree", variantTree);
                                             request.setAttribute("variantTreeSize", variantTree.size());
-                                            List<String> featureOrder = new LinkedList<>();
-                                            featureOrder = UtilMisc.toList(featureSet);
+                                            List<String> featureOrder = new LinkedList<>(featureSet);
                                             for (int i=0; i < featureOrder.size(); i++) {
                                                 String featureKey = featureOrder.get(i);
                                                 GenericValue featureValue = EntityQuery.use(delegator).from("ProductFeatureType").where("productFeatureTypeId", featureOrder.get(i)).cache().queryOne();
@@ -218,7 +217,7 @@ public class WebPosEvents {
                                         Map<String, Object> imageMap = UtilGenerics.cast(variantTreeMap.get("variantSample"));
                                         if (UtilValidate.isNotEmpty(imageMap)) {
                                             List<String> variantSampleList = new LinkedList<>();
-                                            variantSampleList = UtilMisc.toList(imageMap.keySet());
+                                            variantSampleList = new LinkedList<>(imageMap.keySet());
                                             request.setAttribute("variantSample", imageMap);
                                             request.setAttribute("variantSampleList", variantSampleList);
                                             request.setAttribute("variantSampleSize", imageMap.size());