svn commit: r1866890 - /ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ar/InvoiceScreens.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1866890 - /ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ar/InvoiceScreens.xml

jleroux@apache.org
Author: jleroux
Date: Fri Sep 13 10:15:03 2019
New Revision: 1866890

URL: http://svn.apache.org/viewvc?rev=1866890&view=rev
Log:
Improved: FindArInvoices request needs performance improvement regarding use of
EntityListIterator::hasNext method
(OFBIZ-11198)

FindAPInvoices request  does not suffer from this issue nor findInvoice request.

This was due to <screen name="FindArInvoices"> definition
Using something similar than <screen name="FindApInvoices"> fixes the issue

Modified:
    ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ar/InvoiceScreens.xml

Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ar/InvoiceScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ar/InvoiceScreens.xml?rev=1866890&r1=1866889&r2=1866890&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ar/InvoiceScreens.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ar/InvoiceScreens.xml Fri Sep 13 10:15:03 2019
@@ -63,12 +63,7 @@ under the License.
         <section>
             <actions>
                 <set field="titleProperty" value="AccountingFindArInvoices"/>
-                <service service-name="performFind" result-map="result">
-                    <field-map field-name="inputFields" from-field="parameters"/>
-                    <field-map field-name="entityName" value="InvoiceAndType"/>
-                    <field-map field-name="orderBy" value="invoiceDate DESC"/>
-                </service>
-                <set field="invoices" from-field="result.listIt"/>
+                <set field="tabButtonItem" value="viewInvoices"/>
             </actions>
             <widgets>
                 <decorator-screen name="CommonInvoiceDecorator" location="${parameters.mainDecoratorLocation}">
@@ -85,9 +80,7 @@ under the License.
                                         <include-form name="FindArInvoices" location="component://accounting/widget/ar/forms/InvoiceForms.xml"/>
                                     </decorator-section>
                                     <decorator-section name="search-results">
-                                        <platform-specific>
-                                            <html><html-template location="component://accounting/template/ar/invoice/ListInvoices.ftl"/></html>
-                                        </platform-specific>
+                                        <include-form name="ListInvoices" location="component://accounting/widget/InvoiceForms.xml"/>
                                     </decorator-section>
                                 </decorator-screen>
                             </widgets>