svn commit: r1866931 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/collections/LifoSet.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1866931 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/collections/LifoSet.java

jleroux@apache.org
Author: jleroux
Date: Sat Sep 14 09:29:06 2019
New Revision: 1866931

URL: http://svn.apache.org/viewvc?rev=1866931&view=rev
Log:
Improved: Refactor boolean returns from methods
(OFBIZ-10725)

Stumbled upon it by chance, a last one

Modified:
    ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/collections/LifoSet.java

Modified: ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/collections/LifoSet.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/collections/LifoSet.java?rev=1866931&r1=1866930&r2=1866931&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/collections/LifoSet.java (original)
+++ ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/collections/LifoSet.java Sat Sep 14 09:29:06 2019
@@ -105,10 +105,7 @@ public class LifoSet<V> extends Abstract
      * @return true if and only if this stack contains no items; false otherwise
      */
     public boolean empty() {
-        if (this.size() == 0) {
-            return true;
-        }
-        return false;
+        return this.size() == 0;
     }
 
     /**