svn commit: r1867720 - in /ofbiz/ofbiz-plugins/branches/release18.12: ./ ecommerce/template/catalog/ProductReview.ftl

Author: jleroux
Date: Sun Sep 29 11:00:35 2019
New Revision: 1867720

URL: http://svn.apache.org/viewvc?rev=1867720&view=rev
Log:
"Applied fix from plugins for revision: 1867717"
------------------------------------------------------------------------
r1867717 | jleroux | 2019-09-29 11:43:42 +0200 (dim. 29 sept. 2019) | 11 lignes

Fixed: Freemarker error on reviewProduct page on storefront
(OFBIZ-11108)

Steps to regenerate:
1)Navigate to https://demo-trunk.ofbiz.apache.org/ecommerce/control/main
2) User should not be logged in
3) Click on any product
4) Click on Be The First To Review This Product! link
5) FTL error for the null check is occurring

Thanks: Minal Phalak for the patch and Suraj for review
------------------------------------------------------------------------

Modified:
    ofbiz/ofbiz-plugins/branches/release18.12/   (props changed)
    ofbiz/ofbiz-plugins/branches/release18.12/ecommerce/template/catalog/ProductReview.ftl

Propchange: ofbiz/ofbiz-plugins/branches/release18.12/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Sun Sep 29 11:00:35 2019
@@ -10,4 +10,4 @@
 /ofbiz/branches/json-integration-refactoring/plugins:1634077-1635900
 /ofbiz/branches/multitenant20100310/plugins:921280-927264
 /ofbiz/branches/release13.07/plugins:1547657
-/ofbiz/ofbiz-plugins/trunk:1851002,1851009,1851068,1851135,1851139-1851140,1851185,1851316,1851885,1852988,1853904,1854684,1855082,1855084,1856212,1856802,1856917,1857120,1857173,1858141,1858244,1858265,1858285,1858289,1858312,1859012,1859735,1859893,1859906,1860648,1860801,1861824,1861904,1861986,1862466,1865347,1865398,1865828,1867712
+/ofbiz/ofbiz-plugins/trunk:1851002,1851009,1851068,1851135,1851139-1851140,1851185,1851316,1851885,1852988,1853904,1854684,1855082,1855084,1856212,1856802,1856917,1857120,1857173,1858141,1858244,1858265,1858285,1858289,1858312,1859012,1859735,1859893,1859906,1860648,1860801,1861824,1861904,1861986,1862466,1865347,1865398,1865828,1867712,1867717

Modified: ofbiz/ofbiz-plugins/branches/release18.12/ecommerce/template/catalog/ProductReview.ftl
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/branches/release18.12/ecommerce/template/catalog/ProductReview.ftl?rev=1867720&r1=1867719&r2=1867720&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/branches/release18.12/ecommerce/template/catalog/ProductReview.ftl (original)
+++ ofbiz/ofbiz-plugins/branches/release18.12/ecommerce/template/catalog/ProductReview.ftl Sun Sep 29 11:00:35 2019
@@ -20,10 +20,10 @@ under the License.
 <#if requestParameters.product_id??>
   <form id="reviewProduct" method="post" action="<@ofbizUrl>createProductReview</@ofbizUrl>">
     <fieldset class="inline">
-      <input type="hidden" name="productStoreId" value="${productStore.productStoreId}" />
+      <input type="hidden" name="productStoreId" value="${(productStore.productStoreId)!}" />
       <input type="hidden" name="productId" value="${requestParameters.product_id}" />
       <input type="hidden" name="product_id" value="${requestParameters.product_id}" />
-      <input type="hidden" name="category_id" value="${requestParameters.category_id}" />
+      <input type="hidden" name="category_id" value="${(requestParameters.category_id)!}" />
       <div>
         <label for="one">${uiLabelMap.EcommerceRating}:</label>
         <div class="form-check form-check-inline">