svn commit: r1868549 - in /ofbiz/ofbiz-plugins/branches/release17.12: ./ example/widget/example/ExampleForms.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1868549 - in /ofbiz/ofbiz-plugins/branches/release17.12: ./ example/widget/example/ExampleForms.xml

jleroux@apache.org
Author: jleroux
Date: Thu Oct 17 12:20:29 2019
New Revision: 1868549

URL: http://svn.apache.org/viewvc?rev=1868549&view=rev
Log:
"Applied fix from plugins for revision: 1868545"
------------------------------------------------------------------------
r1868545 | jleroux | 2019-10-17 14:19:33 +0200 (jeu. 17 oct. 2019) | 16 lignes

Fixed: EditExample always update status, because current Status not shown
(OFBIZ-11230)

In the EditExample Form, the drop-down is populates with the Valid change status
only. So current status is not in the list and the status print in the drop-down
is the next authorized. I want to modify exampleName or exampleType, I go to
editExample and change what I want and validate. The problem is status is also
changed!

There are 12 other same or similar cases. For the first of them (in FinAccount)
there is the same bug: when I change FinAccount Name, status change too. If I
add current="first-in-list" in the tag drop-down it works

jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong fix
 
Thanks: Oliver for the analysis and the fix
------------------------------------------------------------------------

Modified:
    ofbiz/ofbiz-plugins/branches/release17.12/   (props changed)
    ofbiz/ofbiz-plugins/branches/release17.12/example/widget/example/ExampleForms.xml

Propchange: ofbiz/ofbiz-plugins/branches/release17.12/
------------------------------------------------------------------------------
  Merged /ofbiz/ofbiz-plugins/trunk:r1868545

Modified: ofbiz/ofbiz-plugins/branches/release17.12/example/widget/example/ExampleForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/branches/release17.12/example/widget/example/ExampleForms.xml?rev=1868549&r1=1868548&r2=1868549&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/branches/release17.12/example/widget/example/ExampleForms.xml (original)
+++ ofbiz/ofbiz-plugins/branches/release17.12/example/widget/example/ExampleForms.xml Thu Oct 17 12:20:29 2019
@@ -198,7 +198,8 @@ under the License.
             </drop-down>
         </field>
         <field name="statusId" use-when="example!=null" title="${uiLabelMap.CommonStatus}" required-field="true">
-            <drop-down allow-empty="false" current-description="${currentStatus.description}">
+            <drop-down allow-empty="false" current="first-in-list" current-description="${currentStatus.description}">
+                <option key="${currentStatus.statusId}" description="${currentStatus.description}"/>
                 <entity-options entity-name="StatusValidChangeToDetail" key-field-name="statusIdTo" description="${transitionName} (${description})">
                     <entity-constraint name="statusId" env-name="example.statusId"/>
                 </entity-options>