svn commit: r434103 - /incubator/ofbiz/trunk/framework/webtools/webapp/webtools/entity/ViewGeneric.jsp

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r434103 - /incubator/ofbiz/trunk/framework/webtools/webapp/webtools/entity/ViewGeneric.jsp

jacopoc
Author: jacopoc
Date: Wed Aug 23 10:55:34 2006
New Revision: 434103

URL: http://svn.apache.org/viewvc?rev=434103&view=rev
Log:
This is the second part of the layout improvements to the entity data maintenance screens.
In this commit I've modified the screen to edit/create/update one row.
I've kept this mod in a separate commit because I'm not sure you'll like it because of the first item below:

* I've changed the list of tabs showing all the relations of the current entity to a drop down box
* applied the same css styles of the widget screens
* a few small bug fixes

If your feedback will be negative I'll revert this commit.

Modified:
    incubator/ofbiz/trunk/framework/webtools/webapp/webtools/entity/ViewGeneric.jsp

Modified: incubator/ofbiz/trunk/framework/webtools/webapp/webtools/entity/ViewGeneric.jsp
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/framework/webtools/webapp/webtools/entity/ViewGeneric.jsp?rev=434103&r1=434102&r2=434103&view=diff
==============================================================================
--- incubator/ofbiz/trunk/framework/webtools/webapp/webtools/entity/ViewGeneric.jsp (original)
+++ incubator/ofbiz/trunk/framework/webtools/webapp/webtools/entity/ViewGeneric.jsp Wed Aug 23 10:55:34 2006
@@ -73,59 +73,64 @@
 var numTabs=<%=entity.getRelationsSize()+2%>;
 function ShowTab(lname) {
   for(inc=1; inc <= numTabs; inc++) {
-    document.getElementById('tab' + inc).className = (lname == 'tab' + inc) ? 'ontab' : 'offtab';
-    document.getElementById('lnk' + inc).className = (lname == 'tab' + inc) ? 'onlnk' : 'offlnk';
     document.getElementById('area' + inc).className = (lname == 'tab' + inc) ? 'topcontainer' : 'topcontainerhidden';
   }
 }
 </script>
-<div style='color: white; background-color: black; padding:3;'>
-  <b>View Entity: <%=entityName%> with PK: <%=findByPK.toString()%></b>
+<div class="head1">View Value</div>
+<div class="head2">For Entity: <%=entityName%></div>
+<div class="head2">With PK: <%=findByPK.toString()%></div>
+<br/>
+<div>
+<a href='<ofbiz:url>/FindGeneric?entityName=<%=entityName%></ofbiz:url>' class="buttontext">Back To Find Screen</a>
 </div>
-
-<a href='<ofbiz:url>/FindGeneric?entityName=<%=entityName%></ofbiz:url>' class="buttontext">[Find <%=entityName%>]</a>
+<div>
 <%if (hasCreatePermission) {%>
-  <a href='<ofbiz:url>/ViewGeneric?entityName=<%=entityName%></ofbiz:url>' class="buttontext">[Create New <%=entityName%>]</a>
+<a href='<ofbiz:url>/ViewGeneric?entityName=<%=entityName%></ofbiz:url>' class="buttontext">Create New</a>
+<a href='javascript:ShowTab("tab2")' class="buttontext">Edit</a>
 <%}%>
+
 <%if (value != null) {%>
   <%if (hasDeletePermission) {%>
-    <a href='<ofbiz:url>/UpdateGeneric?UPDATE_MODE=DELETE&<%=curFindString%></ofbiz:url>' class="buttontext">[Delete this <%=entityName%>]</a>
+    <a href='<ofbiz:url>/UpdateGeneric?UPDATE_MODE=DELETE&<%=curFindString%></ofbiz:url>' class="buttontext">Delete This Value</a>
   <%}%>
 <%}%>
+</div>
 <br/>
-<br/>
-<table cellpadding='0' cellspacing='0'><tr>  
-  <td id='tab1' class='ontab'>
-    <a href='javascript:ShowTab("tab1")' id=lnk1 class=onlnk>View <%=entityName%></a>
-  </td>
-  <%if (hasUpdatePermission || hasCreatePermission) {%>
-  <td id='tab2' class='offtab'>
-    <a href='javascript:ShowTab("tab2")' id=lnk2 class=offlnk>Edit <%=entityName%></a>
-  </td>
-  <%}%>
-</tr>
 <%if (value != null) {%>
+<form name="relationForm">
+<table cellpadding='0' cellspacing='0'><tr>
+<tr>
+<td class="tableheadtext">View:</td>
+</tr>
 <tr>
+<td>
+<select name="relations" onchange='javascript:ShowTab(this.options[this.selectedIndex].value)' class="selectBox">
+    <option value="tab1"><b><%=entityName%></b></option>
   <%for(int tabIndex = 0; tabIndex < entity.getRelationsSize(); tabIndex++){%>
     <%ModelRelation relation = entity.getRelation(tabIndex);%>
     <%ModelEntity relatedEntity = reader.getModelEntity(relation.getRelEntityName());%>
     <%if (hasAllView || security.hasEntityPermission(relatedEntity.getPlainTableName(), "_VIEW", session)) {%>
-      <td id='tab<%=tabIndex+3%>' class='offtab'>
-        <a href='javascript:ShowTab("tab<%=tabIndex+3%>")' id='lnk<%=tabIndex+3%>' class='offlnk' style='FONT-SIZE: xx-small;'>
-          <%=relation.getTitle()%><%=relation.getRelEntityName()%></a><SPAN class='tabletext' style='FONT-SIZE: xx-small;'>(<%=relation.getType()%>)</SPAN>
-      </td>
+    <option value="tab<%=tabIndex+3%>"><%=relation.getTitle()%><%=relation.getRelEntityName()%> (<%=relation.getType()%>)</option>
     <%}%>
-    <%if ((tabIndex+1)%4 == 0) {%></tr><tr><%}%>
   <%}%>
+</select>
+</td>
 </tr>
-<%}%>
 </table>
+</form>
+<%}%>
+
 <div class='topouter'>
   <DIV id='area1' class='topcontainer' width="1%">
 
 <table border="0" cellspacing="2" cellpadding="2">
 <%if (value == null) {%>
-<tr class="<%=rowClass1%>"><td><h3>Specified <%=entityName%> was not found.</h3></td></tr>
+<tr class="<%=rowClass1%>">
+  <td>
+    <h3>Specified <%=entityName%> was not found.</h3>
+  </td>
+</tr>
 <%} else {%>
     <%for (int fnum = 0; fnum < entity.getFieldsSize(); fnum++) {%>
       <%ModelField field = entity.getField(fnum);%>
@@ -167,7 +172,7 @@
   <DIV id='area2' class='topcontainerhidden' width="1%">
 <%boolean showFields = true;%>
 <%if(value == null && (findByPK.getAllFields().size() > 0)){%>
-    <%=entity.getEntityName()%> with primary key <%=findByPK.toString()%> not found.<br/>
+    <div class="tabletext"><%=entity.getEntityName()%> with primary key <%=findByPK.toString()%> not found.</div>
 <%}%>
 <%
   String lastUpdateMode = request.getParameter("UPDATE_MODE");
@@ -182,7 +187,7 @@
 
 <%if (value == null) {%>
   <%if (hasCreatePermission) {%>
-    You may create a <%=entityName%> by entering the values you want, and clicking Update.
+    <div class="tabletext">You may create a <%=entityName%> by entering the values you want, and clicking Update.</div>
     <input type="hidden" name="UPDATE_MODE" value="CREATE"/>
     <%for (int fnum = 0; fnum < entity.getPksSize();fnum++) {%>
       <%ModelField field = entity.getPk(fnum);%>
@@ -575,9 +580,10 @@
 </div>
 <%if ((hasUpdatePermission || hasCreatePermission) && !useValue) {%>
   <script language="JavaScript" type="text/javascript">  
-    ShowViewTab("edit");
+    ShowTab("tab2");
   </script>
 <%}%>
+
 <br/>
 <%} else {%>
   <h3>You do not have permission to view this page (<%=entity.getPlainTableName()%>_ADMIN, or <%=entity.getPlainTableName()%>_VIEW needed).</h3>