svn commit: r479931 - /incubator/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r479931 - /incubator/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java

jacopoc
Author: jacopoc
Date: Mon Nov 27 22:51:15 2006
New Revision: 479931

URL: http://svn.apache.org/viewvc?view=rev&rev=479931
Log:
Two of the getDescription(...) methods in the ModelFormField class, were returning the string " " if no description was found.
I've replaced it with an empty "" string (as suggested by David Jones) because this class should not contain html specific code and in fact this was causing problems in forms rendered as PDF.

Modified:
    incubator/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java

Modified: incubator/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java?view=diff&rev=479931&r1=479930&r2=479931
==============================================================================
--- incubator/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java (original)
+++ incubator/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java Mon Nov 27 22:51:15 2006
@@ -1720,7 +1720,7 @@
                 retVal = modelFormField.getEntry(context);
             }
             if (retVal == null || retVal.length() == 0) {
-                retVal = " ";
+                retVal = "";
             } else if ("currency".equals(type)) {
                 Locale locale = (Locale) context.get("locale");
                 if (locale == null) locale = Locale.getDefault();
@@ -1834,7 +1834,7 @@
                 retVal = fieldValue;
             }
             if (retVal == null || retVal.length() == 0) {
-                retVal = " ";
+                retVal = "";
             }
             return retVal;
         }