svn commit: r484976 - in /incubator/ofbiz/trunk: applications/accounting/src/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/ applications/accounting/src/org/ofbiz/accounting/thirdparty/gosoftwa...

Author: jleroux
Date: Sat Dec  9 04:19:28 2006
New Revision: 484976

URL: http://svn.apache.org/viewvc?view=rev&rev=484976
Log:
A patch from Stefan Huehner "Code-Cleanup: new Boolean(true) -> Boolean.TRUE" (https://issues.apache.org/jira/browse/OFBIZ-530).

Modified:
    incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/GiftCertificateServices.java
    incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java
    incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/gosoftware/PcChargeServices.java
    incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/gosoftware/RitaServices.java
    incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/valuelink/ValueLinkServices.java
    incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/ContentManagementServices.java
    incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/ContentManagementWorker.java
    incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
    incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentWorker.java
    incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/CheckPermissionTransform.java
    incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/EditRenderSubContentCacheTransform.java
    incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/LimitedSubContentCacheTransform.java
    incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/LoopSubContentCacheTransform.java
    incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderContentAsText.java
    incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderSubContentAsText.java
    incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderSubContentCacheTransform.java
    incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/TraverseSubContentCacheTransform.java
    incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/WrapSubContentCacheTransform.java
    incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMServices.java
    incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
    incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/mrp/MrpServices.java
    incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
    incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
    incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java
    incubator/ofbiz/trunk/applications/product/src/org/ofbiz/product/price/PriceServices.java
    incubator/ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java
    incubator/ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortWorker.java
    incubator/ofbiz/trunk/framework/base/src/base/org/ofbiz/base/util/ObjectType.java
    incubator/ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonServices.java
    incubator/ofbiz/trunk/framework/entityext/src/org/ofbiz/entityext/data/EntityDataServices.java
    incubator/ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceDispatcher.java
    incubator/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ControlServlet.java
    incubator/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
    incubator/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/view/DataVisionViewHandler.java
    incubator/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/view/JspViewHandler.java
    incubator/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/view/RegionViewHandler.java
    incubator/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlTreeRenderer.java
    incubator/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/MenuWrapTransform.java
    incubator/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenu.java
    incubator/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
    incubator/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/tree/ModelTree.java

Modified: incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/GiftCertificateServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/GiftCertificateServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/GiftCertificateServices.java (original)
+++ incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/GiftCertificateServices.java Sat Dec  9 04:19:28 2006
@@ -525,7 +525,7 @@
             Map result = ServiceUtil.returnSuccess();
             result.put("releaseRefNum", authTransaction.getString("referenceNum"));
             result.put("releaseAmount", authTransaction.getDouble("amount"));
-            result.put("releaseResult", new Boolean(true));
+            result.put("releaseResult", Boolean.TRUE);
 
             // if there's an error, don't release
             if (ServiceUtil.isError(serviceResults)) {

Modified: incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java (original)
+++ incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java Sat Dec  9 04:19:28 2006
@@ -224,9 +224,9 @@
             String resp = ar.getResponseCode();
 
             if (resp.equals(AuthorizeResponse.APPROVED)) {
-                result.put("authResult", new Boolean(true));
+                result.put("authResult", Boolean.TRUE);
             } else {
-                result.put("authResult", new Boolean(false));
+                result.put("authResult", Boolean.FALSE);
                 Debug.logInfo("responseCode:   " + ar.getResponseField(AuthorizeResponse.RESPONSE_CODE),module);
                 Debug.logInfo("responseReason: " + ar.getResponseField(AuthorizeResponse.RESPONSE_REASON_CODE),module);
                 Debug.logInfo("reasonText:     " + ar.getResponseField(AuthorizeResponse.RESPONSE_REASON_TEXT),module);

Modified: incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/gosoftware/PcChargeServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/gosoftware/PcChargeServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/gosoftware/PcChargeServices.java (original)
+++ incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/gosoftware/PcChargeServices.java Sat Dec  9 04:19:28 2006
@@ -82,17 +82,17 @@
             String resultCode = out.get(PcChargeApi.RESULT);
             boolean passed = false;
             if ("CAPTURED".equals(resultCode)) {
-                result.put("authResult", new Boolean(true));
-                result.put("captureResult", new Boolean(true));
+                result.put("authResult", Boolean.TRUE);
+                result.put("captureResult", Boolean.TRUE);
                 passed = true;
             } else if ("APPROVED".equals(resultCode)) {
                 result.put("authCode", out.get(PcChargeApi.AUTH_CODE));
-                result.put("authResult", new Boolean(true));
+                result.put("authResult", Boolean.TRUE);
                 passed = true;
             } else if ("PROCESSED".equals(resultCode)) {
-                result.put("authResult", new Boolean(true));
+                result.put("authResult", Boolean.TRUE);
             } else {
-                result.put("authResult", new Boolean(false));
+                result.put("authResult", Boolean.FALSE);
             }
 
             result.put("authRefNum", out.get(PcChargeApi.TROUTD) != null ? out.get(PcChargeApi.TROUTD) : "");
@@ -163,9 +163,9 @@
             Map result = ServiceUtil.returnSuccess();
             String resultCode = out.get(PcChargeApi.RESULT);
             if ("CAPTURED".equals(resultCode)) {
-                result.put("captureResult", new Boolean(true));
+                result.put("captureResult", Boolean.TRUE);
             } else {
-                result.put("captureResult", new Boolean(false));
+                result.put("captureResult", Boolean.FALSE);
             }
             result.put("captureAmount", context.get("captureAmount"));
             result.put("captureRefNum", out.get(PcChargeApi.TROUTD) != null ? out.get(PcChargeApi.TROUTD) : "");
@@ -224,9 +224,9 @@
             Map result = ServiceUtil.returnSuccess();
             String resultCode = out.get(PcChargeApi.RESULT);
             if ("VOIDED".equals(resultCode)) {
-                result.put("releaseResult", new Boolean(true));
+                result.put("releaseResult", Boolean.TRUE);
             } else {
-                result.put("releaseResult", new Boolean(false));
+                result.put("releaseResult", Boolean.FALSE);
             }
             result.put("releaseAmount", context.get("releaseAmount"));
             result.put("releaseRefNum", out.get(PcChargeApi.TROUTD) != null ? out.get(PcChargeApi.TROUTD) : "");
@@ -280,9 +280,9 @@
             Map result = ServiceUtil.returnSuccess();
             String resultCode = out.get(PcChargeApi.RESULT);
             if ("CAPTURED".equals(resultCode)) {
-                result.put("refundResult", new Boolean(true));
+                result.put("refundResult", Boolean.TRUE);
             } else {
-                result.put("refundResult", new Boolean(false));
+                result.put("refundResult", Boolean.FALSE);
             }
             result.put("refundAmount", context.get("releaseAmount"));
             result.put("refundRefNum", out.get(PcChargeApi.TROUTD) != null ? out.get(PcChargeApi.TROUTD) : "");

Modified: incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/gosoftware/RitaServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/gosoftware/RitaServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/gosoftware/RitaServices.java (original)
+++ incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/gosoftware/RitaServices.java Sat Dec  9 04:19:28 2006
@@ -88,17 +88,17 @@
             String resultCode = out.get(RitaApi.RESULT);
             boolean passed = false;
             if ("CAPTURED".equals(resultCode)) {
-                result.put("authResult", new Boolean(true));
-                result.put("captureResult", new Boolean(true));
+                result.put("authResult", Boolean.TRUE);
+                result.put("captureResult", Boolean.TRUE);
                 passed = true;
             } else if ("APPROVED".equals(resultCode)) {
                 result.put("authCode", out.get(RitaApi.AUTH_CODE));
-                result.put("authResult", new Boolean(true));
+                result.put("authResult", Boolean.TRUE);
                 passed = true;
             } else if ("PROCESSED".equals(resultCode)) {
-                result.put("authResult", new Boolean(true));
+                result.put("authResult", Boolean.TRUE);
             } else {
-                result.put("authResult", new Boolean(false));
+                result.put("authResult", Boolean.FALSE);
             }
 
             result.put("authRefNum", out.get(RitaApi.INTRN_SEQ_NUM) != null ? out.get(RitaApi.INTRN_SEQ_NUM) : "");
@@ -168,9 +168,9 @@
             Map result = ServiceUtil.returnSuccess();
             String resultCode = out.get(RitaApi.RESULT);
             if ("CAPTURED".equals(resultCode)) {
-                result.put("captureResult", new Boolean(true));
+                result.put("captureResult", Boolean.TRUE);
             } else {
-                result.put("captureResult", new Boolean(false));
+                result.put("captureResult", Boolean.FALSE);
             }
             result.put("captureAmount", context.get("captureAmount"));
             result.put("captureRefNum", out.get(RitaApi.INTRN_SEQ_NUM) != null ? out.get(RitaApi.INTRN_SEQ_NUM) : "");
@@ -238,9 +238,9 @@
             Map result = ServiceUtil.returnSuccess();
             String resultCode = out.get(RitaApi.RESULT);
             if ("VOIDED".equals(resultCode)) {
-                result.put(isRefund ? "refundResult" : "releaseResult", new Boolean(true));
+                result.put(isRefund ? "refundResult" : "releaseResult", Boolean.TRUE);
             } else {
-                result.put(isRefund ? "refundResult" : "releaseResult", new Boolean(false));
+                result.put(isRefund ? "refundResult" : "releaseResult", Boolean.FALSE);
             }
             result.put(isRefund ? "refundAmount" : "releaseAmount", context.get(isRefund ? "refundAmount" : "releaseAmount"));
             result.put(isRefund ? "refundRefNum" : "releaseRefNum", out.get(RitaApi.INTRN_SEQ_NUM) != null ? out.get(RitaApi.INTRN_SEQ_NUM) : "");
@@ -302,9 +302,9 @@
             Map result = ServiceUtil.returnSuccess();
             String resultCode = out.get(RitaApi.RESULT);
             if ("CAPTURED".equals(resultCode)) {
-                result.put("refundResult", new Boolean(true));
+                result.put("refundResult", Boolean.TRUE);
             } else {
-                result.put("refundResult", new Boolean(false));
+                result.put("refundResult", Boolean.FALSE);
             }
             result.put("refundAmount", context.get("refundAmount"));
             result.put("refundRefNum", out.get(RitaApi.INTRN_SEQ_NUM) != null ? out.get(RitaApi.INTRN_SEQ_NUM) : "");

Modified: incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/valuelink/ValueLinkServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/valuelink/ValueLinkServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/valuelink/ValueLinkServices.java (original)
+++ incubator/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/valuelink/ValueLinkServices.java Sat Dec  9 04:19:28 2006
@@ -58,7 +58,7 @@
         ValueLinkApi vl = ValueLinkApi.getInstance(delegator, props);
         vl.reload();
 
-        Boolean kekOnly = context.get("kekOnly") != null ? (Boolean) context.get("kekOnly") : new Boolean(false);
+        Boolean kekOnly = context.get("kekOnly") != null ? (Boolean) context.get("kekOnly") : Boolean.FALSE;
         String kekTest = (String) context.get("kekTest");
         Debug.log("KEK Only : " + kekOnly.booleanValue(), module);
 
@@ -244,10 +244,10 @@
             String responseCode = (String) response.get("responsecode");
             Map result = ServiceUtil.returnSuccess();
             if (responseCode.equals("00")) {
-                result.put("processResult", new Boolean(true));
+                result.put("processResult", Boolean.TRUE);
                 result.put("pin", vl.decryptPin((String) response.get("pin")));
             } else {
-                result.put("processResult", new Boolean(false));
+                result.put("processResult", Boolean.FALSE);
                 result.put("pin", response.get("PIN"));
             }
             result.put("responseCode", responseCode);
@@ -301,9 +301,9 @@
             Map result = ServiceUtil.returnSuccess("Activation of physical card complete.");
             if (responseCode.equals("00")) {
 
-                result.put("processResult", new Boolean(true));
+                result.put("processResult", Boolean.TRUE);
             } else {
-                result.put("processResult", new Boolean(false));
+                result.put("processResult", Boolean.FALSE);
             }
             result.put("responseCode", responseCode);
             result.put("authCode", response.get("authcode"));
@@ -358,9 +358,9 @@
             String responseCode = (String) response.get("responsecode");
             Map result = ServiceUtil.returnSuccess("PIN disabled.");
             if (responseCode.equals("00")) {
-                result.put("processResult", new Boolean(true));
+                result.put("processResult", Boolean.TRUE);
             } else {
-                result.put("processResult", new Boolean(false));
+                result.put("processResult", Boolean.FALSE);
             }
             result.put("responseCode", responseCode);
             result.put("balance", vl.getAmount((String) response.get("currbal")));
@@ -422,9 +422,9 @@
             String responseCode = (String) response.get("responsecode");
             Map result = ServiceUtil.returnSuccess();
             if (responseCode.equals("00")) {
-                result.put("processResult", new Boolean(true));
+                result.put("processResult", Boolean.TRUE);
             } else {
-                result.put("processResult", new Boolean(false));
+                result.put("processResult", Boolean.FALSE);
             }
             result.put("responseCode", responseCode);
             result.put("authCode", response.get("authcode"));
@@ -489,9 +489,9 @@
             String responseCode = (String) response.get("responsecode");
             Map result = ServiceUtil.returnSuccess();
             if (responseCode.equals("00")) {
-                result.put("processResult", new Boolean(true));
+                result.put("processResult", Boolean.TRUE);
             } else {
-                result.put("processResult", new Boolean(false));
+                result.put("processResult", Boolean.FALSE);
             }
             result.put("responseCode", responseCode);
             result.put("authCode", response.get("authcode"));
@@ -547,9 +547,9 @@
             String responseCode = (String) response.get("responsecode");
             Map result = ServiceUtil.returnSuccess();
             if (responseCode.equals("00")) {
-                result.put("processResult", new Boolean(true));
+                result.put("processResult", Boolean.TRUE);
             } else {
-                result.put("processResult", new Boolean(false));
+                result.put("processResult", Boolean.FALSE);
             }
             result.put("responseCode", responseCode);
             result.put("balance", vl.getAmount((String) response.get("currbal")));
@@ -601,9 +601,9 @@
             String responseCode = (String) response.get("responsecode");
             Map result = ServiceUtil.returnSuccess();
             if (responseCode.equals("00")) {
-                result.put("processResult", new Boolean(true));
+                result.put("processResult", Boolean.TRUE);
             } else {
-                result.put("processResult", new Boolean(false));
+                result.put("processResult", Boolean.FALSE);
             }
             result.put("responseCode", responseCode);
             result.put("balance", vl.getAmount((String) response.get("currbal")));
@@ -666,9 +666,9 @@
             String responseCode = (String) response.get("responsecode");
             Map result = ServiceUtil.returnSuccess();
             if (responseCode.equals("00")) {
-                result.put("processResult", new Boolean(true));
+                result.put("processResult", Boolean.TRUE);
             } else {
-                result.put("processResult", new Boolean(false));
+                result.put("processResult", Boolean.FALSE);
             }
             result.put("responseCode", responseCode);
             result.put("authCode", response.get("authcode"));
@@ -826,7 +826,7 @@
                     if (ServiceUtil.isError(voidResult)) {
                         return voidResult;
                     }
-                    processResult = new Boolean(false);
+                    processResult = Boolean.FALSE;
                     amount = new Double(redeemed);
                     result.put("authMessage", "Gift card did not contain enough funds");
                 }

Modified: incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/ContentManagementServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/ContentManagementServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/ContentManagementServices.java (original)
+++ incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/ContentManagementServices.java Sat Dec  9 04:19:28 2006
@@ -88,7 +88,7 @@
         GenericValue view = null;
 
         try {
-            view = ContentWorker.getSubContentCache( delegator, contentId, mapKey, subContentId, userLogin, assocTypes, fromDate, new Boolean(false), null);
+            view = ContentWorker.getSubContentCache( delegator, contentId, mapKey, subContentId, userLogin, assocTypes, fromDate, Boolean.FALSE, null);
             content = ContentWorker.getContentFromView(view);
         } catch(GenericEntityException e) {
             return ServiceUtil.returnError(e.getMessage());

Modified: incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/ContentManagementWorker.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/ContentManagementWorker.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/ContentManagementWorker.java (original)
+++ incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/ContentManagementWorker.java Sat Dec  9 04:19:28 2006
@@ -639,7 +639,7 @@
             List contentTypes = null;
             String fromDate = null;
             String thruDate = null;
-            Map results =  ContentServicesComplex.getAssocAndContentAndDataResourceCacheMethod(delegator, contentId, null, "To", null, null, assocTypes, contentTypes, new Boolean(true), null);
+            Map results =  ContentServicesComplex.getAssocAndContentAndDataResourceCacheMethod(delegator, contentId, null, "To", null, null, assocTypes, contentTypes, Boolean.TRUE, null);
             List valueList = (List)results.get("entityList");
             if (valueList.size() > 0) {
                 GenericValue value = (GenericValue)valueList.get(0);

Modified: incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java (original)
+++ incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java Sat Dec  9 04:19:28 2006
@@ -712,8 +712,8 @@
         context.put("contentPurposeList", contentPurposeList);
 
         GenericValue pk = delegator.makeValue("ContentAssoc",null);
-        pk.setAllFields(context, false, null, new Boolean(true));
-        pk.setAllFields(context, false, "ca", new Boolean(true));
+        pk.setAllFields(context, false, null, Boolean.TRUE);
+        pk.setAllFields(context, false, "ca", Boolean.TRUE);
         //String contentIdFrom = (String) context.get("contentId");
         //String contentIdTo = (String) context.get("contentIdTo");
         //String contentId = (String) context.get("contentId");

Modified: incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentWorker.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentWorker.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentWorker.java (original)
+++ incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentWorker.java Sat Dec  9 04:19:28 2006
@@ -433,7 +433,7 @@
         List assocTypeList = StringUtil.split(contentAssocTypeId, " ");
         List contentTypeList = StringUtil.split(contentTypeId, " ");
         String contentAssocPredicateId = null;
-        Boolean nullThruDatesOnly = new Boolean(true);
+        Boolean nullThruDatesOnly = Boolean.TRUE;
         Map results = null;
         try {
             results = ContentServicesComplex.getAssocAndContentAndDataResourceCacheMethod(delegator, parentContentId, mapKey, direction, null, null, assocTypeList, contentTypeList, nullThruDatesOnly, contentAssocPredicateId);
@@ -1010,7 +1010,7 @@
         Map results = new HashMap();
         //GenericValue content = null;
         if (subContentDataResourceView == null) {
-            subContentDataResourceView = getSubContentCache(delegator, contentId, mapKey, subContentId, userLogin, null, fromDate, new Boolean(false), null);
+            subContentDataResourceView = getSubContentCache(delegator, contentId, mapKey, subContentId, userLogin, null, fromDate, Boolean.FALSE, null);
         }
 
         results.put("view", subContentDataResourceView);
@@ -1034,7 +1034,7 @@
 
     public static String renderSubContentAsTextCache(GenericDelegator delegator, String contentId,  String mapKey,  GenericValue subContentDataResourceView,
             Map templateRoot, Locale locale, String mimeTypeId, GenericValue userLogin, Timestamp fromDate) throws GeneralException, IOException {
-        Boolean nullThruDatesOnly = new Boolean(false);
+        Boolean nullThruDatesOnly = Boolean.FALSE;
         Writer outWriter = new StringWriter();
         Map map = renderSubContentAsTextCache(delegator, contentId, outWriter, mapKey, subContentDataResourceView, templateRoot, locale, mimeTypeId, userLogin, fromDate, nullThruDatesOnly);
         return outWriter.toString();
@@ -1042,7 +1042,7 @@
 
     public static Map renderSubContentAsTextCache(GenericDelegator delegator, String contentId, Writer out, String mapKey,  GenericValue subContentDataResourceView,
             Map templateRoot, Locale locale, String mimeTypeId, GenericValue userLogin, Timestamp fromDate) throws GeneralException, IOException {
-        Boolean nullThruDatesOnly = new Boolean(false);
+        Boolean nullThruDatesOnly = Boolean.FALSE;
         return renderSubContentAsTextCache(delegator, contentId, out, mapKey, subContentDataResourceView,
             templateRoot, locale, mimeTypeId, userLogin, fromDate, nullThruDatesOnly);
     }
@@ -1358,7 +1358,7 @@
         trailNode.put("isFollow", new Boolean(isFollow));
         boolean isReturnAfter = checkReturnWhen(context, (String)whenMap.get("returnAfterPickWhen"));
         trailNode.put("isReturnAfter", new Boolean(isReturnAfter));
-        trailNode.put("checked", new Boolean(true));
+        trailNode.put("checked", Boolean.TRUE);
 
     }
 
@@ -1489,10 +1489,10 @@
         String contentId = (String)thisContent.get("contentId");
         thisNode.put("contentId", contentId);
         thisNode.put("contentTypeId", thisContent.get("contentTypeId"));
-        thisNode.put("isReturnBeforePick", new Boolean(false));
-        thisNode.put("isReturnAfterPick", new Boolean(false));
-        thisNode.put("isPick", new Boolean(true));
-        thisNode.put("isFollow", new Boolean(true));
+        thisNode.put("isReturnBeforePick", Boolean.FALSE);
+        thisNode.put("isReturnAfterPick", Boolean.FALSE);
+        thisNode.put("isPick", Boolean.TRUE);
+        thisNode.put("isFollow", Boolean.TRUE);
         try {
             thisNode.put("contentAssocTypeId", thisContent.get("caContentAssocTypeId"));
             thisNode.put("mapKey", thisContent.get("caMapKey"));

Modified: incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/CheckPermissionTransform.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/CheckPermissionTransform.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/CheckPermissionTransform.java (original)
+++ incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/CheckPermissionTransform.java Sat Dec  9 04:19:28 2006
@@ -104,7 +104,7 @@
                 GenericValue currentContent = null;
         String contentAssocPredicateId = (String)templateCtx.get("contentAssocPredicateId");
                 String strNullThruDatesOnly = (String)templateCtx.get("nullThruDatesOnly");
-                Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? new Boolean(true) :new Boolean(false);
+                Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? Boolean.TRUE : Boolean.FALSE;
                 GenericValue val = null;
                 try {
                     val = ContentWorker.getCurrentContent(delegator, trail, userLogin, templateCtx, nullThruDatesOnly, contentAssocPredicateId);

Modified: incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/EditRenderSubContentCacheTransform.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/EditRenderSubContentCacheTransform.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/EditRenderSubContentCacheTransform.java (original)
+++ incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/EditRenderSubContentCacheTransform.java Sat Dec  9 04:19:28 2006
@@ -75,7 +75,7 @@
         List trail = (List)templateCtx.get("globalNodeTrail");
         String contentAssocPredicateId = (String)templateCtx.get("contentAssocPredicateId");
         String strNullThruDatesOnly = (String)templateCtx.get("nullThruDatesOnly");
-        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? new Boolean(true) :new Boolean(false);
+        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? Boolean.TRUE :Boolean.FALSE;
         GenericValue val = null;
         try {
             val = ContentWorker.getCurrentContent(delegator, trail, userLogin, templateCtx, nullThruDatesOnly, contentAssocPredicateId);

Modified: incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/LimitedSubContentCacheTransform.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/LimitedSubContentCacheTransform.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/LimitedSubContentCacheTransform.java (original)
+++ incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/LimitedSubContentCacheTransform.java Sat Dec  9 04:19:28 2006
@@ -125,7 +125,7 @@
         List globalNodeTrail = (List) templateRoot.get("globalNodeTrail");
         String strNullThruDatesOnly = (String) templateRoot.get("nullThruDatesOnly");
         String orderBy = (String) templateRoot.get("orderBy");
-        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? new Boolean(true) : new Boolean(false);
+        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? Boolean.TRUE : Boolean.FALSE;
         String contentId = (String) templateRoot.get("subContentId");
 
         templateRoot.put("contentId", null);
@@ -137,7 +137,7 @@
         //if (Debug.infoOn()) Debug.logInfo("in LimitedSubContentCache(0), assocTypes ." + assocTypes, module);
         String contentAssocPredicateId = (String) templateRoot.get("contentAssocPredicateId");
         try {
-            results = ContentServicesComplex.getAssocAndContentAndDataResourceCacheMethod(delegator, contentId, null, "From", fromDate, null, assocTypes, null, new Boolean(true), contentAssocPredicateId, orderBy);
+            results = ContentServicesComplex.getAssocAndContentAndDataResourceCacheMethod(delegator, contentId, null, "From", fromDate, null, assocTypes, null, Boolean.TRUE, contentAssocPredicateId, orderBy);
         } catch (MiniLangException e2) {
             throw new RuntimeException(e2.getMessage());
         } catch (GenericEntityException e) {

Modified: incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/LoopSubContentCacheTransform.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/LoopSubContentCacheTransform.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/LoopSubContentCacheTransform.java (original)
+++ incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/LoopSubContentCacheTransform.java Sat Dec  9 04:19:28 2006
@@ -239,7 +239,7 @@
         //if (Debug.infoOn()) Debug.logInfo("in LoopSubContentCache(0), nodeTrailCsv ." + FreeMarkerWorker.nodeTrailToCsv(globalNodeTrail), module);
         String strNullThruDatesOnly = (String) templateRoot.get("nullThruDatesOnly");
         String orderBy = (String) templateRoot.get("orderBy");
-        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? new Boolean(true) : new Boolean(false);
+        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? Boolean.TRUE : Boolean.FALSE;
         GenericValue val = null;
         try {
             val = ContentWorker.getCurrentContent(delegator, globalNodeTrail, userLogin, templateRoot, nullThruDatesOnly, null);
@@ -262,7 +262,7 @@
             //if (Debug.infoOn()) Debug.logInfo("in LoopSubContentCache(0), assocTypes ." + assocTypes, module);
             String contentAssocPredicateId = (String) templateRoot.get("contentAssocPredicateId");
             try {
-                results = ContentServicesComplex.getAssocAndContentAndDataResourceCacheMethod(delegator, contentId, thisMapKey, "From", fromDate, null, assocTypes, null, new Boolean(true), contentAssocPredicateId, orderBy);
+                results = ContentServicesComplex.getAssocAndContentAndDataResourceCacheMethod(delegator, contentId, thisMapKey, "From", fromDate, null, assocTypes, null, Boolean.TRUE, contentAssocPredicateId, orderBy);
             } catch (MiniLangException e2) {
                 throw new RuntimeException(e2.getMessage());
             } catch (GenericEntityException e) {

Modified: incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderContentAsText.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderContentAsText.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderContentAsText.java (original)
+++ incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderContentAsText.java Sat Dec  9 04:19:28 2006
@@ -71,7 +71,7 @@
         //if (Debug.infoOn()) Debug.logInfo("in Render(0), globalNodeTrail ." + trail , module);
         String contentAssocPredicateId = (String)templateRoot.get( "contentAssocPredicateId");
         String strNullThruDatesOnly = (String)templateRoot.get( "nullThruDatesOnly");
-        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? new Boolean(true) :new Boolean(false);
+        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? Boolean.TRUE :Boolean.FALSE;
         final String thisContentId =  (String)templateRoot.get("contentId");
         final String xmlEscape =  (String)templateRoot.get("xmlEscape");
         final boolean directAssocMode = UtilValidate.isNotEmpty(thisContentId) ? true : false;

Modified: incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderSubContentAsText.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderSubContentAsText.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderSubContentAsText.java (original)
+++ incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderSubContentAsText.java Sat Dec  9 04:19:28 2006
@@ -70,7 +70,7 @@
         //if (Debug.infoOn()) Debug.logInfo("in Render(0), globalNodeTrail ." + trail , module);
         String contentAssocPredicateId = (String)templateRoot.get( "contentAssocPredicateId");
         String strNullThruDatesOnly = (String)templateRoot.get( "nullThruDatesOnly");
-        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? new Boolean(true) :new Boolean(false);
+        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? Boolean.TRUE :Boolean.FALSE;
         final String thisContentId =  (String)templateRoot.get("contentId");
         final String thisMapKey =  (String)templateRoot.get("mapKey");
         final String xmlEscape =  (String)templateRoot.get("xmlEscape");

Modified: incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderSubContentCacheTransform.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderSubContentCacheTransform.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderSubContentCacheTransform.java (original)
+++ incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/RenderSubContentCacheTransform.java Sat Dec  9 04:19:28 2006
@@ -72,7 +72,7 @@
         //if (Debug.infoOn()) Debug.logInfo("in Render(0), globalNodeTrail ." + trail , module);
         String contentAssocPredicateId = (String)templateRoot.get( "contentAssocPredicateId");
         String strNullThruDatesOnly = (String)templateRoot.get( "nullThruDatesOnly");
-        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? new Boolean(true) :new Boolean(false);
+        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? Boolean.TRUE :Boolean.FALSE;
         String thisSubContentId =  (String)templateRoot.get("subContentId");
         //if (Debug.infoOn()) Debug.logInfo("in Render(0), thisSubContentId ." + thisSubContentId , module);
         final boolean directAssocMode = UtilValidate.isNotEmpty(thisSubContentId) ? true : false;

Modified: incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/TraverseSubContentCacheTransform.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/TraverseSubContentCacheTransform.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/TraverseSubContentCacheTransform.java (original)
+++ incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/TraverseSubContentCacheTransform.java Sat Dec  9 04:19:28 2006
@@ -87,7 +87,7 @@
         //if (Debug.infoOn()) Debug.logInfo("in Traverse(0), csvTrail:"+csvTrail,module);
         String strNullThruDatesOnly = (String)templateRoot.get("nullThruDatesOnly");
         String contentAssocPredicateId = (String)templateRoot.get("contentAssocPredicateId");
-        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? new Boolean(true) :new Boolean(false);
+        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? Boolean.TRUE :Boolean.FALSE;
         GenericValue val = null;
         try {
             // getCurrentContent puts the "current" node on the end of globalNodeTrail.

Modified: incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/WrapSubContentCacheTransform.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/WrapSubContentCacheTransform.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/WrapSubContentCacheTransform.java (original)
+++ incubator/ofbiz/trunk/applications/content/src/org/ofbiz/content/webapp/ftl/WrapSubContentCacheTransform.java Sat Dec  9 04:19:28 2006
@@ -87,7 +87,7 @@
                 //if (Debug.infoOn()) Debug.logInfo("in WrapSubContent, trail(0):" + trail, "");
         String contentAssocPredicateId = (String)templateCtx.get("contentAssocPredicateId");
         String strNullThruDatesOnly = (String)templateCtx.get("nullThruDatesOnly");
-        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? new Boolean(true) :new Boolean(false);
+        Boolean nullThruDatesOnly = (strNullThruDatesOnly != null && strNullThruDatesOnly.equalsIgnoreCase("true")) ? Boolean.TRUE :Boolean.FALSE;
         GenericValue val = null;
         try {
             val = ContentWorker.getCurrentContent(delegator, trail, userLogin, templateCtx, nullThruDatesOnly, contentAssocPredicateId);

Modified: incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMServices.java (original)
+++ incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMServices.java Sat Dec  9 04:19:28 2006
@@ -124,11 +124,11 @@
         String productId = (String) context.get("productIdTo");
         Boolean alsoComponents = (Boolean) context.get("alsoComponents");
         if (alsoComponents == null) {
-            alsoComponents = new Boolean(true);
+            alsoComponents = Boolean.TRUE;
         }
         Boolean alsoVariants = (Boolean) context.get("alsoVariants");
         if (alsoVariants == null) {
-            alsoVariants = new Boolean(true);
+            alsoVariants = Boolean.TRUE;
         }
 
         Integer llc = null;
@@ -362,7 +362,7 @@
             fromDate = new Date();
         }
         if (excludeWIPs == null) {
-            excludeWIPs = new Boolean(true);
+            excludeWIPs = Boolean.TRUE;
         }
         
         //

Modified: incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java (original)
+++ incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java Sat Dec  9 04:19:28 2006
@@ -624,7 +624,7 @@
         String statusId = (String) context.get("statusId");
         Boolean issueAllComponents = (Boolean) context.get("issueAllComponents");
         if (issueAllComponents == null) {
-            issueAllComponents = new Boolean(false);
+            issueAllComponents = Boolean.FALSE;
         }
         
         ProductionRun productionRun = new ProductionRun(productionRunId, delegator, dispatcher);
@@ -1225,14 +1225,14 @@
         
         // The default is non-serialized inventory item
         if (createSerializedInventory == null) {
-            createSerializedInventory = new Boolean(false);
+            createSerializedInventory = Boolean.FALSE;
         }
         // The default is to create a lot if the lotId is given, but the lot doesn't exist
         if (createLotIfNeeded == null) {
-            createLotIfNeeded = new Boolean(true);
+            createLotIfNeeded = Boolean.TRUE;
         }
         if (autoCreateLot == null) {
-            autoCreateLot = new Boolean(false);
+            autoCreateLot = Boolean.FALSE;
         }
       
         List inventoryItemIds = new ArrayList();
@@ -1271,7 +1271,7 @@
         
         if (lotId == null && autoCreateLot.booleanValue()) {
             lotId = delegator.getNextSeqId("Lot");
-            createLotIfNeeded = new Boolean(true);
+            createLotIfNeeded = Boolean.TRUE;
         }
         if (lotId != null) {
             try {
@@ -1425,7 +1425,7 @@
         
         // The default is non-serialized inventory item
         if (createSerializedInventory == null) {
-            createSerializedInventory = new Boolean(false);
+            createSerializedInventory = Boolean.FALSE;
         }
         
         if (facilityId == null) {
@@ -1555,7 +1555,7 @@
         Boolean createSerializedInventory = (Boolean)context.get("createSerializedInventory");
         // The default is non-serialized inventory item
         if (createSerializedInventory == null) {
-            createSerializedInventory = new Boolean(false);
+            createSerializedInventory = Boolean.FALSE;
         }
         // TODO: if the task is not running, then return an error message.
 
@@ -2086,7 +2086,7 @@
             while (!"PRUN_COMPLETED".equals(currentStatusId)) {
                 serviceContext.put("productionRunId", productionRunId);
                 serviceContext.put("workEffortId", taskId);
-                serviceContext.put("issueAllComponents", new Boolean(true));
+                serviceContext.put("issueAllComponents", Boolean.TRUE);
                 serviceContext.put("userLogin", userLogin);
                 resultService = dispatcher.runSync("changeProductionRunTaskStatus", serviceContext);
                 currentStatusId = (String)resultService.get("newStatusId");

Modified: incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/mrp/MrpServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/mrp/MrpServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/mrp/MrpServices.java (original)
+++ incubator/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/mrp/MrpServices.java Sat Dec  9 04:19:28 2006
@@ -494,7 +494,7 @@
         GenericValue inventoryEventForMRP = null;
         
         // Initialisation of the InventoryEventPlanned table, This table will contain the products we want to buy or build.
-        parameters = UtilMisc.toMap("reInitialize",new Boolean(true),"userLogin", userLogin);
+        parameters = UtilMisc.toMap("reInitialize",Boolean.TRUE,"userLogin", userLogin);
         try {
             result = dispatcher.runSync("initInventoryEventPlanned", parameters);
         } catch (GenericServiceException e) {

Modified: incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java (original)
+++ incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java Sat Dec  9 04:19:28 2006
@@ -1136,7 +1136,7 @@
         Boolean forceAll = (Boolean) context.get("forceAll");
         Locale locale = (Locale) context.get("locale");
         if (forceAll == null) {
-            forceAll = new Boolean(false);
+            forceAll = Boolean.FALSE;
         }
 
         EntityCondition cond = null;

Modified: incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java (original)
+++ incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java Sat Dec  9 04:19:28 2006
@@ -2232,8 +2232,8 @@
             this.setCarrierPartyId(0, "_NA_");
             this.setShippingInstructions(0, "");
             this.setGiftMessage(0, "");
-            this.setMaySplit(0, new Boolean(true));
-            this.setIsGift(0, new Boolean(false));
+            this.setMaySplit(0, Boolean.TRUE);
+            this.setIsGift(0, Boolean.FALSE);
             //this.setInternalCode(internalCode);
         }
     }

Modified: incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java (original)
+++ incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java Sat Dec  9 04:19:28 2006
@@ -59,7 +59,7 @@
         Boolean clearEmptyGroups = (Boolean) context.get("clearEmptyGroups");
 
         if (clearEmptyGroups == null) {
-            clearEmptyGroups = new Boolean(true);
+            clearEmptyGroups = Boolean.TRUE;
         }
 
         Debug.log("From Group - " + fromGroupIndex + " To Group - " + toGroupIndex + "Item - " + itemIndex + "(" + quantity + ")", module);

Modified: incubator/ofbiz/trunk/applications/product/src/org/ofbiz/product/price/PriceServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/product/src/org/ofbiz/product/price/PriceServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/product/src/org/ofbiz/product/price/PriceServices.java (original)
+++ incubator/ofbiz/trunk/applications/product/src/org/ofbiz/product/price/PriceServices.java Sat Dec  9 04:19:28 2006
@@ -503,7 +503,7 @@
             result.put("promoPrice", promoPriceValue != null ? promoPriceValue.getDouble("price") : null);
             result.put("specialPromoPrice", specialPromoPriceValue != null ? specialPromoPriceValue.getDouble("price") : null);
             result.put("validPriceFound", new Boolean(validPriceFound));
-            result.put("isSale", new Boolean(false));
+            result.put("isSale", Boolean.FALSE);
             result.put("orderItemPriceInfos", FastList.newInstance());
 
             Map errorResult = addGeneralResults(result, competitivePriceValue, specialPromoPriceValue, productStore,

Modified: incubator/ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java (original)
+++ incubator/ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java Sat Dec  9 04:19:28 2006
@@ -197,8 +197,8 @@
         GenericValue currentStatus = null;
         
         if (workEffort == null) {
-            tryEntity = new Boolean(false);
-            canView = new Boolean(true);
+            tryEntity = Boolean.FALSE;
+            canView = Boolean.TRUE;
         
             String statusId = (String) context.get("currentStatusId");
         
@@ -220,10 +220,10 @@
             }
             canView = (workEffortPartyAssignments != null && workEffortPartyAssignments.size() > 0) ? Boolean.TRUE : Boolean.FALSE;
             if (!canView.booleanValue() && security.hasEntityPermission("WORKEFFORTMGR", "_VIEW", userLogin)) {
-                canView = new Boolean(true);
+                canView = Boolean.TRUE;
             }
         
-            tryEntity = new Boolean(true);
+            tryEntity = Boolean.TRUE;
         
             if (workEffort.get("currentStatusId") != null) {
                 try {
@@ -385,7 +385,7 @@
                         int periodSpan = (int) Math.ceil((double) length / period);                                                
                         calEntry.put("periodSpan", new Integer(periodSpan));
 
-                        if(i == 0) calEntry.put("startOfPeriod",new Boolean(true)); //If this is the first priod any valid entry is starting here
+                        if(i == 0) calEntry.put("startOfPeriod", Boolean.TRUE); //If this is the first priod any valid entry is starting here
                         else {
                             boolean startOfPeriod = ((estimatedStartDate.getTime() - curPeriodStart.getTime()) >= 0);                            
                             calEntry.put("startOfPeriod", new Boolean(startOfPeriod));

Modified: incubator/ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortWorker.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortWorker.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortWorker.java (original)
+++ incubator/ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortWorker.java Sat Dec  9 04:19:28 2006
@@ -66,8 +66,8 @@
         GenericValue currentStatus = null;
 
         if (workEffort == null) {
-            tryEntity = new Boolean(false);
-            canView = new Boolean(true);
+            tryEntity = Boolean.FALSE;
+            canView = Boolean.TRUE;
 
             String statusId = pageContext.getRequest().getParameter("currentStatusId");
 
@@ -88,12 +88,12 @@
                     Debug.logWarning(e, module);
                 }
             }
-            canView = (workEffortPartyAssignments != null && workEffortPartyAssignments.size() > 0) ? new Boolean(true) : new Boolean(false);
+            canView = (workEffortPartyAssignments != null && workEffortPartyAssignments.size() > 0) ? Boolean.TRUE : Boolean.FALSE;
             if (!canView.booleanValue() && security.hasEntityPermission("WORKEFFORTMGR", "_VIEW", pageContext.getSession())) {
-                canView = new Boolean(true);
+                canView = Boolean.TRUE;
             }
 
-            tryEntity = new Boolean(true);
+            tryEntity = Boolean.TRUE;
 
             if (workEffort.get("currentStatusId") != null) {
                 try {
@@ -106,7 +106,7 @@
 
         // if there was an error message, don't get values from entity
         if (pageContext.getRequest().getAttribute("_ERROR_MESSAGE_") != null) {
-            tryEntity = new Boolean(false);
+            tryEntity = Boolean.FALSE;
         }
 
         if (workEffortId != null)

Modified: incubator/ofbiz/trunk/framework/base/src/base/org/ofbiz/base/util/ObjectType.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/framework/base/src/base/org/ofbiz/base/util/ObjectType.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/framework/base/src/base/org/ofbiz/base/util/ObjectType.java (original)
+++ incubator/ofbiz/trunk/framework/base/src/base/org/ofbiz/base/util/ObjectType.java Sat Dec  9 04:19:28 2006
@@ -466,9 +466,9 @@
                 str = StringUtil.removeSpaces(str);
                 Boolean value = null;
                 if (str.equalsIgnoreCase("TRUE")) {
-                    value = new Boolean(true);
+                    value = Boolean.TRUE;
                 } else {
-                    value = new Boolean(false);
+                    value = Boolean.FALSE;
                 }
                 return value;
             } else if ("Locale".equals(type) || "java.util.Locale".equals(type)) {

Modified: incubator/ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonServices.java (original)
+++ incubator/ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonServices.java Sat Dec  9 04:19:28 2006
@@ -97,7 +97,7 @@
 
     public static Map testWorkflowCondition(DispatchContext dctx, Map context) {
         Map result = new HashMap();
-        result.put("evaluationResult", new Boolean(true));
+        result.put("evaluationResult", Boolean.TRUE);
         return result;
     }
 

Modified: incubator/ofbiz/trunk/framework/entityext/src/org/ofbiz/entityext/data/EntityDataServices.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/framework/entityext/src/org/ofbiz/entityext/data/EntityDataServices.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/framework/entityext/src/org/ofbiz/entityext/data/EntityDataServices.java (original)
+++ incubator/ofbiz/trunk/framework/entityext/src/org/ofbiz/entityext/data/EntityDataServices.java Sat Dec  9 04:19:28 2006
@@ -331,7 +331,7 @@
 
         String groupName = (String) context.get("groupName");
         Boolean fixSizes = (Boolean) context.get("fixColSizes");
-        if (fixSizes == null) fixSizes = new Boolean(false);
+        if (fixSizes == null) fixSizes = Boolean.FALSE;
         List messages = new ArrayList();
 
         String helperName = delegator.getGroupHelperName(groupName);

Modified: incubator/ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceDispatcher.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceDispatcher.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceDispatcher.java (original)
+++ incubator/ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceDispatcher.java Sat Dec  9 04:19:28 2006
@@ -761,7 +761,7 @@
 
     // gets a value object from name/password pair
     private GenericValue getLoginObject(String service, String localName, String username, String password, Locale locale) throws GenericServiceException {
-        Map context = UtilMisc.toMap("login.username", username, "login.password", password, "isServiceAuth", new Boolean(true), "locale", locale);
+        Map context = UtilMisc.toMap("login.username", username, "login.password", password, "isServiceAuth", Boolean.TRUE, "locale", locale);
 
         if (Debug.verboseOn()) Debug.logVerbose("[ServiceDispathcer.authenticate] : Invoking UserLogin Service", module);
 

Modified: incubator/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ControlServlet.java
URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ControlServlet.java?view=diff&rev=484976&r1=484975&r2=484976
==============================================================================
--- incubator/ofbiz/trunk/framewor