svn commit: r495429 - /ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java

[sichen]

Author: sichen
Date: Thu Jan 11 15:31:13 2007
New Revision: 495429

URL: http://svn.apache.org/viewvc?view=rev&rev=495429
Log:
trivial enhancements and comments to the send email to contact list service

Modified:
    ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java

Modified: ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java?view=diff&rev=495429&r1=495428&r2=495429
==============================================================================
--- ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java (original)
+++ ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java Thu Jan 11 15:31:13 2007
@@ -175,7 +175,7 @@
                     new EntityFindOptions(true, EntityFindOptions.TYPE_SCROLL_INSENSITIVE, EntityFindOptions.CONCUR_READ_ONLY, true));
             
             // Send an email to each contact list member
-            
+            // TODO: Contact lists for emails really should be written as an EntityListIterator for very large lists!
             List orderBy = UtilMisc.toList("-fromDate");
             Iterator sendToEmailsIt = sendToEmails.iterator();
             while (sendToEmailsIt.hasNext()) {
@@ -187,7 +187,7 @@
                 try {
     
                     String emailAddress = contactListPartyAndContactMech.getString("infoString");
-                    if (emailAddress == null) continue;
+                    if (UtilValidate.isEmpty(emailAddress)) continue;
                     emailAddress = emailAddress.trim();
                     
                     if (! UtilValidate.isEmail(emailAddress, true)) {