svn commit: r511251 - in /ofbiz/trunk: applications/accounting/src/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ application...

[jacopoc]

Author: jacopoc
Date: Sat Feb 24 03:32:06 2007
New Revision: 511251

URL: http://svn.apache.org/viewvc?view=rev&rev=511251
Log:
Applied patch from Stefan Huehner (OFBIZ-511) to remove unnecessary casts.

Modified:
    ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentGatewayServices.java
    ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java
    ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
    ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/techdata/TechDataServices.java
    ofbiz/trunk/framework/base/src/base/org/ofbiz/base/util/UtilFormatOut.java

Modified: ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentGatewayServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentGatewayServices.java?view=diff&rev=511251&r1=511250&r2=511251
==============================================================================
--- ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentGatewayServices.java (original)
+++ ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentGatewayServices.java Sat Feb 24 03:32:06 2007
@@ -1753,7 +1753,7 @@
                 Debug.logError(e, "Problems getting OrderHeader; cannot re-auth the payment", module);
             }
 
-            if (amount != null && (double) amount.doubleValue() == new Double(0.00).doubleValue()) {
+            if (amount != null && amount.doubleValue() == new Double(0.00).doubleValue()) {
                 amount = paymentPreference.getDouble("maxAmount");
                 Debug.log("resetting payment amount from 0.00 to correctMax amount", module);
             }

Modified: ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java?view=diff&rev=511251&r1=511250&r2=511251
==============================================================================
--- ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java (original)
+++ ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java Sat Feb 24 03:32:06 2007
@@ -545,7 +545,7 @@
             results.put("captureRefNum", ar.getResponseField(AuthorizeResponse.TRANSACTION_ID));
             results.put("cvCode", ar.getResponseField(AuthorizeResponse.CID_RESPONSE_CODE));
             results.put("avsCode", ar.getResponseField(AuthorizeResponse.AVS_RESULT_CODE));
-            results.put("processAmount", new Double((String)ar.getResponseField(AuthorizeResponse.AMOUNT)));
+            results.put("processAmount", new Double(ar.getResponseField(AuthorizeResponse.AMOUNT)));
         } else {
             results.put("authCode", ar.getResponseCode());
             results.put("processAmount", new Double("0.00"));

Modified: ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java?view=diff&rev=511251&r1=511250&r2=511251
==============================================================================
--- ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java (original)
+++ ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java Sat Feb 24 03:32:06 2007
@@ -2340,7 +2340,7 @@
                                  "userLogin", userLogin);
             resultService = dispatcher.runSync("getProductCost", serviceContext);
             Double packageCost = (Double)resultService.get("productCost");
-            Double inventoryItemCost = (Double)inventoryItem.getDouble("unitCost");
+            Double inventoryItemCost = inventoryItem.getDouble("unitCost");
             Double costCoefficient = null;
             if (packageCost == null || packageCost.doubleValue() == 0 || inventoryItemCost == null) {
                 // if the actual cost of the item (marketing package) that we are decomposing is not available, or

Modified: ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/techdata/TechDataServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/techdata/TechDataServices.java?view=diff&rev=511251&r1=511250&r2=511251
==============================================================================
--- ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/techdata/TechDataServices.java (original)
+++ ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/techdata/TechDataServices.java Sat Feb 24 03:32:06 2007
@@ -265,7 +265,7 @@
         }
         // TODO read TechDataCalendarExcDay to manage execption day
         Calendar cDateTrav =  Calendar.getInstance();
-        cDateTrav.setTime((Date) dateFrom);
+        cDateTrav.setTime(dateFrom);
         Map position = dayStartCapacityAvailable(techDataCalendarWeek, cDateTrav.get(Calendar.DAY_OF_WEEK));
         int moveDay = ((Integer) position.get("moveDay")).intValue();
         if (moveDay != 0) return 0;
@@ -298,7 +298,7 @@
         }
         // TODO read TechDataCalendarExcDay to manage execption day
         Calendar cDateTrav =  Calendar.getInstance();
-        cDateTrav.setTime((Date) dateFrom);
+        cDateTrav.setTime(dateFrom);
         Map position = dayStartCapacityAvailable(techDataCalendarWeek, cDateTrav.get(Calendar.DAY_OF_WEEK));
         Time startTime = (Time) position.get("startTime");
         int moveDay = ((Integer) position.get("moveDay")).intValue();
@@ -309,7 +309,7 @@
         }
         else {
             dateTo = UtilDateTime.getNextDayStart(dateTo);
-            cDateTrav.setTime((Date) dateTo);
+            cDateTrav.setTime(dateTo);
             position = dayStartCapacityAvailable(techDataCalendarWeek, cDateTrav.get(Calendar.DAY_OF_WEEK));
             startTime = (Time) position.get("startTime");
             moveDay = ((Integer) position.get("moveDay")).intValue();
@@ -420,7 +420,7 @@
         }
         // TODO read TechDataCalendarExcDay to manage execption day
         Calendar cDateTrav =  Calendar.getInstance();
-        cDateTrav.setTime((Date) dateFrom);
+        cDateTrav.setTime(dateFrom);
         Map position = dayEndCapacityAvailable(techDataCalendarWeek, cDateTrav.get(Calendar.DAY_OF_WEEK));
         int moveDay = ((Integer) position.get("moveDay")).intValue();
         if (moveDay != 0) return 0;
@@ -452,7 +452,7 @@
         }
         // TODO read TechDataCalendarExcDay to manage execption day
         Calendar cDateTrav =  Calendar.getInstance();
-        cDateTrav.setTime((Date) dateFrom);
+        cDateTrav.setTime(dateFrom);
         Map position = dayEndCapacityAvailable(techDataCalendarWeek, cDateTrav.get(Calendar.DAY_OF_WEEK));
         Time startTime = (Time) position.get("startTime");
         int moveDay = ((Integer) position.get("moveDay")).intValue();
@@ -464,7 +464,7 @@
         }
         else {
             dateTo = UtilDateTime.getDayStart(dateTo, -1);
-            cDateTrav.setTime((Date) dateTo);
+            cDateTrav.setTime(dateTo);
             position = dayEndCapacityAvailable(techDataCalendarWeek, cDateTrav.get(Calendar.DAY_OF_WEEK));
             startTime = (Time) position.get("startTime");
             moveDay = ((Integer) position.get("moveDay")).intValue();

Modified: ofbiz/trunk/framework/base/src/base/org/ofbiz/base/util/UtilFormatOut.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/base/org/ofbiz/base/util/UtilFormatOut.java?view=diff&rev=511251&r1=511250&r2=511251
==============================================================================
--- ofbiz/trunk/framework/base/src/base/org/ofbiz/base/util/UtilFormatOut.java (original)
+++ ofbiz/trunk/framework/base/src/base/org/ofbiz/base/util/UtilFormatOut.java Sat Feb 24 03:32:06 2007
@@ -278,7 +278,7 @@
         if (timestamp == null)
             return "";
         DateFormat df = DateFormat.getDateTimeInstance(DateFormat.LONG, DateFormat.FULL);
-        java.util.Date date = (java.util.Date) timestamp;
+        java.util.Date date = timestamp;
         return df.format(date);        
     }