svn commit: r585716 - in /ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config: JNDIConfigUtil.java MainResourceHandler.java SecurityConfigUtil.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r585716 - in /ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config: JNDIConfigUtil.java MainResourceHandler.java SecurityConfigUtil.java

doogie-3
Author: doogie
Date: Wed Oct 17 14:48:40 2007
New Revision: 585716

URL: http://svn.apache.org/viewvc?rev=585716&view=rev
Log:
Make these config classes final.

Modified:
    ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/JNDIConfigUtil.java
    ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/MainResourceHandler.java
    ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/SecurityConfigUtil.java

Modified: ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/JNDIConfigUtil.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/JNDIConfigUtil.java?rev=585716&r1=585715&r2=585716&view=diff
==============================================================================
--- ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/JNDIConfigUtil.java (original)
+++ ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/JNDIConfigUtil.java Wed Oct 17 14:48:40 2007
@@ -77,13 +77,13 @@
         return (JNDIConfigUtil.JndiServerInfo) jndiServerInfos.get(name);
     }
 
-    public static class JndiServerInfo {
-        public String name;
-        public String contextProviderUrl;
-        public String initialContextFactory;
-        public String urlPkgPrefixes;
-        public String securityPrincipal;
-        public String securityCredentials;
+    public static final class JndiServerInfo {
+        public final String name;
+        public final String contextProviderUrl;
+        public final String initialContextFactory;
+        public final String urlPkgPrefixes;
+        public final String securityPrincipal;
+        public final String securityCredentials;
 
         public JndiServerInfo(Element element) {
             this.name = element.getAttribute("name");

Modified: ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/MainResourceHandler.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/MainResourceHandler.java?rev=585716&r1=585715&r2=585716&view=diff
==============================================================================
--- ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/MainResourceHandler.java (original)
+++ ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/MainResourceHandler.java Wed Oct 17 14:48:40 2007
@@ -31,12 +31,12 @@
  * Contains resource information and provides for loading data
  *
  */
-public class MainResourceHandler implements ResourceHandler {
+public final class MainResourceHandler implements ResourceHandler {
 
     public static final String module = MainResourceHandler.class.getName();
-    protected String xmlFilename;
-    protected String loaderName;
-    protected String location;
+    protected final String xmlFilename;
+    protected final String loaderName;
+    protected final String location;
 
     public MainResourceHandler(String xmlFilename, Element element) {
         this.xmlFilename = xmlFilename;

Modified: ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/SecurityConfigUtil.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/SecurityConfigUtil.java?rev=585716&r1=585715&r2=585716&view=diff
==============================================================================
--- ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/SecurityConfigUtil.java (original)
+++ ofbiz/trunk/framework/base/src/base/org/ofbiz/base/config/SecurityConfigUtil.java Wed Oct 17 14:48:40 2007
@@ -105,9 +105,9 @@
     /**
      * <code>SecurityInfo</code>
      */
-    public static class SecurityInfo {
-        public String name;
-        public String className;
+    public static final class SecurityInfo {
+        public final String name;
+        public final String className;
 
         /**
          * Creates a SecurityInfo for a given element