svn commit: r597019 - in /ofbiz/trunk/applications/product: data/ProductTypeData.xml entitydef/entitymodel.xml

[jonesde]

Author: jonesde
Date: Wed Nov 21 02:15:42 2007
New Revision: 597019

URL: http://svn.apache.org/viewvc?rev=597019&view=rev
Log:
Changed long-varchar back to id for the customPriceCalcService field; also added comments to make it clear that this points to a Custoso added comments to make it more clear that this points to a CustomMethod and isn't the service name itself; also noted that the field name is misleading for this and one more consistent with patterns used elsewhere would be better, but not really into the idea of changing this right now

Modified:
    ofbiz/trunk/applications/product/data/ProductTypeData.xml
    ofbiz/trunk/applications/product/entitydef/entitymodel.xml

Modified: ofbiz/trunk/applications/product/data/ProductTypeData.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/data/ProductTypeData.xml?rev=597019&r1=597018&r2=597019&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/data/ProductTypeData.xml (original)
+++ ofbiz/trunk/applications/product/data/ProductTypeData.xml Wed Nov 21 02:15:42 2007
@@ -406,8 +406,8 @@
     <ProductPriceActionType description="Promo Amount Override" productPriceActionTypeId="PRICE_PFLAT"/>
     <ProductPriceActionType description="Wholesale Amount Override" productPriceActionTypeId="PRICE_WFLAT"/>
 
-    <CustomMethodType customMethodTypeId="PRICE_FORMULA" description="Formula for calculating the unit price of a product"/>
-
+    <CustomMethodType customMethodTypeId="PRICE_FORMULA" description="Service with formula for calculating the unit price of a product"/>
+    
     <ProductStoreGroup productStoreGroupName="Not Applicable" description="Not Applicable" productStoreGroupId="_NA_" productStoreGroupTypeId="" primaryParentGroupId=""/>
 
     <ProductType description="Fixed Asset Usage" isPhysical="Y" isDigital="N" hasTable="N" parentTypeId="" productTypeId="ASSET_USAGE"/>

Modified: ofbiz/trunk/applications/product/entitydef/entitymodel.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/entitydef/entitymodel.xml?rev=597019&r1=597018&r2=597019&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/entitydef/entitymodel.xml (original)
+++ ofbiz/trunk/applications/product/entitydef/entitymodel.xml Wed Nov 21 02:15:42 2007
@@ -1725,7 +1725,7 @@
       <field name="thruDate" type="date-time"></field>
       <field name="price" type="currency-precise"></field>
       <field name="termUomId" type="id"><description>Mainly used for recurring and usage prices to specify a time/freq measure, or a usage unit measure (bits, minutes, etc)</description></field>
-      <field name="customPriceCalcService" type="long-varchar"><description>Used to specify an external service for the calculation of the unit price of the product</description></field>
+      <field name="customPriceCalcService" type="id"><description>Points to a CustomMethod used to specify a service for the calculation of the unit price of the product (NOTE: a better name for this field might be priceCalcCustomMethodId)</description></field>
       <field name="createdDate" type="date-time"></field>
       <field name="createdByUserLogin" type="id-vlong"></field>
       <field name="lastModifiedDate" type="date-time"></field>