svn commit: r606807 - in /ofbiz/trunk/applications/ecommerce: build.xml src/org/ofbiz/ecommerce/misc/ThirdPartyEvents.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r606807 - in /ofbiz/trunk/applications/ecommerce: build.xml src/org/ofbiz/ecommerce/misc/ThirdPartyEvents.java

jleroux@apache.org
Author: jleroux
Date: Tue Dec 25 12:10:49 2007
New Revision: 606807

URL: http://svn.apache.org/viewvc?rev=606807&view=rev
Log:
From Java complier message <<[javac] Note: Recompile with -Xlint:unchecked for details.>> I tried to use it in eCommerce and corrected ThirdPartyEvents.java
I wonder now if we should not use it everywhere. Personnally I think we should, what do you think, are we ready ? I believe it should not be to hard to deal with it, but I did not try yet...

Modified:
    ofbiz/trunk/applications/ecommerce/build.xml
    ofbiz/trunk/applications/ecommerce/src/org/ofbiz/ecommerce/misc/ThirdPartyEvents.java

Modified: ofbiz/trunk/applications/ecommerce/build.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/build.xml?rev=606807&r1=606806&r2=606807&view=diff
==============================================================================
--- ofbiz/trunk/applications/ecommerce/build.xml (original)
+++ ofbiz/trunk/applications/ecommerce/build.xml Tue Dec 25 12:10:49 2007
@@ -86,7 +86,8 @@
     <!-- ================================================================== -->
 
     <target name="classes" depends="prepare,classpath">
-     <javac debug="on" source="1.5" deprecation="on" destdir="${build.dir}/classes">
+      <javac debug="on" source="1.5" deprecation="on" destdir="${build.dir}/classes">
+            <compilerarg value="-Xlint:unchecked"/>
             <classpath>
                 <path refid="local.class.path"/>
             </classpath>

Modified: ofbiz/trunk/applications/ecommerce/src/org/ofbiz/ecommerce/misc/ThirdPartyEvents.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/src/org/ofbiz/ecommerce/misc/ThirdPartyEvents.java?rev=606807&r1=606806&r2=606807&view=diff
==============================================================================
--- ofbiz/trunk/applications/ecommerce/src/org/ofbiz/ecommerce/misc/ThirdPartyEvents.java (original)
+++ ofbiz/trunk/applications/ecommerce/src/org/ofbiz/ecommerce/misc/ThirdPartyEvents.java Tue Dec 25 12:10:49 2007
@@ -141,7 +141,7 @@
                 String distributorId = (String) request.getSession().getAttribute(DISTRIBUTOR_ID);
 
                 if (UtilValidate.isNotEmpty(distributorId)) {
-                    List toBeStored = new LinkedList();
+                    List<GenericValue> toBeStored = new LinkedList<GenericValue>();
 
                     // create distributor Party ?? why?
                     // create distributor PartyRole ?? why?