svn commit: r696190 - /ofbiz/trunk/applications/order/script/org/ofbiz/order/request/CustRequestServices.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r696190 - /ofbiz/trunk/applications/order/script/org/ofbiz/order/request/CustRequestServices.xml

jacopoc
Author: jacopoc
Date: Wed Sep 17 01:00:04 2008
New Revision: 696190

URL: http://svn.apache.org/viewvc?rev=696190&view=rev
Log:
Commented out some (rather old) code that was too specific and not valid as a general rule: a user entering a customer request from another party is not necessarily the user that will work on the request.

Modified:
    ofbiz/trunk/applications/order/script/org/ofbiz/order/request/CustRequestServices.xml

Modified: ofbiz/trunk/applications/order/script/org/ofbiz/order/request/CustRequestServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/script/org/ofbiz/order/request/CustRequestServices.xml?rev=696190&r1=696189&r2=696190&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/script/org/ofbiz/order/request/CustRequestServices.xml (original)
+++ ofbiz/trunk/applications/order/script/org/ofbiz/order/request/CustRequestServices.xml Wed Sep 17 01:00:04 2008
@@ -72,11 +72,16 @@
         <create-value value-name="newEntity"/>
         <field-to-result field-name="custRequestId" map-name="newEntity"/>
 
+        <!-- jacopoc: Commented out the following code because it is too specific and not valid as a
+                      general rule: a user may enter the request from a customer even if he will not work
+                      on it -->
         <!-- If the logged in partyId that is creating the request is not equal to the fromPartyId
              then we associate it to the request as the request taker.
              This is not done if they are the same e.g. a logged in customer that is creating a request for its
              own sake. -->
-        <if-not-empty field="userLogin.partyId">  <!-- just in case the service is called by the "system" userLogin -->
+        <!-- just in case the service is called by the "system" userLogin -->
+        <!--
+        <if-not-empty field="userLogin.partyId">
             <if-compare-field field="parameters.fromPartyId" to-field="userLogin.partyId" operator="not-equals">
                 <set from-field="newEntity.custRequestId" field="takerMap.custRequestId"/>
                 <set from-field="userLogin.partyId" field="takerMap.partyId"/>
@@ -84,6 +89,7 @@
                 <call-service service-name="createCustRequestParty" in-map-name="takerMap"/>
             </if-compare-field>
         </if-not-empty>
+        -->
         
         <!-- save the created status in the history -->
         <set-service-fields to-map-name="statusMap" service-name="createCustRequestStatus" map-name="newEntity"/>