svn commit: r758511 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/shipping/ShippingEvents.java

[jonesde]

Author: jonesde
Date: Thu Mar 26 03:55:45 2009
New Revision: 758511

URL: http://svn.apache.org/viewvc?rev=758511&view=rev
Log:
Fixed NPE; not sure why this suddenly showed up but was showing an error in checkout in ecommerce

Modified:
    ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/shipping/ShippingEvents.java

Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/shipping/ShippingEvents.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/shipping/ShippingEvents.java?rev=758511&r1=758510&r2=758511&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/shipping/ShippingEvents.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/shipping/ShippingEvents.java Thu Mar 26 03:55:45 2009
@@ -152,8 +152,8 @@
         String standardMessage = "A problem occurred calculating shipping. Fees will be calculated offline.";
         List errorMessageList = new ArrayList();
 
-        if (shipmentMethodTypeId.equals("NO_SHIPPING")) {
-                return ServiceUtil.returnSuccess();
+        if ("NO_SHIPPING".equals(shipmentMethodTypeId)) {
+            return ServiceUtil.returnSuccess();
         }
 
         if (shipmentMethodTypeId == null || carrierPartyId == null) {