svn commit: r778094 - in /ofbiz/trunk/applications/party: script/org/ofbiz/party/communication/CommunicationEventEvents.xml script/org/ofbiz/party/communication/CommunicationEventServices.xml widget/partymgr/PartyMenus.xml

[hansbak-2]

Author: hansbak
Date: Sun May 24 06:13:34 2009
New Revision: 778094

URL: http://svn.apache.org/viewvc?rev=778094&view=rev
Log:
some more corrections on internal notes: now possible to edit other users comunication events if the relationship is properly registered in partyrelationship

Modified:
    ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventEvents.xml
    ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml
    ofbiz/trunk/applications/party/widget/partymgr/PartyMenus.xml

Modified: ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventEvents.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventEvents.xml?rev=778094&r1=778093&r2=778094&view=diff
==============================================================================
--- ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventEvents.xml (original)
+++ ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventEvents.xml Sun May 24 06:13:34 2009
@@ -34,12 +34,7 @@
                 <set field="updStat.statusId" value="COM_ROLE_READ"/>
                 <set field="updStat.userLogin" from-field="userLogin"/>
                 <call-service service-name="setCommunicationEventRoleStatus" in-map-name="updStat"
-                    include-user-login="false"/>
-                <else>
-                    <add-error>
-                        <fail-property property="MyPortalNoAccess" resource="MyPortalUiLabels"/>
-                    </add-error>
-                </else>
+                include-user-login="false"/>
             </if-compare>
         </if-compare>
     </simple-method>
@@ -47,19 +42,15 @@
     <simple-method method-name="checkCommEventAccess"
         short-description="check if the user has access to the email of this party">
         <set field="found" value="false"/>
-        <if-compare-field operator="not-equals" field="parameters.partyId"
-            to-field="userLogin.partyId">
-            <entity-and list="emailOwners" entity-name="PartyRelationship"
-                filter-by-date="true">
+        <if-compare-field operator="not-equals" field="parameters.partyId" to-field="userLogin.partyId">
+            <entity-and list="emailOwners" entity-name="PartyRelationship" filter-by-date="true">
                 <field-map field-name="partyIdFrom" value="${userLogin.partyId}"/>
                 <field-map field-name="roleTypeIdFrom" value="EMAIL_ADMIN"/>
+                <field-map field-name="partyIdTo" from-field="parameters.partyId"/>
             </entity-and>
-            <iterate entry="emailOwners" list="emailOwner">
-                <if-compare operator="equals" value="${userLogin.partyId}"
-                    field="emailOwner.partyIdTo">
-                    <set field="found" value="true"/>
-                </if-compare>
-            </iterate>
+            <if-not-empty field="emailOwners">
+                <set field="found" value="true"/>
+            </if-not-empty>
             <else>
                 <set field="found" value="true"/>
             </else>

Modified: ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml?rev=778094&r1=778093&r2=778094&view=diff
==============================================================================
--- ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml (original)
+++ ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml Sun May 24 06:13:34 2009
@@ -69,9 +69,8 @@
                     <field-map field-name="partyId" from-field="parentCommEvent.partyIdFrom"/>
                 </entity-one>
                 
-                <if-compare-field field="parentCommEvent.partyIdFrom" operator="equals" to-field="parameters.partyIdTo">
-                    <set field="newEntity.partyIdTo" from-field="parentCommEvent.partyIdFrom"/>
-                </if-compare-field>
+                <set field="newEntity.partyIdFrom" from-field="parameters.partyIdFrom" default-value="parameters.userLogin.partyId"/>
+                <set field="newEntity.partyIdTo" from-field="parentCommEvent.partyIdFrom"/>
                 
                 <set field="newEntity.subject" value="RE: ${parentCommEvent.subject}"/>
                 

Modified: ofbiz/trunk/applications/party/widget/partymgr/PartyMenus.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/widget/partymgr/PartyMenus.xml?rev=778094&r1=778093&r2=778094&view=diff
==============================================================================
--- ofbiz/trunk/applications/party/widget/partymgr/PartyMenus.xml (original)
+++ ofbiz/trunk/applications/party/widget/partymgr/PartyMenus.xml Sun May 24 06:13:34 2009
@@ -393,10 +393,9 @@
             <link target="NewDraftCommunicationEvent">
                 <parameter param-name="communicationEventTypeId" from-field="communicationEvent.communicationEventTypeId"/>
                 <parameter param-name="parentCommEventId" from-field="communicationEvent.communicationEventId"/>
-                <parameter param-name="partyIdFrom" from-field="parameters.partyId"/>
                 <parameter param-name="my" value="My"/>
                 <parameter param-name="statusId" value="COM_PENDING"/>
-                <parameter param-name="partyIdTo" from-field="communicationEvent.partyIdFrom"/>
+                <parameter param-name="partyIdFrom" from-field="parameters.partyId"/>
             </link>
         </menu-item>
         <menu-item name="forward" title="${uiLabelMap.PartyForward}">