svn commit: r829412 - /ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r829412 - /ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy

jleroux@apache.org
Author: jleroux
Date: Sat Oct 24 16:58:43 2009
New Revision: 829412

URL: http://svn.apache.org/viewvc?rev=829412&view=rev
Log:
A patch from Akash Jain "NPE appears on create customer from order entry screens." (https://issues.apache.org/jira/browse/OFBIZ-3079) - OFBIZ-3079
There is a session issue, actually there is getting ShoppingCart object from session when session is expired then ShoppingCart object will be null and there is no check for this ShoppingCart object and call method of ShoppingCart.

Modified:
    ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy

Modified: ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy?rev=829412&r1=829411&r2=829412&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy (original)
+++ ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy Sat Oct 24 16:58:43 2009
@@ -28,6 +28,7 @@
 
 cart = session.getAttribute("shoppingCart");
 
+if (cart) {
 createNewShipGroup = request.getParameter("createNewShipGroup");
 if ("Y".equals(createNewShipGroup)) {
     cart.addShipInfo();
@@ -92,3 +93,4 @@
         context.facilityMaps = facilityMaps;
     }
 }
+}