Login  Register

svn commit: r834447 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options Options
Embed post
Permalink
Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

svn commit: r834447 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java

jleroux@apache.org
14119 posts
Author: jleroux
Date: Tue Nov 10 12:16:43 2009
New Revision: 834447

URL: http://svn.apache.org/viewvc?rev=834447&view=rev
Log:
I prefer to revert as it's not needed anymore since r834444. I had an intuitive feeling that something was wrong, and forgot to check :( Thanks to Todor it's ok!

Modified:
    ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java

Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java?rev=834447&r1=834446&r2=834447&view=diff
==============================================================================
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java (original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java Tue Nov 10 12:16:43 2009
@@ -181,19 +181,16 @@
      * @return a list of Strings
      */
     public static List<String> split(String str, String delim) {
-        List<String> splitList = FastList.newInstance();
+        List<String> splitList = null;
         StringTokenizer st = null;
 
-        if (str == null) {
+        if (str == null)
             return splitList;
-        }
 
-        if (delim != null) {
+        if (delim != null)
             st = new StringTokenizer(str, delim);
-        }
-        else {
+        else
             st = new StringTokenizer(str);
-        }
 
         if (st != null && st.hasMoreTokens()) {
             splitList = FastList.newInstance();