svn commit: r935162 - in /ofbiz/trunk/specialpurpose: ebaystore/src/org/ofbiz/ebaystore/ oagis/src/org/ofbiz/oagis/ projectmgr/widget/forms/ shark/src/org/ofbiz/shark/audit/ shark/src/org/ofbiz/shark/expression/ shark/src/org/ofbiz/shark/mapping/ webpo...

[lektran]

Author: lektran
Date: Sat Apr 17 10:25:42 2010
New Revision: 935162

URL: http://svn.apache.org/viewvc?rev=935162&view=rev
Log:
Get rid of a few Boolean instantiations

Modified:
    ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayEvents.java
    ofbiz/trunk/specialpurpose/oagis/src/org/ofbiz/oagis/OagisShipmentServices.java
    ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml
    ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/audit/AssignmentEventAudit.java
    ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/expression/BaseEntityCondExprBldr.java
    ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/mapping/EntityParticipantMap.java
    ofbiz/trunk/specialpurpose/webpos/src/org/ofbiz/webpos/session/WebPosSession.java

Modified: ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayEvents.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayEvents.java?rev=935162&r1=935161&r2=935162&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayEvents.java (original)
+++ ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayEvents.java Sat Apr 17 10:25:42 2010
@@ -727,7 +727,7 @@ public class EbayEvents {
                             amtBIN.setValue(Double.parseDouble(startPrice));
                             item.setStartPrice(amtBIN);
                             if (UtilValidate.isNotEmpty(requestParams.get("enableBestOffer".concat(id)))) {
-                                item.setBestOfferEnabled(new Boolean(requestParams.get("enableBestOffer".concat(id)).toString()));
+                                item.setBestOfferEnabled(Boolean.valueOf(requestParams.get("enableBestOffer".concat(id)).toString()));
                             }
                         }
                         attributeMapList.put("ListingType", item.getListingType().value());

Modified: ofbiz/trunk/specialpurpose/oagis/src/org/ofbiz/oagis/OagisShipmentServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/oagis/src/org/ofbiz/oagis/OagisShipmentServices.java?rev=935162&r1=935161&r2=935162&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/oagis/src/org/ofbiz/oagis/OagisShipmentServices.java (original)
+++ ofbiz/trunk/specialpurpose/oagis/src/org/ofbiz/oagis/OagisShipmentServices.java Sat Apr 17 10:25:42 2010
@@ -753,7 +753,7 @@ public class OagisShipmentServices {
             Map<String, Object> authServiceContext = FastMap.newInstance();
             authServiceContext.put("orderId", orderId);
             authServiceContext.put("userLogin", userLogin);
-            authServiceContext.put("reAuth", new Boolean("true"));
+            authServiceContext.put("reAuth", true);
             Map<String, Object> authResult = dispatcher.runSync("authOrderPayments", authServiceContext);
             if (!authResult.get("processResult").equals("APPROVED")) {
                 return ServiceUtil.returnError("No authorized payment available, not sending Process Shipment");

Modified: ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml?rev=935162&r1=935161&r2=935162&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml (original)
+++ ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml Sat Apr 17 10:25:42 2010
@@ -124,7 +124,7 @@
             </entity-condition>
         </actions>
         <row-actions>
-            <set field="showPosition1" value="${bsh:String prev=(String)previousItem.get(&quot;workEffortId&quot;);return new Boolean(!(prev!=null&amp;&amp;prev.equals(workEffortId)));}" type="Boolean"/>
+            <set field="showPosition1" value="${bsh:String prev=(String)previousItem.get(&quot;workEffortId&quot;);return !(prev!=null&amp;&amp;prev.equals(workEffortId));}" type="Boolean"/>
         </row-actions>
         <field name="workEffortId"><hidden/></field>
         <field name="phaseName" position="1" use-when="showPosition1"><display description="${phaseName}[${phaseId}]"/></field>

Modified: ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/audit/AssignmentEventAudit.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/audit/AssignmentEventAudit.java?rev=935162&r1=935161&r2=935162&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/audit/AssignmentEventAudit.java (original)
+++ ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/audit/AssignmentEventAudit.java Sat Apr 17 10:25:42 2010
@@ -93,7 +93,7 @@ public class AssignmentEventAudit extend
     }
 
     public void setIsAccepted(boolean acc) {
-        assignmentEventAudit.set("isAccepted", new Boolean(acc));
+        assignmentEventAudit.set("isAccepted", acc);
     }
 
     public boolean getIsAccepted() {

Modified: ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/expression/BaseEntityCondExprBldr.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/expression/BaseEntityCondExprBldr.java?rev=935162&r1=935161&r2=935162&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/expression/BaseEntityCondExprBldr.java (original)
+++ ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/expression/BaseEntityCondExprBldr.java Sat Apr 17 10:25:42 2010
@@ -183,7 +183,7 @@ public abstract class BaseEntityCondExpr
         Iterator vli = this.viewLinks.iterator();
         while (vli.hasNext()) {
             ViewLink vl = (ViewLink) vli.next();
-            view.addViewLink(vl.entityAlias, vl.relEntityAlias, new Boolean(vl.relOptional), vl.keyMaps);
+            view.addViewLink(vl.entityAlias, vl.relEntityAlias, vl.relOptional, vl.keyMaps);
         }
 
         return view;

Modified: ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/mapping/EntityParticipantMap.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/mapping/EntityParticipantMap.java?rev=935162&r1=935161&r2=935162&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/mapping/EntityParticipantMap.java (original)
+++ ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/mapping/EntityParticipantMap.java Sat Apr 17 10:25:42 2010
@@ -121,7 +121,7 @@ public class EntityParticipantMap implem
     }
 
     public void setIsGroupUser(boolean isGroupUser) {
-        participant.set(org.ofbiz.shark.SharkConstants.isGroupUser, new Boolean(isGroupUser));
+        participant.set(org.ofbiz.shark.SharkConstants.isGroupUser, isGroupUser);
     }
 
     public void store() throws RootException {

Modified: ofbiz/trunk/specialpurpose/webpos/src/org/ofbiz/webpos/session/WebPosSession.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/webpos/src/org/ofbiz/webpos/session/WebPosSession.java?rev=935162&r1=935161&r2=935162&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/webpos/src/org/ofbiz/webpos/session/WebPosSession.java (original)
+++ ofbiz/trunk/specialpurpose/webpos/src/org/ofbiz/webpos/session/WebPosSession.java Sat Apr 17 10:25:42 2010
@@ -233,7 +233,7 @@ public class WebPosSession {
 
     public boolean isManagerLoggedIn() {
         if (UtilValidate.isEmpty(mgrLoggedIn)) {
-            mgrLoggedIn = new Boolean(hasRole(getUserLogin(), "MANAGER"));
+            mgrLoggedIn = hasRole(getUserLogin(), "MANAGER");
         }
         return mgrLoggedIn.booleanValue();
     }