svn commit: r951099 - /ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java

[jacopoc]

Author: jacopoc
Date: Thu Jun  3 18:24:45 2010
New Revision: 951099

URL: http://svn.apache.org/viewvc?rev=951099&view=rev
Log:
Fixed bug where eBay itemId was set as order's externaId instead of transactionId; transactionId was also stored in the order but never used.


Modified:
    ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java

Modified: ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java?rev=951099&r1=951098&r2=951099&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java (original)
+++ ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java Thu Jun  3 18:24:45 2010
@@ -861,11 +861,10 @@ public class EbayOrderServices {
                             // retrieve transactionId
                             String transactionId = UtilXml.childElementValue(transactionElement, "TransactionID", "");
 
-                            // set the externalId and transactionId
-                            orderCtx.put("externalId", itemId);
-                            orderCtx.put("transactionId", transactionId);
+                            // set the externalId
+                            orderCtx.put("externalId", transactionId);
 
-                            GenericValue orderExist = externalOrderExists(delegator, itemId);
+                            GenericValue orderExist = externalOrderExists(delegator, transactionId);
                             if (orderExist != null) {
                                 orderCtx.put("orderId", (String) orderExist.get("orderId"));
                             } else {