svn commit: r981176 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r981176 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java

lektran
Author: lektran
Date: Sun Aug  1 08:51:54 2010
New Revision: 981176

URL: http://svn.apache.org/viewvc?rev=981176&view=rev
Log:
Fix bug in unused method, the newly created result map was being iterated over instead of the input list.  Also added generics markup.

Modified:
    ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java

Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java?rev=981176&r1=981175&r2=981176&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java Sun Aug  1 08:51:54 2010
@@ -1444,12 +1444,12 @@ public class CheckOutHelper {
         return availableAccountBalance(billingAccountId, dispatcher);
     }
 
-    public Map<String, BigDecimal> makeBillingAccountMap(List paymentPrefs) {
+    public Map<String, BigDecimal> makeBillingAccountMap(List<GenericValue> paymentPrefs) {
         Map<String, BigDecimal> accountMap = new HashMap<String, BigDecimal>();
         if (paymentPrefs != null) {
-            Iterator i = accountMap.keySet().iterator();
+            Iterator<GenericValue> i = paymentPrefs.iterator();
             while (i.hasNext()) {
-                GenericValue pp = (GenericValue) i.next();
+                GenericValue pp = i.next();
                 if (pp.get("billingAccountId") != null) {
                     accountMap.put(pp.getString("billingAccountId"), pp.getBigDecimal("maxAmount"));
                 }