svn commit: r995846 - /ofbiz/trunk/framework/images/webapp/images/selectall.js

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r995846 - /ofbiz/trunk/framework/images/webapp/images/selectall.js

jonesde
Author: jonesde
Date: Fri Sep 10 16:14:29 2010
New Revision: 995846

URL: http://svn.apache.org/viewvc?rev=995846&view=rev
Log:
Commented out changes from Jacques in 993508, these assumed that the autocompleter field was a name which breaks all fields that are meant to be IDs; if that change is improved so use the description-field-name attribute this should not happen, but for now leaving this out

Modified:
    ofbiz/trunk/framework/images/webapp/images/selectall.js

Modified: ofbiz/trunk/framework/images/webapp/images/selectall.js
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/selectall.js?rev=995846&r1=995845&r2=995846&view=diff
==============================================================================
--- ofbiz/trunk/framework/images/webapp/images/selectall.js (original)
+++ ofbiz/trunk/framework/images/webapp/images/selectall.js Fri Sep 10 16:14:29 2010
@@ -378,6 +378,7 @@ function setLookDescription(textFieldId,
     if (description) {
         var start = description.lastIndexOf(' [');
         if (start != -1) {
+        /* this breaks many existing fields, so commenting for now: assumes main field is the name field and id field is hidden, determines Name/Id fields based on name instead of using description-field-name attribute
             // To allow to set a dependent Id field when using a Name field as a lookup (the fields must have the same prefix, eg: partyName, partyId)
             // It uses the description (Id) shown with the Name. Hence the Lookup screen must be set in order to show a description in the autocomplete part.
             // It seems this is not always easy notably when you need to show at least 2 parts for the Name (eg Person).
@@ -392,9 +393,12 @@ function setLookDescription(textFieldId,
             if ($(dependentId)) {            
                 $(dependentId).value = dependentIdValue;
             }
+         */
             
             description = description.substring(0, start);
+        /*
             $(dependentId).value = description;
+         */
         }
     }
     var lookupWrapperEl = $(textFieldId).up('.field-lookup');