svn:ignore on hot-deploy folder

[Vikas Mayur-3]

Hi,

Does anyone know why svn:ignore is not set to TRUE on hot-deploy folder?

Thanks,
Vikas

[Scott Gray-2]

Hi Vikas

The only reason I can think of is the readme file.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:

> Hi,
>
> Does anyone know why svn:ignore is not set to TRUE on hot-deploy  
> folder?
>
> Thanks,
> Vikas

[Vikas Mayur-3]

Hi Scott,

Thanks for your reply, though it was the easiest one :)

Do you agree that hot-deploy folder should be ignored and readme file  
is moved to under some other directory or even its contents merged  
with README file under root folder, or any other better option?

Vikas

On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:

> Hi Vikas
>
> The only reason I can think of is the readme file.
>
> Regards
> Scott
>
> HotWax Media
> http://www.hotwaxmedia.com
>
> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
>
>> Hi,
>>
>> Does anyone know why svn:ignore is not set to TRUE on hot-deploy  
>> folder?
>>
>> Thanks,
>> Vikas
>

[Jacques Le Roux]

Hi Vikas,

I'd prefer to keep it there. What is your problem with svn:ignore ?

Jacques

From: "Vikas Mayur" <[hidden email]>

> Hi Scott,
>
> Thanks for your reply, though it was the easiest one :)
>
> Do you agree that hot-deploy folder should be ignored and readme file  
> is moved to under some other directory or even its contents merged  
> with README file under root folder, or any other better option?
>
> Vikas
>
> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
>
>> Hi Vikas
>>
>> The only reason I can think of is the readme file.
>>
>> Regards
>> Scott
>>
>> HotWax Media
>> http://www.hotwaxmedia.com
>>
>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
>>
>>> Hi,
>>>
>>> Does anyone know why svn:ignore is not set to TRUE on hot-deploy  
>>> folder?
>>>
>>> Thanks,
>>> Vikas
>>
>

[Hemanth Kumar Kanamarlapudi]

Hi Users,

I am trying to do a quick check out in Ecommerce application and facing the below error when clicking Submit Order after filling the credit card details.


Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [cardType] passed to secure (https) request-map with uri [quickAnonEnterCreditCard] with an event that calls service [createCreditCard]; this is not allowed for security reasons! The data should be encrypted by making it part of the request body (a form field) instead of the request URL. Moreover it would be kind if you could create a Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task for this error does not exist). If you are not sure how to create a Jira issue please have a look before at http://docs.ofbiz.org/x/r. Thank you in advance for your help.


Steps to reproduce:
1.Go to Ecommerce Home Page
2. Select Some items and add to Cart
3. Click Quick Checkout
4. Page goes to Login Page and there also select Quick Chekout
5. Fill User details for quick check out
6. Goes to next page and there select payment type as Credit Card and fill credit card details
7. Select some shipping method type in the same page at right hand menu
8. Click Submit Order button in the same page at the end
9. then getting the above mentioned error.



Thanks & Regards
Hemanth

________________________________
http://www.mindtree.com/email/disclaimer.html

[Jacques Le Roux]

Please create a subTask as indicated in the error message, a patch would be much appreciated...

Jacques

From: "Hemanth Kumar Kanamarlapudi" <[hidden email]>
Hi Users,

I am trying to do a quick check out in Ecommerce application and facing the below error when clicking Submit Order after filling the
credit card details.


Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [cardType] passed to secure (https)
request-map with uri [quickAnonEnterCreditCard] with an event that calls service [createCreditCard]; this is not allowed for
security reasons! The data should be encrypted by making it part of the request body (a form field) instead of the request URL.
Moreover it would be kind if you could create a Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a
sub-task for this error does not exist). If you are not sure how to create a Jira issue please have a look before at
http://docs.ofbiz.org/x/r. Thank you in advance for your help.


Steps to reproduce:
1.Go to Ecommerce Home Page
2. Select Some items and add to Cart
3. Click Quick Checkout
4. Page goes to Login Page and there also select Quick Chekout
5. Fill User details for quick check out
6. Goes to next page and there select payment type as Credit Card and fill credit card details
7. Select some shipping method type in the same page at right hand menu
8. Click Submit Order button in the same page at the end
9. then getting the above mentioned error.



Thanks & Regards
Hemanth

________________________________
http://www.mindtree.com/email/disclaimer.html

[Vikas Mayur-3]

Hi Jacques,

I do not see any problems because I am not a SVN Guru. I was just  
trying to understand why it is not ignored. AFAIK this directory is  
not used for any other purpose other then adding your custom component.

Does only readme file under this directory adds to a good reason of  
not ignoring this?

Vikas

On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote:

> Hi Vikas,
>
> I'd prefer to keep it there. What is your problem with svn:ignore ?
>
> Jacques
>
> From: "Vikas Mayur" <[hidden email]>
>> Hi Scott,
>> Thanks for your reply, though it was the easiest one :)
>> Do you agree that hot-deploy folder should be ignored and readme  
>> file  is moved to under some other directory or even its contents  
>> merged  with README file under root folder, or any other better  
>> option?
>> Vikas
>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
>>> Hi Vikas
>>>
>>> The only reason I can think of is the readme file.
>>>
>>> Regards
>>> Scott
>>>
>>> HotWax Media
>>> http://www.hotwaxmedia.com
>>>
>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
>>>
>>>> Hi,
>>>>
>>>> Does anyone know why svn:ignore is not set to TRUE on hot-deploy  
>>>> folder?
>>>>
>>>> Thanks,
>>>> Vikas
>>>
>>
>

[Jacques Le Roux]

Hi Vikas,

From: "Vikas Mayur" <[hidden email]>
> Hi Jacques,
>
> I do not see any problems because I am not a SVN Guru. I was just  
> trying to understand why it is not ignored. AFAIK this directory is  
> not used for any other purpose other then adding your custom component.
>
> Does only readme file under this directory adds to a good reason of  
> not ignoring this?

If nobody has any problems with it I would say, yes keep it as is. Other opininons ?

Jacques
 

> Vikas
>
> On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote:
>
>> Hi Vikas,
>>
>> I'd prefer to keep it there. What is your problem with svn:ignore ?
>>
>> Jacques
>>
>> From: "Vikas Mayur" <[hidden email]>
>>> Hi Scott,
>>> Thanks for your reply, though it was the easiest one :)
>>> Do you agree that hot-deploy folder should be ignored and readme  
>>> file  is moved to under some other directory or even its contents  
>>> merged  with README file under root folder, or any other better  
>>> option?
>>> Vikas
>>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
>>>> Hi Vikas
>>>>
>>>> The only reason I can think of is the readme file.
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> HotWax Media
>>>> http://www.hotwaxmedia.com
>>>>
>>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Does anyone know why svn:ignore is not set to TRUE on hot-deploy  
>>>>> folder?
>>>>>
>>>>> Thanks,
>>>>> Vikas
>>>>
>>>
>>
>

[Scott Gray-2]

I guess what Vikas hasn't explained is the reason why he wants the hot-
deploy folder's contents to be ignored.

The answer to that I guess is fairly obvious, the hot-deploy folder is  
a place to put custom applications and code and when you put code in  
there svn treats it as a change to the OFBiz svn.  The is a constant  
risk of accidentally committing an entire body of custom work to the  
OFBiz repo.

Is that your reason for bringing it up Vikas?  I have to admit I have  
performed many nervous commits with the fear that my work is going to  
the wrong repository.

Regards
Scott

On 9/09/2009, at 9:11 PM, Jacques Le Roux wrote:

> Hi Vikas,
>
> From: "Vikas Mayur" <[hidden email]>
>> Hi Jacques,
>> I do not see any problems because I am not a SVN Guru. I was just  
>> trying to understand why it is not ignored. AFAIK this directory  
>> is  not used for any other purpose other then adding your custom  
>> component.
>> Does only readme file under this directory adds to a good reason  
>> of  not ignoring this?
>
> If nobody has any problems with it I would say, yes keep it as is.  
> Other opininons ?
>
> Jacques
>> Vikas
>> On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote:
>>> Hi Vikas,
>>>
>>> I'd prefer to keep it there. What is your problem with svn:ignore ?
>>>
>>> Jacques
>>>
>>> From: "Vikas Mayur" <[hidden email]>
>>>> Hi Scott,
>>>> Thanks for your reply, though it was the easiest one :)
>>>> Do you agree that hot-deploy folder should be ignored and readme  
>>>> file  is moved to under some other directory or even its  
>>>> contents  merged  with README file under root folder, or any  
>>>> other better  option?
>>>> Vikas
>>>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
>>>>> Hi Vikas
>>>>>
>>>>> The only reason I can think of is the readme file.
>>>>>
>>>>> Regards
>>>>> Scott
>>>>>
>>>>> HotWax Media
>>>>> http://www.hotwaxmedia.com
>>>>>
>>>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Does anyone know why svn:ignore is not set to TRUE on hot-
>>>>>> deploy   folder?
>>>>>>
>>>>>> Thanks,
>>>>>> Vikas
>>>>>
>>>>
>>>
>>
>

[Jacques Le Roux]

That's a good reason indeed, thansk Scott, other opininons ?

Acutally I have not this problem as I use mostly Tortoise for commit and its super-hyper-cool Changelist feature
http://tortoisesvn.tigris.org/tsvn_1.5_releasenotes.html#changelist-support

<troll-mode>
    Forgot : it's only on the worse OS available, too bad ;o)
</troll-mode>

Jacques

From: "Scott Gray" <[hidden email]>

>I guess what Vikas hasn't explained is the reason why he wants the hot-
> deploy folder's contents to be ignored.
>
> The answer to that I guess is fairly obvious, the hot-deploy folder is  
> a place to put custom applications and code and when you put code in  
> there svn treats it as a change to the OFBiz svn.  The is a constant  
> risk of accidentally committing an entire body of custom work to the  
> OFBiz repo.
>
> Is that your reason for bringing it up Vikas?  I have to admit I have  
> performed many nervous commits with the fear that my work is going to  
> the wrong repository.
>
> Regards
> Scott
>
> On 9/09/2009, at 9:11 PM, Jacques Le Roux wrote:
>
>> Hi Vikas,
>>
>> From: "Vikas Mayur" <[hidden email]>
>>> Hi Jacques,
>>> I do not see any problems because I am not a SVN Guru. I was just  
>>> trying to understand why it is not ignored. AFAIK this directory  
>>> is  not used for any other purpose other then adding your custom  
>>> component.
>>> Does only readme file under this directory adds to a good reason  
>>> of  not ignoring this?
>>
>> If nobody has any problems with it I would say, yes keep it as is.  
>> Other opininons ?
>>
>> Jacques
>>> Vikas
>>> On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote:
>>>> Hi Vikas,
>>>>
>>>> I'd prefer to keep it there. What is your problem with svn:ignore ?
>>>>
>>>> Jacques
>>>>
>>>> From: "Vikas Mayur" <[hidden email]>
>>>>> Hi Scott,
>>>>> Thanks for your reply, though it was the easiest one :)
>>>>> Do you agree that hot-deploy folder should be ignored and readme  
>>>>> file  is moved to under some other directory or even its  
>>>>> contents  merged  with README file under root folder, or any  
>>>>> other better  option?
>>>>> Vikas
>>>>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
>>>>>> Hi Vikas
>>>>>>
>>>>>> The only reason I can think of is the readme file.
>>>>>>
>>>>>> Regards
>>>>>> Scott
>>>>>>
>>>>>> HotWax Media
>>>>>> http://www.hotwaxmedia.com
>>>>>>
>>>>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Does anyone know why svn:ignore is not set to TRUE on hot-
>>>>>>> deploy   folder?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Vikas
>>>>>>
>>>>>
>>>>
>>>
>>
>
>

[Scott Gray-2]

By the way if you want an example of how to fix the problem (in case  
you decide to submit a patch) you can look at r811817

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 9/09/2009, at 2:07 AM, Jacques Le Roux wrote:

> Please create a subTask as indicated in the error message, a patch  
> would be much appreciated...
>
> Jacques
>
> From: "Hemanth Kumar Kanamarlapudi" <[hidden email]
> >
> Hi Users,
>
> I am trying to do a quick check out in Ecommerce application and  
> facing the below error when clicking Submit Order after filling the  
> credit card details.
>
>
> Error calling event: org.ofbiz.webapp.event.EventHandlerException:  
> Found URL parameter [cardType] passed to secure (https) request-map  
> with uri [quickAnonEnterCreditCard] with an event that calls service  
> [createCreditCard]; this is not allowed for security reasons! The  
> data should be encrypted by making it part of the request body (a  
> form field) instead of the request URL. Moreover it would be kind if  
> you could create a Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 
>  (check before if a sub-task for this error does not exist). If you  
> are not sure how to create a Jira issue please have a look before at http://docs.ofbiz.org/x/r 
> . Thank you in advance for your help.
>
>
> Steps to reproduce:
> 1.Go to Ecommerce Home Page
> 2. Select Some items and add to Cart
> 3. Click Quick Checkout
> 4. Page goes to Login Page and there also select Quick Chekout
> 5. Fill User details for quick check out
> 6. Goes to next page and there select payment type as Credit Card  
> and fill credit card details
> 7. Select some shipping method type in the same page at right hand  
> menu
> 8. Click Submit Order button in the same page at the end
> 9. then getting the above mentioned error.
>
>
>
> Thanks & Regards
> Hemanth
>
> ________________________________
> http://www.mindtree.com/email/disclaimer.html
>
>

[Vikas Mayur-3]

Hi Scott,

Thanks for the stating this clearly (I see now that I haven't proposed  
enough reason(s) to support my question) and yes I have the same  
feeling of committing custom code accidently.

Most of the time I also have a tar file of the custom component under  
hot-deploy directory, as instead taking a fresh checkout for a  
component (which contains images in GB) I prefer to take archive file

from someone who already have a checkout.

Though to commit something from hot-deploy, the custom component or  
file need to added to version control first. This is obviously a first  
check.

I tried to add the custom component to version control but since my  
custom component is also version controlled, it denied to add this  
again to hot-deploy so this was safe.

But what if custom work/component is not under version control, there  
are still chances of errors and code being accidently committed to  
trunk.

I think this reason should be enough to ignore the hot-deploy folder.

Vikas

On Sep 9, 2009, at 2:59 PM, Scott Gray wrote:

> I guess what Vikas hasn't explained is the reason why he wants the  
> hot-deploy folder's contents to be ignored.
>
> The answer to that I guess is fairly obvious, the hot-deploy folder  
> is a place to put custom applications and code and when you put code  
> in there svn treats it as a change to the OFBiz svn.  The is a  
> constant risk of accidentally committing an entire body of custom  
> work to the OFBiz repo.
>
> Is that your reason for bringing it up Vikas?  I have to admit I  
> have performed many nervous commits with the fear that my work is  
> going to the wrong repository.
>
> Regards
> Scott
>
> On 9/09/2009, at 9:11 PM, Jacques Le Roux wrote:
>
>> Hi Vikas,
>>
>> From: "Vikas Mayur" <[hidden email]>
>>> Hi Jacques,
>>> I do not see any problems because I am not a SVN Guru. I was just  
>>> trying to understand why it is not ignored. AFAIK this directory  
>>> is  not used for any other purpose other then adding your custom  
>>> component.
>>> Does only readme file under this directory adds to a good reason  
>>> of  not ignoring this?
>>
>> If nobody has any problems with it I would say, yes keep it as is.  
>> Other opininons ?
>>
>> Jacques
>>> Vikas
>>> On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote:
>>>> Hi Vikas,
>>>>
>>>> I'd prefer to keep it there. What is your problem with svn:ignore ?
>>>>
>>>> Jacques
>>>>
>>>> From: "Vikas Mayur" <[hidden email]>
>>>>> Hi Scott,
>>>>> Thanks for your reply, though it was the easiest one :)
>>>>> Do you agree that hot-deploy folder should be ignored and  
>>>>> readme  file  is moved to under some other directory or even its  
>>>>> contents  merged  with README file under root folder, or any  
>>>>> other better  option?
>>>>> Vikas
>>>>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
>>>>>> Hi Vikas
>>>>>>
>>>>>> The only reason I can think of is the readme file.
>>>>>>
>>>>>> Regards
>>>>>> Scott
>>>>>>
>>>>>> HotWax Media
>>>>>> http://www.hotwaxmedia.com
>>>>>>
>>>>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Does anyone know why svn:ignore is not set to TRUE on hot-
>>>>>>> deploy   folder?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Vikas
>>>>>>
>>>>>
>>>>
>>>
>>
>

[Jacques Le Roux]

From: "Vikas Mayur" <[hidden email]>

> Hi Scott,
>
> Thanks for the stating this clearly (I see now that I haven't proposed  
> enough reason(s) to support my question) and yes I have the same  
> feeling of committing custom code accidently.
>
> Most of the time I also have a tar file of the custom component under  
> hot-deploy directory, as instead taking a fresh checkout for a  
> component (which contains images in GB) I prefer to take archive file
>
> from someone who already have a checkout.
>
> Though to commit something from hot-deploy, the custom component or  
> file need to added to version control first. This is obviously a first  
> check.
>
> I tried to add the custom component to version control but since my  
> custom component is also version controlled, it denied to add this  
> again to hot-deploy so this was safe.
>
> But what if custom work/component is not under version control, there  
> are still chances of errors and code being accidently committed to  
> trunk.
>
> I think this reason should be enough to ignore the hot-deploy folder.

Yes, it's a pretty good argument

Jacques
 

> Vikas
>
> On Sep 9, 2009, at 2:59 PM, Scott Gray wrote:
>
>> I guess what Vikas hasn't explained is the reason why he wants the  
>> hot-deploy folder's contents to be ignored.
>>
>> The answer to that I guess is fairly obvious, the hot-deploy folder  
>> is a place to put custom applications and code and when you put code  
>> in there svn treats it as a change to the OFBiz svn.  The is a  
>> constant risk of accidentally committing an entire body of custom  
>> work to the OFBiz repo.
>>
>> Is that your reason for bringing it up Vikas?  I have to admit I  
>> have performed many nervous commits with the fear that my work is  
>> going to the wrong repository.
>>
>> Regards
>> Scott
>>
>> On 9/09/2009, at 9:11 PM, Jacques Le Roux wrote:
>>
>>> Hi Vikas,
>>>
>>> From: "Vikas Mayur" <[hidden email]>
>>>> Hi Jacques,
>>>> I do not see any problems because I am not a SVN Guru. I was just  
>>>> trying to understand why it is not ignored. AFAIK this directory  
>>>> is  not used for any other purpose other then adding your custom  
>>>> component.
>>>> Does only readme file under this directory adds to a good reason  
>>>> of  not ignoring this?
>>>
>>> If nobody has any problems with it I would say, yes keep it as is.  
>>> Other opininons ?
>>>
>>> Jacques
>>>> Vikas
>>>> On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote:
>>>>> Hi Vikas,
>>>>>
>>>>> I'd prefer to keep it there. What is your problem with svn:ignore ?
>>>>>
>>>>> Jacques
>>>>>
>>>>> From: "Vikas Mayur" <[hidden email]>
>>>>>> Hi Scott,
>>>>>> Thanks for your reply, though it was the easiest one :)
>>>>>> Do you agree that hot-deploy folder should be ignored and  
>>>>>> readme  file  is moved to under some other directory or even its  
>>>>>> contents  merged  with README file under root folder, or any  
>>>>>> other better  option?
>>>>>> Vikas
>>>>>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
>>>>>>> Hi Vikas
>>>>>>>
>>>>>>> The only reason I can think of is the readme file.
>>>>>>>
>>>>>>> Regards
>>>>>>> Scott
>>>>>>>
>>>>>>> HotWax Media
>>>>>>> http://www.hotwaxmedia.com
>>>>>>>
>>>>>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Does anyone know why svn:ignore is not set to TRUE on hot-
>>>>>>>> deploy   folder?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Vikas
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

[Ashish Vijaywargiya]

+1 for adding svn:ignore on hot-deploy folder and moving readme.txt file
somewhere else.

+ive vote for this change: 4 - Vikas, Scott, Jacques (Probably? ;o) ),
Ashish.
-ive vote for this change: 0

Althought I would wait for expert comment on this before we do it on trunk.

--
Ashish

On Wed, Sep 9, 2009 at 4:07 PM, Vikas Mayur <[hidden email]>wrote:

> Hi Scott,
>
> Thanks for the stating this clearly (I see now that I haven't proposed
> enough reason(s) to support my question) and yes I have the same feeling of
> committing custom code accidently.
>
> Most of the time I also have a tar file of the custom component under
> hot-deploy directory, as instead taking a fresh checkout for a component
> (which contains images in GB) I prefer to take archive file
>
> from someone who already have a checkout.
>
> Though to commit something from hot-deploy, the custom component or file
> need to added to version control first. This is obviously a first check.
>
> I tried to add the custom component to version control but since my custom
> component is also version controlled, it denied to add this again to
> hot-deploy so this was safe.
>
> But what if custom work/component is not under version control, there are
> still chances of errors and code being accidently committed to trunk.
>
> I think this reason should be enough to ignore the hot-deploy folder.
>
> Vikas
>
>
> On Sep 9, 2009, at 2:59 PM, Scott Gray wrote:
>
>  I guess what Vikas hasn't explained is the reason why he wants the
>> hot-deploy folder's contents to be ignored.
>>
>> The answer to that I guess is fairly obvious, the hot-deploy folder is a
>> place to put custom applications and code and when you put code in there svn
>> treats it as a change to the OFBiz svn.  The is a constant risk of
>> accidentally committing an entire body of custom work to the OFBiz repo.
>>
>> Is that your reason for bringing it up Vikas?  I have to admit I have
>> performed many nervous commits with the fear that my work is going to the
>> wrong repository.
>>
>> Regards
>> Scott
>>
>> On 9/09/2009, at 9:11 PM, Jacques Le Roux wrote:
>>
>>  Hi Vikas,
>>>
>>> From: "Vikas Mayur" <[hidden email]>
>>>
>>>> Hi Jacques,
>>>> I do not see any problems because I am not a SVN Guru. I was just
>>>>  trying to understand why it is not ignored. AFAIK this directory is  not
>>>> used for any other purpose other then adding your custom component.
>>>> Does only readme file under this directory adds to a good reason of  not
>>>> ignoring this?
>>>>
>>>
>>> If nobody has any problems with it I would say, yes keep it as is. Other
>>> opininons ?
>>>
>>> Jacques
>>>
>>>> Vikas
>>>> On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote:
>>>>
>>>>> Hi Vikas,
>>>>>
>>>>> I'd prefer to keep it there. What is your problem with svn:ignore ?
>>>>>
>>>>> Jacques
>>>>>
>>>>> From: "Vikas Mayur" <[hidden email]>
>>>>>
>>>>>> Hi Scott,
>>>>>> Thanks for your reply, though it was the easiest one :)
>>>>>> Do you agree that hot-deploy folder should be ignored and readme  file
>>>>>>  is moved to under some other directory or even its contents  merged  with
>>>>>> README file under root folder, or any other better  option?
>>>>>> Vikas
>>>>>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
>>>>>>
>>>>>>> Hi Vikas
>>>>>>>
>>>>>>> The only reason I can think of is the readme file.
>>>>>>>
>>>>>>> Regards
>>>>>>> Scott
>>>>>>>
>>>>>>> HotWax Media
>>>>>>> http://www.hotwaxmedia.com
>>>>>>>
>>>>>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
>>>>>>>
>>>>>>>  Hi,
>>>>>>>>
>>>>>>>> Does anyone know why svn:ignore is not set to TRUE on hot-deploy
>>>>>>>> folder?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Vikas
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

[Abdullah Shaikh-3]

Just FYI, I dont know if this makes sense for this conversation. We have a
separate svn path for ofbiz and custom component, what I do is create a
symbolic link of my custom component into hot-deploy folder, this way there
are no issues of a code being committed to ofbiz because ofbiz & custom
component are into separate folders.


On Wed, Sep 9, 2009 at 4:07 PM, Vikas Mayur <[hidden email]>wrote:

> Hi Scott,
>
> Thanks for the stating this clearly (I see now that I haven't proposed
> enough reason(s) to support my question) and yes I have the same feeling of
> committing custom code accidently.
>
> Most of the time I also have a tar file of the custom component under
> hot-deploy directory, as instead taking a fresh checkout for a component
> (which contains images in GB) I prefer to take archive file
>
> from someone who already have a checkout.
>
> Though to commit something from hot-deploy, the custom component or file
> need to added to version control first. This is obviously a first check.
>
> I tried to add the custom component to version control but since my custom
> component is also version controlled, it denied to add this again to
> hot-deploy so this was safe.
>
> But what if custom work/component is not under version control, there are
> still chances of errors and code being accidently committed to trunk.
>
> I think this reason should be enough to ignore the hot-deploy folder.
>
> Vikas
>
>
> On Sep 9, 2009, at 2:59 PM, Scott Gray wrote:
>
>  I guess what Vikas hasn't explained is the reason why he wants the
>> hot-deploy folder's contents to be ignored.
>>
>> The answer to that I guess is fairly obvious, the hot-deploy folder is a
>> place to put custom applications and code and when you put code in there svn
>> treats it as a change to the OFBiz svn.  The is a constant risk of
>> accidentally committing an entire body of custom work to the OFBiz repo.
>>
>> Is that your reason for bringing it up Vikas?  I have to admit I have
>> performed many nervous commits with the fear that my work is going to the
>> wrong repository.
>>
>> Regards
>> Scott
>>
>> On 9/09/2009, at 9:11 PM, Jacques Le Roux wrote:
>>
>>  Hi Vikas,
>>>
>>> From: "Vikas Mayur" <[hidden email]>
>>>
>>>> Hi Jacques,
>>>> I do not see any problems because I am not a SVN Guru. I was just
>>>>  trying to understand why it is not ignored. AFAIK this directory is  not
>>>> used for any other purpose other then adding your custom component.
>>>> Does only readme file under this directory adds to a good reason of  not
>>>> ignoring this?
>>>>
>>>
>>> If nobody has any problems with it I would say, yes keep it as is. Other
>>> opininons ?
>>>
>>> Jacques
>>>
>>>> Vikas
>>>> On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote:
>>>>
>>>>> Hi Vikas,
>>>>>
>>>>> I'd prefer to keep it there. What is your problem with svn:ignore ?
>>>>>
>>>>> Jacques
>>>>>
>>>>> From: "Vikas Mayur" <[hidden email]>
>>>>>
>>>>>> Hi Scott,
>>>>>> Thanks for your reply, though it was the easiest one :)
>>>>>> Do you agree that hot-deploy folder should be ignored and readme  file
>>>>>>  is moved to under some other directory or even its contents  merged  with
>>>>>> README file under root folder, or any other better  option?
>>>>>> Vikas
>>>>>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
>>>>>>
>>>>>>> Hi Vikas
>>>>>>>
>>>>>>> The only reason I can think of is the readme file.
>>>>>>>
>>>>>>> Regards
>>>>>>> Scott
>>>>>>>
>>>>>>> HotWax Media
>>>>>>> http://www.hotwaxmedia.com
>>>>>>>
>>>>>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
>>>>>>>
>>>>>>>  Hi,
>>>>>>>>
>>>>>>>> Does anyone know why svn:ignore is not set to TRUE on hot-deploy
>>>>>>>> folder?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Vikas
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

[Ashish Vijaywargiya]

You have missed one important point.
What would be the case if we have files in hot-deploy directory that is not
associated with any version control system?

Anyone can accidentally commit those files.

--
Ashish

On Wed, Sep 9, 2009 at 5:12 PM, Abdullah Shaikh <
[hidden email]> wrote:

> Just FYI, I dont know if this makes sense for this conversation. We have a
> separate svn path for ofbiz and custom component, what I do is create a
> symbolic link of my custom component into hot-deploy folder, this way there
> are no issues of a code being committed to ofbiz because ofbiz & custom
> component are into separate folders.
>
>
> On Wed, Sep 9, 2009 at 4:07 PM, Vikas Mayur <[hidden email]
> >wrote:
>
> > Hi Scott,
> >
> > Thanks for the stating this clearly (I see now that I haven't proposed
> > enough reason(s) to support my question) and yes I have the same feeling
> of
> > committing custom code accidently.
> >
> > Most of the time I also have a tar file of the custom component under
> > hot-deploy directory, as instead taking a fresh checkout for a component
> > (which contains images in GB) I prefer to take archive file
> >
> > from someone who already have a checkout.
> >
> > Though to commit something from hot-deploy, the custom component or file
> > need to added to version control first. This is obviously a first check.
> >
> > I tried to add the custom component to version control but since my
> custom
> > component is also version controlled, it denied to add this again to
> > hot-deploy so this was safe.
> >
> > But what if custom work/component is not under version control, there are
> > still chances of errors and code being accidently committed to trunk.
> >
> > I think this reason should be enough to ignore the hot-deploy folder.
> >
> > Vikas
> >
> >
> > On Sep 9, 2009, at 2:59 PM, Scott Gray wrote:
> >
> >  I guess what Vikas hasn't explained is the reason why he wants the
> >> hot-deploy folder's contents to be ignored.
> >>
> >> The answer to that I guess is fairly obvious, the hot-deploy folder is a
> >> place to put custom applications and code and when you put code in there
> svn
> >> treats it as a change to the OFBiz svn.  The is a constant risk of
> >> accidentally committing an entire body of custom work to the OFBiz repo.
> >>
> >> Is that your reason for bringing it up Vikas?  I have to admit I have
> >> performed many nervous commits with the fear that my work is going to
> the
> >> wrong repository.
> >>
> >> Regards
> >> Scott
> >>
> >> On 9/09/2009, at 9:11 PM, Jacques Le Roux wrote:
> >>
> >>  Hi Vikas,
> >>>
> >>> From: "Vikas Mayur" <[hidden email]>
> >>>
> >>>> Hi Jacques,
> >>>> I do not see any problems because I am not a SVN Guru. I was just
> >>>>  trying to understand why it is not ignored. AFAIK this directory is
>  not
> >>>> used for any other purpose other then adding your custom component.
> >>>> Does only readme file under this directory adds to a good reason of
>  not
> >>>> ignoring this?
> >>>>
> >>>
> >>> If nobody has any problems with it I would say, yes keep it as is.
> Other
> >>> opininons ?
> >>>
> >>> Jacques
> >>>
> >>>> Vikas
> >>>> On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote:
> >>>>
> >>>>> Hi Vikas,
> >>>>>
> >>>>> I'd prefer to keep it there. What is your problem with svn:ignore ?
> >>>>>
> >>>>> Jacques
> >>>>>
> >>>>> From: "Vikas Mayur" <[hidden email]>
> >>>>>
> >>>>>> Hi Scott,
> >>>>>> Thanks for your reply, though it was the easiest one :)
> >>>>>> Do you agree that hot-deploy folder should be ignored and readme
>  file
> >>>>>>  is moved to under some other directory or even its contents  merged
>  with
> >>>>>> README file under root folder, or any other better  option?
> >>>>>> Vikas
> >>>>>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
> >>>>>>
> >>>>>>> Hi Vikas
> >>>>>>>
> >>>>>>> The only reason I can think of is the readme file.
> >>>>>>>
> >>>>>>> Regards
> >>>>>>> Scott
> >>>>>>>
> >>>>>>> HotWax Media
> >>>>>>> http://www.hotwaxmedia.com
> >>>>>>>
> >>>>>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
> >>>>>>>
> >>>>>>>  Hi,
> >>>>>>>>
> >>>>>>>> Does anyone know why svn:ignore is not set to TRUE on hot-deploy
> >>>>>>>> folder?
> >>>>>>>>
> >>>>>>>> Thanks,
> >>>>>>>> Vikas
> >>>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>
> >>
> >
>

[Abdullah Shaikh-3]

Yes you are right .. but in my case its not a problem as we don't put any
files into hot-deploy, but only the symbolic link, but here again symbolic
link is also a file, but then we don't commit code to ofbiz svn but always
customise it into our custom component.

But for people who commits to ofbiz, this will be a good change, I guess.

+1 from my side .. :)

On Wed, Sep 9, 2009 at 5:33 PM, Ashish Vijaywargiya <
[hidden email]> wrote:

> You have missed one important point.
> What would be the case if we have files in hot-deploy directory that is not
> associated with any version control system?
>
> Anyone can accidentally commit those files.
>
> --
> Ashish
>
> On Wed, Sep 9, 2009 at 5:12 PM, Abdullah Shaikh <
> [hidden email]> wrote:
>
> > Just FYI, I dont know if this makes sense for this conversation. We have
> a
> > separate svn path for ofbiz and custom component, what I do is create a
> > symbolic link of my custom component into hot-deploy folder, this way
> there
> > are no issues of a code being committed to ofbiz because ofbiz & custom
> > component are into separate folders.
> >
> >
> > On Wed, Sep 9, 2009 at 4:07 PM, Vikas Mayur <[hidden email]
> > >wrote:
> >
> > > Hi Scott,
> > >
> > > Thanks for the stating this clearly (I see now that I haven't proposed
> > > enough reason(s) to support my question) and yes I have the same
> feeling
> > of
> > > committing custom code accidently.
> > >
> > > Most of the time I also have a tar file of the custom component under
> > > hot-deploy directory, as instead taking a fresh checkout for a
> component
> > > (which contains images in GB) I prefer to take archive file
> > >
> > > from someone who already have a checkout.
> > >
> > > Though to commit something from hot-deploy, the custom component or
> file
> > > need to added to version control first. This is obviously a first
> check.
> > >
> > > I tried to add the custom component to version control but since my
> > custom
> > > component is also version controlled, it denied to add this again to
> > > hot-deploy so this was safe.
> > >
> > > But what if custom work/component is not under version control, there
> are
> > > still chances of errors and code being accidently committed to trunk.
> > >
> > > I think this reason should be enough to ignore the hot-deploy folder.
> > >
> > > Vikas
> > >
> > >
> > > On Sep 9, 2009, at 2:59 PM, Scott Gray wrote:
> > >
> > >  I guess what Vikas hasn't explained is the reason why he wants the
> > >> hot-deploy folder's contents to be ignored.
> > >>
> > >> The answer to that I guess is fairly obvious, the hot-deploy folder is
> a
> > >> place to put custom applications and code and when you put code in
> there
> > svn
> > >> treats it as a change to the OFBiz svn.  The is a constant risk of
> > >> accidentally committing an entire body of custom work to the OFBiz
> repo.
> > >>
> > >> Is that your reason for bringing it up Vikas?  I have to admit I have
> > >> performed many nervous commits with the fear that my work is going to
> > the
> > >> wrong repository.
> > >>
> > >> Regards
> > >> Scott
> > >>
> > >> On 9/09/2009, at 9:11 PM, Jacques Le Roux wrote:
> > >>
> > >>  Hi Vikas,
> > >>>
> > >>> From: "Vikas Mayur" <[hidden email]>
> > >>>
> > >>>> Hi Jacques,
> > >>>> I do not see any problems because I am not a SVN Guru. I was just
> > >>>>  trying to understand why it is not ignored. AFAIK this directory is
> >  not
> > >>>> used for any other purpose other then adding your custom component.
> > >>>> Does only readme file under this directory adds to a good reason of
> >  not
> > >>>> ignoring this?
> > >>>>
> > >>>
> > >>> If nobody has any problems with it I would say, yes keep it as is.
> > Other
> > >>> opininons ?
> > >>>
> > >>> Jacques
> > >>>
> > >>>> Vikas
> > >>>> On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote:
> > >>>>
> > >>>>> Hi Vikas,
> > >>>>>
> > >>>>> I'd prefer to keep it there. What is your problem with svn:ignore ?
> > >>>>>
> > >>>>> Jacques
> > >>>>>
> > >>>>> From: "Vikas Mayur" <[hidden email]>
> > >>>>>
> > >>>>>> Hi Scott,
> > >>>>>> Thanks for your reply, though it was the easiest one :)
> > >>>>>> Do you agree that hot-deploy folder should be ignored and readme
> >  file
> > >>>>>>  is moved to under some other directory or even its contents
>  merged
> >  with
> > >>>>>> README file under root folder, or any other better  option?
> > >>>>>> Vikas
> > >>>>>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
> > >>>>>>
> > >>>>>>> Hi Vikas
> > >>>>>>>
> > >>>>>>> The only reason I can think of is the readme file.
> > >>>>>>>
> > >>>>>>> Regards
> > >>>>>>> Scott
> > >>>>>>>
> > >>>>>>> HotWax Media
> > >>>>>>> http://www.hotwaxmedia.com
> > >>>>>>>
> > >>>>>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
> > >>>>>>>
> > >>>>>>>  Hi,
> > >>>>>>>>
> > >>>>>>>> Does anyone know why svn:ignore is not set to TRUE on hot-deploy
> > >>>>>>>> folder?
> > >>>>>>>>
> > >>>>>>>> Thanks,
> > >>>>>>>> Vikas
> > >>>>>>>>
> > >>>>>>>
> > >>>>>>>
> > >>>>>>
> > >>>>>
> > >>>>
> > >>>
> > >>
> > >
> >
>

[Jacques Le Roux]

From: "Ashish Vijaywargiya" <[hidden email]>
> +1 for adding svn:ignore on hot-deploy folder and moving readme.txt file
> somewhere else.

I just had a look : hot-deploy folder has already svn:ignore in its properties

So I don't understand what change is really required, svn:ignore on the README file ?

Jacques

>
> +ive vote for this change: 4 - Vikas, Scott, Jacques (Probably? ;o) ),
> Ashish.
> -ive vote for this change: 0
>
> Althought I would wait for expert comment on this before we do it on trunk.
>
> --
> Ashish
>
> On Wed, Sep 9, 2009 at 4:07 PM, Vikas Mayur <[hidden email]>wrote:
>
>> Hi Scott,
>>
>> Thanks for the stating this clearly (I see now that I haven't proposed
>> enough reason(s) to support my question) and yes I have the same feeling of
>> committing custom code accidently.
>>
>> Most of the time I also have a tar file of the custom component under
>> hot-deploy directory, as instead taking a fresh checkout for a component
>> (which contains images in GB) I prefer to take archive file
>>
>> from someone who already have a checkout.
>>
>> Though to commit something from hot-deploy, the custom component or file
>> need to added to version control first. This is obviously a first check.
>>
>> I tried to add the custom component to version control but since my custom
>> component is also version controlled, it denied to add this again to
>> hot-deploy so this was safe.
>>
>> But what if custom work/component is not under version control, there are
>> still chances of errors and code being accidently committed to trunk.
>>
>> I think this reason should be enough to ignore the hot-deploy folder.
>>
>> Vikas
>>
>>
>> On Sep 9, 2009, at 2:59 PM, Scott Gray wrote:
>>
>>  I guess what Vikas hasn't explained is the reason why he wants the
>>> hot-deploy folder's contents to be ignored.
>>>
>>> The answer to that I guess is fairly obvious, the hot-deploy folder is a
>>> place to put custom applications and code and when you put code in there svn
>>> treats it as a change to the OFBiz svn.  The is a constant risk of
>>> accidentally committing an entire body of custom work to the OFBiz repo.
>>>
>>> Is that your reason for bringing it up Vikas?  I have to admit I have
>>> performed many nervous commits with the fear that my work is going to the
>>> wrong repository.
>>>
>>> Regards
>>> Scott
>>>
>>> On 9/09/2009, at 9:11 PM, Jacques Le Roux wrote:
>>>
>>>  Hi Vikas,
>>>>
>>>> From: "Vikas Mayur" <[hidden email]>
>>>>
>>>>> Hi Jacques,
>>>>> I do not see any problems because I am not a SVN Guru. I was just
>>>>>  trying to understand why it is not ignored. AFAIK this directory is  not
>>>>> used for any other purpose other then adding your custom component.
>>>>> Does only readme file under this directory adds to a good reason of  not
>>>>> ignoring this?
>>>>>
>>>>
>>>> If nobody has any problems with it I would say, yes keep it as is. Other
>>>> opininons ?
>>>>
>>>> Jacques
>>>>
>>>>> Vikas
>>>>> On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote:
>>>>>
>>>>>> Hi Vikas,
>>>>>>
>>>>>> I'd prefer to keep it there. What is your problem with svn:ignore ?
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> From: "Vikas Mayur" <[hidden email]>
>>>>>>
>>>>>>> Hi Scott,
>>>>>>> Thanks for your reply, though it was the easiest one :)
>>>>>>> Do you agree that hot-deploy folder should be ignored and readme  file
>>>>>>>  is moved to under some other directory or even its contents  merged  with
>>>>>>> README file under root folder, or any other better  option?
>>>>>>> Vikas
>>>>>>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
>>>>>>>
>>>>>>>> Hi Vikas
>>>>>>>>
>>>>>>>> The only reason I can think of is the readme file.
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> Scott
>>>>>>>>
>>>>>>>> HotWax Media
>>>>>>>> http://www.hotwaxmedia.com
>>>>>>>>
>>>>>>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
>>>>>>>>
>>>>>>>>  Hi,
>>>>>>>>>
>>>>>>>>> Does anyone know why svn:ignore is not set to TRUE on hot-deploy
>>>>>>>>> folder?
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Vikas
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

[Scott Gray-2]

There are no values assigned to the property so it isn't actually  
doing anything.

Regards
Scott

On 10/09/2009, at 1:07 AM, Jacques Le Roux wrote:

> From: "Ashish Vijaywargiya" <[hidden email]>
>> +1 for adding svn:ignore on hot-deploy folder and moving readme.txt  
>> file
>> somewhere else.
>
> I just had a look : hot-deploy folder has already svn:ignore in its  
> properties
>
> So I don't understand what change is really required, svn:ignore on  
> the README file ?
>
> Jacques
>
>> +ive vote for this change: 4 - Vikas, Scott, Jacques  
>> (Probably? ;o) ),
>> Ashish.
>> -ive vote for this change: 0
>> Althought I would wait for expert comment on this before we do it  
>> on trunk.
>> --
>> Ashish
>> On Wed, Sep 9, 2009 at 4:07 PM, Vikas Mayur <[hidden email]
>> >wrote:
>>> Hi Scott,
>>>
>>> Thanks for the stating this clearly (I see now that I haven't  
>>> proposed
>>> enough reason(s) to support my question) and yes I have the same  
>>> feeling of
>>> committing custom code accidently.
>>>
>>> Most of the time I also have a tar file of the custom component  
>>> under
>>> hot-deploy directory, as instead taking a fresh checkout for a  
>>> component
>>> (which contains images in GB) I prefer to take archive file
>>>
>>> from someone who already have a checkout.
>>>
>>> Though to commit something from hot-deploy, the custom component  
>>> or file
>>> need to added to version control first. This is obviously a first  
>>> check.
>>>
>>> I tried to add the custom component to version control but since  
>>> my custom
>>> component is also version controlled, it denied to add this again to
>>> hot-deploy so this was safe.
>>>
>>> But what if custom work/component is not under version control,  
>>> there are
>>> still chances of errors and code being accidently committed to  
>>> trunk.
>>>
>>> I think this reason should be enough to ignore the hot-deploy  
>>> folder.
>>>
>>> Vikas
>>>
>>>
>>> On Sep 9, 2009, at 2:59 PM, Scott Gray wrote:
>>>
>>> I guess what Vikas hasn't explained is the reason why he wants the
>>>> hot-deploy folder's contents to be ignored.
>>>>
>>>> The answer to that I guess is fairly obvious, the hot-deploy  
>>>> folder is a
>>>> place to put custom applications and code and when you put code  
>>>> in there svn
>>>> treats it as a change to the OFBiz svn.  The is a constant risk of
>>>> accidentally committing an entire body of custom work to the  
>>>> OFBiz repo.
>>>>
>>>> Is that your reason for bringing it up Vikas?  I have to admit I  
>>>> have
>>>> performed many nervous commits with the fear that my work is  
>>>> going to the
>>>> wrong repository.
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> On 9/09/2009, at 9:11 PM, Jacques Le Roux wrote:
>>>>
>>>> Hi Vikas,
>>>>>
>>>>> From: "Vikas Mayur" <[hidden email]>
>>>>>
>>>>>> Hi Jacques,
>>>>>> I do not see any problems because I am not a SVN Guru. I was just
>>>>>> trying to understand why it is not ignored. AFAIK this  
>>>>>> directory is  not
>>>>>> used for any other purpose other then adding your custom  
>>>>>> component.
>>>>>> Does only readme file under this directory adds to a good  
>>>>>> reason of  not
>>>>>> ignoring this?
>>>>>>
>>>>>
>>>>> If nobody has any problems with it I would say, yes keep it as  
>>>>> is. Other
>>>>> opininons ?
>>>>>
>>>>> Jacques
>>>>>
>>>>>> Vikas
>>>>>> On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote:
>>>>>>
>>>>>>> Hi Vikas,
>>>>>>>
>>>>>>> I'd prefer to keep it there. What is your problem with  
>>>>>>> svn:ignore ?
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>> From: "Vikas Mayur" <[hidden email]>
>>>>>>>
>>>>>>>> Hi Scott,
>>>>>>>> Thanks for your reply, though it was the easiest one :)
>>>>>>>> Do you agree that hot-deploy folder should be ignored and  
>>>>>>>> readme  file
>>>>>>>> is moved to under some other directory or even its contents  
>>>>>>>> merged  with
>>>>>>>> README file under root folder, or any other better  option?
>>>>>>>> Vikas
>>>>>>>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
>>>>>>>>
>>>>>>>>> Hi Vikas
>>>>>>>>>
>>>>>>>>> The only reason I can think of is the readme file.
>>>>>>>>>
>>>>>>>>> Regards
>>>>>>>>> Scott
>>>>>>>>>
>>>>>>>>> HotWax Media
>>>>>>>>> http://www.hotwaxmedia.com
>>>>>>>>>
>>>>>>>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> Does anyone know why svn:ignore is not set to TRUE on hot-
>>>>>>>>>> deploy
>>>>>>>>>> folder?
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> Vikas
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

[Jacques Le Roux]

From: "Scott Gray" <[hidden email]>
> There are no values assigned to the property so it isn't actually  
> doing anything.

Yes, so what you would want to do ?
I don't like the idea of moving the README file

Jacques
 

> Regards
> Scott
>
> On 10/09/2009, at 1:07 AM, Jacques Le Roux wrote:
>
>> From: "Ashish Vijaywargiya" <[hidden email]>
>>> +1 for adding svn:ignore on hot-deploy folder and moving readme.txt  
>>> file
>>> somewhere else.
>>
>> I just had a look : hot-deploy folder has already svn:ignore in its  
>> properties
>>
>> So I don't understand what change is really required, svn:ignore on  
>> the README file ?
>>
>> Jacques
>>
>>> +ive vote for this change: 4 - Vikas, Scott, Jacques  
>>> (Probably? ;o) ),
>>> Ashish.
>>> -ive vote for this change: 0
>>> Althought I would wait for expert comment on this before we do it  
>>> on trunk.
>>> --
>>> Ashish
>>> On Wed, Sep 9, 2009 at 4:07 PM, Vikas Mayur <[hidden email]
>>> >wrote:
>>>> Hi Scott,
>>>>
>>>> Thanks for the stating this clearly (I see now that I haven't  
>>>> proposed
>>>> enough reason(s) to support my question) and yes I have the same  
>>>> feeling of
>>>> committing custom code accidently.
>>>>
>>>> Most of the time I also have a tar file of the custom component  
>>>> under
>>>> hot-deploy directory, as instead taking a fresh checkout for a  
>>>> component
>>>> (which contains images in GB) I prefer to take archive file
>>>>
>>>> from someone who already have a checkout.
>>>>
>>>> Though to commit something from hot-deploy, the custom component  
>>>> or file
>>>> need to added to version control first. This is obviously a first  
>>>> check.
>>>>
>>>> I tried to add the custom component to version control but since  
>>>> my custom
>>>> component is also version controlled, it denied to add this again to
>>>> hot-deploy so this was safe.
>>>>
>>>> But what if custom work/component is not under version control,  
>>>> there are
>>>> still chances of errors and code being accidently committed to  
>>>> trunk.
>>>>
>>>> I think this reason should be enough to ignore the hot-deploy  
>>>> folder.
>>>>
>>>> Vikas
>>>>
>>>>
>>>> On Sep 9, 2009, at 2:59 PM, Scott Gray wrote:
>>>>
>>>> I guess what Vikas hasn't explained is the reason why he wants the
>>>>> hot-deploy folder's contents to be ignored.
>>>>>
>>>>> The answer to that I guess is fairly obvious, the hot-deploy  
>>>>> folder is a
>>>>> place to put custom applications and code and when you put code  
>>>>> in there svn
>>>>> treats it as a change to the OFBiz svn.  The is a constant risk of
>>>>> accidentally committing an entire body of custom work to the  
>>>>> OFBiz repo.
>>>>>
>>>>> Is that your reason for bringing it up Vikas?  I have to admit I  
>>>>> have
>>>>> performed many nervous commits with the fear that my work is  
>>>>> going to the
>>>>> wrong repository.
>>>>>
>>>>> Regards
>>>>> Scott
>>>>>
>>>>> On 9/09/2009, at 9:11 PM, Jacques Le Roux wrote:
>>>>>
>>>>> Hi Vikas,
>>>>>>
>>>>>> From: "Vikas Mayur" <[hidden email]>
>>>>>>
>>>>>>> Hi Jacques,
>>>>>>> I do not see any problems because I am not a SVN Guru. I was just
>>>>>>> trying to understand why it is not ignored. AFAIK this  
>>>>>>> directory is  not
>>>>>>> used for any other purpose other then adding your custom  
>>>>>>> component.
>>>>>>> Does only readme file under this directory adds to a good  
>>>>>>> reason of  not
>>>>>>> ignoring this?
>>>>>>>
>>>>>>
>>>>>> If nobody has any problems with it I would say, yes keep it as  
>>>>>> is. Other
>>>>>> opininons ?
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>> Vikas
>>>>>>> On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote:
>>>>>>>
>>>>>>>> Hi Vikas,
>>>>>>>>
>>>>>>>> I'd prefer to keep it there. What is your problem with  
>>>>>>>> svn:ignore ?
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>> From: "Vikas Mayur" <[hidden email]>
>>>>>>>>
>>>>>>>>> Hi Scott,
>>>>>>>>> Thanks for your reply, though it was the easiest one :)
>>>>>>>>> Do you agree that hot-deploy folder should be ignored and  
>>>>>>>>> readme  file
>>>>>>>>> is moved to under some other directory or even its contents  
>>>>>>>>> merged  with
>>>>>>>>> README file under root folder, or any other better  option?
>>>>>>>>> Vikas
>>>>>>>>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote:
>>>>>>>>>
>>>>>>>>>> Hi Vikas
>>>>>>>>>>
>>>>>>>>>> The only reason I can think of is the readme file.
>>>>>>>>>>
>>>>>>>>>> Regards
>>>>>>>>>> Scott
>>>>>>>>>>
>>>>>>>>>> HotWax Media
>>>>>>>>>> http://www.hotwaxmedia.com
>>>>>>>>>>
>>>>>>>>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote:
>>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> Does anyone know why svn:ignore is not set to TRUE on hot-
>>>>>>>>>>> deploy
>>>>>>>>>>> folder?
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>> Vikas
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
>