svn propchange: r1837462 - svn:log

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn propchange: r1837462 - svn:log

Taher Alkhateeb
Author: taher
Revision: 1837462
Modified property: svn:log

Modified: svn:log at Mon Aug  6 06:00:30 2018
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Mon Aug  6 06:00:30 2018
@@ -1 +1,17 @@
-https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk
+Improved: Further refactor MapContext and MapStack
+(OFBIZ-10485)
+
+This commit applies multiple new refactoring enhancements as follows:
+- rename stackList to contexts (the data structure holding the context Deque)
+- refactor the size function to utilize streams to sum all keys
+- Implement a function "entryStream()" that returns a stream of all keys in the
+  correct sequential order and utilize this function in multiple functions for
+  iterating over the keys including "containsValue", "values" and "entrySet".
+  This implementation is necessary to avoid code repetition and ensure correct
+  order with no duplicates
+- Re-design the get functions of the context map to use a generic function with
+  a functional interface "withMapContainingKey". The purpose of it is to avoid
+  checking for nulls and instead use the "containsKey" function followed by the
+  injected lambda expressions in both signatures of the get function
+
+Thanks: Mathieu Lirzin for the patch and implementing suggested changes.