Re: Problem with sending order confirmation email

Posted by David E Jones-2 on
URL: http://ofbiz.116.s1.nabble.com/Problem-with-sending-order-confirmation-email-tp142480p142495.html


Phani,

Thanks for persisting on this and tracking it down. I made a similar  
change in SVN rev 472801 that should solve this problem. Could you  
try it out?

-David


On Nov 7, 2006, at 12:06 AM, G.Venkata Phanindra wrote:

> Hi Tim
>        I am able to fix the problem i am facing with by making the
> following changes in orderstatus.bsh file  its working for me in all
> scenarios but i want have a confirmation that what ever i have  
> coded is
> correct.
>
> orderHeader = null;
> if (orderId != null && orderId.length() > 0) {
>    orderHeader = delegator.findByPrimaryKey("OrderHeader",
> UtilMisc.toMap("orderId",
> orderId));
>    if (orderHeader != null) {
>        orderRole = delegator.findByPrimaryKey("OrderRole",
> UtilMisc.toMap("orderId",
> orderId, "partyId", partyId, "roleTypeId", "PLACING_CUSTOMER"));
>        if (userLogin == null || orderRole == null) {
>            context.remove("orderHeader");
>            orderHeader = null;
>            System.out.println("OrderHeader is  Equal to null ????????
> :((");
>        }
>    }
> }
>
> *********************** changes *****************
> orderHeader = null;
> if (orderId != null && orderId.length() > 0) {
>    orderHeader = delegator.findByPrimaryKey("OrderHeader",
> UtilMisc.toMap("orderId",
> orderId));
>    if (orderHeader != null) {
>        orderRoleList = delegator.findByLike("OrderRole",
> UtilMisc.toMap("orderId",
> orderId, "roleTypeId", "PLACING_CUSTOMER"));
>        orderRole = orderRoleList.get(0);
>        if (userLogin == null || orderRole == null) {
>            context.remove("orderHeader");
>            orderHeader = null;
>        }
>    }
> }
>
>
> On 11/7/06, G.Venkata Phanindra <[hidden email]> wrote:
>>
>> Hi Tim,
>>         Today i came across a new scenario, i.e i placed an order  
>> as a
>> "admin" from my webstore the order got placed and then i came back  
>> to Order
>> manager selected the order that i placed as admin when i used send
>> confirmation email  i did not get any problem the mail got  
>> generated with
>> order information.
>>
>> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "
>> http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
>> <html xmlns="http://www.w3.org/1999/xhtml">
>> <head>
>>     <meta http-equiv="Content-Type" content="text/html;  
>> charset=UTF-8"/>
>>     <title>Order Complete Notice</title>
>>     <link rel="stylesheet" href="http://127.0.0.1:8080/images/ 
>> maincss.css"
>> type="text/css"/>
>> </head>
>>
>> <body>
>>
>>
>> <div class="head1">Order Complete Notice</div>
>>
>>
>> <div class="nav_top">
>>         <h4>Order Information</h4>
>> </div>
>>    <div class="navcontent">
>>     <div class="screenlet">
>>         <div class="screenlet-header">
>>             <div style="float: right;">
>>             </div>
>>           <div class="boxhead"> Order #<b>13652</b> Information</div>
>>         </div>
>>         <div class="screenlet-body">
>>             <table width="100%" border="0" cellpadding="1">
>>                   <tr>
>>                     <td align="right" valign="top" width="15%">
>>                       <div class="tabletext"> <b>Name</b></div>
>>                     </td>
>>                     <td width="5"> </td>
>>                     <td align="left" valign="top" width="80%">
>>                       <div class="tabletext">
>>                          THE PRIVILEGED qdqeee
>>                       </div>
>>                     </td>
>>                   </tr>
>>                   <tr><td colspan="7"><hr class="sepbar"/></td></tr>
>>                 <tr>
>>                   <td align="right" valign="top" width="15%">
>>                     <div class="tabletext"> <b>Status</b></div>
>>                   </td>
>>                   <td width="5"> </td>
>>                   <td align="left" valign="top" width="80%">
>> Created_EXT_PAYPAL                  </td>
>>                 </tr>
>>                   <tr><td colspan="7"><hr class="sepbar"/></td></tr>
>>                   <tr>
>>                     <td align="right" valign="top" width="15%">
>>                       <div class="tabletext"> <b>Date</b></div>
>>                     </td>
>>                     <td width="5"> </td>
>>                     <td align="left" valign="top" width="80%">
>>                       <div class="tabletext">2006-10-30  
>> 19:20:59.0</div>
>>                     </td>
>>                   </tr>
>>             </table>
>>         </div>
>>     </div>
>> </div>
>> <div class="nav_btm"></div>
>> <div class="nav_top">
>>         <h4>Order Items</h4>
>> </div>
>>
>>     <div class="navcontent">
>>
>>         <div class="screenlet-body">
>>             <table width="100%" border="0" cellpadding="0">
>>               <tr align="left" valign="bottom">
>>                 <td width="35%" align="left"><span
>> class="tableheadtext"><b>GiftsnideasProduct</b></span></td>
>>                   <td width="10%" align="right"> </td>
>>                   <td width="10%" align="right"> </td>
>>                   <td width="10%" align="right"><span
>> class="tableheadtext"><b>Qty Ordered</b></span></td>
>>                 <td width="10%" align="right"><span
>> class="tableheadtext"><b>GiftsnideasUnitPrice</b></span></td>
>>                 <td width="10%" align="right"><span
>> class="tableheadtext"><b>Adjustments</b></span></td>
>>                 <td width="10%" align="right"><span
>> class="tableheadtext"><b>Subtotal</b></span></td>
>>               </tr>
>>                 <tr><td colspan="10"><hr class="sepbar"/></td></tr>
>>                 <tr>
>>                     <td valign="top">
>>                       <div class="tabletext">
>>                         <b>10098 - Origami Earrings</b>
>>                       </div>
>>                       <div class="tabletext" style="font-size: xx-
>> small;">
>>                       </div>
>>                     </td>
>>                       <td> </td>
>>                       <td> </td>
>>                     <td align="right" valign="top">
>>                       <div
>> class="tabletext">1</div>
>>                     </td>
>>                     <td align="right" valign="top">
>>                       <div class="tabletext">$100.00</div>
>>                     </td>
>>                     <td align="right" valign="top">
>>                       <div class="tabletext">$0.00</div>
>>                     </td>
>>                     <td align="right" valign="top">
>>                       <div class="tabletext">$100.00</div>
>>                     </td>
>>                 </tr>
>>
>>                     <tr>
>>                       <td align="right">
>>                         <div class="tabletext" style="font-size:
>> xx-small;"><b><i>Ship Group</i>:</b> [00001] gfhfhf</div>
>>                       </td>
>>                       <td align="right">
>>                         <div class="tabletext" style="font-size:
>> xx-small;">1</div>
>>                       </td>
>>                       <td> </td>
>>                       <td> </td>
>>                       <td> </td>
>>                       <td> </td>
>>                       <td> </td>
>>                     </tr>
>>
>>
>>               <tr><td colspan="10"><hr class="sepbar"/></td></tr>
>>               <tr>
>>                 <td align="right" colspan="6"><div
>> class="tabletext"><b>Subtotal</b></div></td>
>>                 <td align="right"><div
>> class="tabletext">$100.00</div></td>
>>               </tr>
>>               <tr>
>>                 <td align="right" colspan="6"><div
>> class="tabletext"><b>Shipping and Handling</b></div></td>
>>                 <td align="right"><div class="tabletext">$0.00</
>> div></td>
>>               </tr>
>>               <tr>
>>                 <td align="right" colspan="6"><div
>> class="tabletext"><b>Sales Tax</b></div></td>
>>                 <td align="right"><div class="tabletext">$0.00</
>> div></td>
>>               </tr>
>>
>>               <tr><td colspan="2"></td><td colspan="9"><hr
>> class="sepbar"/></td></tr>
>>               <tr>
>>                 <td align="right" colspan="6"><div
>> class="tabletext"><b>Grand Total</b></div></td>
>>                 <td align="right">
>>                   <div class="tabletext">$100.00</div>
>>                 </td>
>>               </tr>
>>             </table>
>>         </div>
>>     </div>
>> <div class="nav_btm"></div>
>> <div class="nav_top">
>>         <h4>Shipping Information</h4>
>> </div>
>> <div class="navcontent">
>> <table>
>> <tr>
>>
>>
>>     <td >
>>
>>     <div class="screenlet">
>>         <div class="screenlet-header">
>>             <div class="boxhead"> </div>
>>         </div>
>>         <div class="screenlet-body">
>>
>>               <table width="100%" border="0" cellpadding="1">
>>                   <tr>
>>                     <td align="right" valign="top" width="15%">
>>                       <div class="tabletext"> <b>Destination</b>
>> [00001]</div>
>>                     </td>
>>                     <td width="5"> </td>
>>                     <td align="left" valign="top" width="80%">
>>                       <div class="tabletext">
>>                         <b>To:</b> ghjg<br/>
>>                         <b>Attn:</b> gfhf<br/>
>>                         gfhfhf<br/>
>>                         ghfhfhf<br/>
>>                         hyderabad
>>                         544646<br/>
>>                         ABW
>>                       </div>
>>                     </td>
>>                   </tr>
>>                   <tr><td colspan="7"><hr class="sepbar"/></td></tr>
>>                 <tr>
>>                   <td align="right" valign="top" width="15%">
>>                     <div class="tabletext"> <b>Method</b></div>
>>                   </td>
>>                   <td width="5"> </td>
>>                   <td align="left" valign="top" width="80%">
>>                     <div class="tabletext">
>>
>>                       UPS
>>                       Air
>>
>>                     </div>
>>                   </td>
>>                 </tr>
>>                 <tr><td colspan="7"><hr class="sepbar"/></td></tr>
>>
>>                 <tr><td colspan="7"><hr class="sepbar"/></td></tr>
>>                 <tr>
>>                   <td align="right" valign="top" width="15%">
>>                     <div class="tabletext"> <b>Delivery Date</b></
>> div>
>>                   </td>
>>                   <td width="5"> </td>
>>                   <td align="left" valign="top" width="80%">
>>                     <div class="tabletext">31/Oct/2006</div>
>>                   </td>
>>                 </tr>
>>               </table>
>>
>>         </div>
>>     </div>
>>
>>     </td>
>>   </tr>
>> </table>
>> </div>
>> <div class="nav_btm"></div>
>> <div class="nav_top">
>>         <h4>Payment Information</h4>
>> </div>
>> <div class="navcontent">
>>     <div class="screenlet">
>>
>>         <div class="screenlet-body">
>>             <table width="100%" border="0" cellpadding="1">
>>                   <tr>
>>                       <td colspan="3" valign="top">
>>                         <div class="tabletext"  
>> align="center"><b>Payment
>> Via Paypal</b></div>
>>                       </td>
>>                   </tr>
>>             </table>
>>         </div>
>>     </div>
>>     </td>
>> </tr>
>> </table>
>> </div>
>> <div class="nav_btm"></div>
>>
>> <br/>
>> <div class="nav_top">
>>         <h4>Order Items</h4>
>> </div>
>>
>>     <div class="navcontent">
>>
>>         <div class="screenlet-body">
>>             <table width="100%" border="0" cellpadding="0">
>>               <tr align="left" valign="bottom">
>>                 <td width="35%" align="left"><span
>> class="tableheadtext"><b>GiftsnideasProduct</b></span></td>
>>                   <td width="10%" align="right"> </td>
>>                   <td width="10%" align="right"> </td>
>>                   <td width="10%" align="right"><span
>> class="tableheadtext"><b>Qty Ordered</b></span></td>
>>                 <td width="10%" align="right"><span
>> class="tableheadtext"><b>GiftsnideasUnitPrice</b></span></td>
>>                 <td width="10%" align="right"><span
>> class="tableheadtext"><b>Adjustments</b></span></td>
>>                 <td width="10%" align="right"><span
>> class="tableheadtext"><b>Subtotal</b></span></td>
>>               </tr>
>>                 <tr><td colspan="10"><hr class="sepbar"/></td></tr>
>>                 <tr>
>>                     <td valign="top">
>>                       <div class="tabletext">
>>                         <b>10098 - Origami Earrings</b>
>>                       </div>
>>                       <div class="tabletext" style="font-size: xx-
>> small;">
>>                       </div>
>>                     </td>
>>                       <td> </td>
>>                       <td> </td>
>>                     <td align="right" valign="top">
>>                       <div
>> class="tabletext">1</div>
>>                     </td>
>>                     <td align="right" valign="top">
>>                       <div class="tabletext">$100.00</div>
>>                     </td>
>>                     <td align="right" valign="top">
>>                       <div class="tabletext">$0.00</div>
>>                     </td>
>>                     <td align="right" valign="top">
>>                       <div class="tabletext">$100.00</div>
>>                     </td>
>>                 </tr>
>>
>>                     <tr>
>>                       <td align="right">
>>                         <div class="tabletext" style="font-size:
>> xx-small;"><b><i>Ship Group</i>:</b> [00001] gfhfhf</div>
>>                       </td>
>>                       <td align="right">
>>                         <div class="tabletext" style="font-size:
>> xx-small;">1</div>
>>                       </td>
>>                       <td> </td>
>>                       <td> </td>
>>                       <td> </td>
>>                       <td> </td>
>>                       <td> </td>
>>                     </tr>
>>
>>
>>               <tr><td colspan="10"><hr class="sepbar"/></td></tr>
>>               <tr>
>>                 <td align="right" colspan="6"><div
>> class="tabletext"><b>Subtotal</b></div></td>
>>                 <td align="right"><div
>> class="tabletext">$100.00</div></td>
>>               </tr>
>>               <tr>
>>                 <td align="right" colspan="6"><div
>> class="tabletext"><b>Shipping and Handling</b></div></td>
>>                 <td align="right"><div class="tabletext">$0.00</
>> div></td>
>>               </tr>
>>               <tr>
>>                 <td align="right" colspan="6"><div
>> class="tabletext"><b>Sales Tax</b></div></td>
>>                 <td align="right"><div class="tabletext">$0.00</
>> div></td>
>>               </tr>
>>
>>               <tr><td colspan="2"></td><td colspan="9"><hr
>> class="sepbar"/></td></tr>
>>               <tr>
>>                 <td align="right" colspan="6"><div
>> class="tabletext"><b>Grand Total</b></div></td>
>>                 <td align="right">
>>                   <div class="tabletext">$100.00</div>
>>                 </td>
>>               </tr>
>>             </table>
>>         </div>
>>     </div>
>> <div class="nav_btm"></div>
>>
>> </body>
>> </html>
>>
>>
>> What could be the reason its not working when i am trying to send  
>> order
>> confirmation email i am getting the message
>>
>> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"  
>> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd
>> ">
>> <html xmlns="http://www.w3.org/1999/xhtml">
>> <head>
>>     <meta http-equiv="Content-Type" content="text/html;  
>> charset=UTF-8"/>
>>     <title>Order Complete Notice</title>
>>     <link rel="stylesheet" href="http://127.0.0.1:8080/images/ 
>> maincss.css "
>> type="text/css"/>
>> </head>
>>
>> <body>
>>
>>
>> <div class="head1">Order Complete Notice</div>
>> <p>NOTE: This is a DEMO store-front.  Orders placed here will NOT be
>> billed, and will NOT be fulfilled.</p>
>>
>> <div class="head1">Order not found with ID [13594], or not allowed to
>> view.</div>
>>
>> </body>
>> </html>
>> regards
>>
>> Phani
>>
>>
>>
>> On 11/6/06, Tim Ruppert <[hidden email]> wrote:
>> >
>> > I'm not really sure exactly which ones were modified.  If I  
>> remember
>> > correctly, I'd do a diff between versions 471100 / 471127 / 471137.
>> > 471127 has some of the fix, but not all of it.
>> >
>> > Let me know if there's anything else I can help you with.
>> >
>> > Cheers,
>> > Tim
>> >
>> > --
>> > Tim Ruppert
>> > HotWax Media
>> > http://www.hotwaxmedia.com
>> >
>> > o:801.649.6594
>> > f:801.649.6595
>> >
>> > G.Venkata Phanindra wrote:
>> > > Hi,
>> > >      It will be of great if u can provide me with the list of  
>> file i
>> > need
>> > > to update for this  particular issue or bug fix. As i cannot  
>> update
>> > > whole of
>> > > ofbiz.
>> > > Regards
>> > > G Venkata Phanindra.
>> > >
>> > > On 11/6/06, Tim Ruppert <[hidden email]> wrote:
>> > >>
>> > >> I can't guarantee anything other that - when I have the  
>> isDemoStore
>> > >> setting set properly and do an anonymous checkout - it works  
>> for me.
>> > >> Good luck.
>> > >>
>> > >> Cheers,
>> > >> Tim
>> > >>
>> > >> --
>> > >> Tim Ruppert
>> > >> HotWax Media
>> > >> http://www.hotwaxmedia.com
>> > >>
>> > >> o:801.649.6594
>> > >> f:801.649.6595
>> > >>
>> > >>
>> > >>
>> > >> G.Venkata Phanindra wrote:
>> > >> > Hi,
>> > >> > Thanks for all your reply. will updating my ofbiz version  
>> to 471137
>> > >> fixes
>> > >> > this problem????
>> > >> > regards
>> > >> > G Venkata Phanindra.
>> > >> >
>> > >> > On 11/4/06, Tim Ruppert <[hidden email]> wrote:
>> > >> >>
>> > >> >> At long last - David and I tracked down the issues  
>> surrounding
>> > >> this and
>> > >>
>> > >> >> now it's fixed!  It's in version 471137.
>> > >> >>
>> > >> >> Cheers,
>> > >> >> Tim
>> > >> >>
>> > >> >> --
>> > >> >> Tim Ruppert
>> > >> >> HotWax Media
>> > >> >> http://www.hotwaxmedia.com
>> > >> >>
>> > >> >> o:801.649.6594
>> > >> >> f:801.649.6595
>> > >> >>
>> > >> >> Tim Ruppert wrote:
>> > >> >> > Keep in mind that this is the anonymous checkout - I'm  
>> running
>> > >> version
>> > >> >> > 469917 from earlier this week.
>> > >> >> >
>> > >> >> > Cheers,
>> > >> >> > Tim
>> > >> >> >
>> > >> >> > --
>> > >> >> > Tim Ruppert
>> > >> >> > HotWax Media
>> > >> >> > http://www.hotwaxmedia.com
>> > >> >> >
>> > >> >> > o:801.649.6594
>> > >> >> > f:801.649.6595
>> > >> >> >
>> > >> >> > Jacopo Cappellato wrote:
>> > >> >> >> my guess is that it could be caused by the userLogin  
>> variable
>> > that
>> > >> is
>> > >> >> >> null when the orderview.bsh script is run by the send mail
>> > >> service...
>> > >> >> >> the userLogin object is used to call two services in the
>> > script.
>> > >> >> >>
>> > >> >> >> Does it make sense?
>> > >> >> >>
>> > >> >> >> Jacopo
>> > >> >> >>
>> > >> >> >> Tim Ruppert wrote:
>> > >> >> >>> Unfortunately, I got an error when trying to send the
>> > email.  I
>> > >> >> >>> research it and get back to everyone.
>> > >> >> >>>
>> > >> >> >>> Cheers,
>> > >> >> >>> Tim
>> > >> >>
>> > >> >
>> > >> >
>> > >> >
>> > >>
>> > >
>> > >
>> > >
>> >
>>
>>
>>
>> --
>> G.Venkata Phanindra
>> Mob:: 9849852989
>>
>
>
>
> --
> G.Venkata Phanindra
> Mob:: 9849852989