[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme Resource Enums for better readability

Posted by Nicolas Malin (Jira) on
URL: http://ofbiz.116.s1.nabble.com/jira-Created-OFBIZ-3519-Slightly-modified-Visual-Theme-Resource-Enums-for-better-readability-tp1570758p1577657.html


    [ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841074#action_12841074 ]

Scott Gray commented on OFBIZ-3519:
-----------------------------------

Does anyone know if we have a policy for changing seed data ids?  I'm guessing this change will cause problems for anyone upgrading.

> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-3519
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3519
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.