Login  Register

Re: Dev - [Fwd: [OFBiz] SVN: r7165 - trunk/applications/accounting/script/org/ofbiz/accounting/invoice]

Posted by David E. Jones on Apr 03, 2006; 4:31pm
URL: http://ofbiz.116.s1.nabble.com/Dev-Fwd-OFBiz-SVN-r7165-trunk-applications-accounting-script-org-ofbiz-accounting-invoice-tp167540p167543.html


I agree.

-David


Si Chen wrote:

> Hans,
>
> I'm sorry but I don't think this is correct.  WRITE_OFF is not the same
> as CANCELED.  Write off means that the invoice is good but cannot be
> collected in full.  Canceled means invoice is wrong or otherwise in
> valid.  If the invoice is written off, we would still need to know what
> payments were made and applied against it, so we know what needs to be
> collected through legal action, etc.
>
> I don't imagine you've used write off a lot yet, since I just put in
> last week.  If you have any issues, please let me know.
>
> Si
>
> ------------------------------------------------------------------------
>
> Subject:
> [OFBiz] SVN: r7165 -
> trunk/applications/accounting/script/org/ofbiz/accounting/invoice
> From:
> [hidden email]
> Date:
> 1 Apr 2006 03:12:02 -0000
> To:
> [hidden email]
>
> To:
> [hidden email]
>
>
> Author: hansbak
> Date: 2006-03-31 21:11:53 -0600 (Fri, 31 Mar 2006)
> New Revision: 7165
>
> Modified:
>    trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml
> Log:
> delete payment application if invoice status changes to 'writeoff', the same as cancelled
>
> Modified: trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml
> ===================================================================
> --- trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml 2006-04-01 02:47:27 UTC (rev 7164)
> +++ trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml 2006-04-01 03:11:53 UTC (rev 7165)
> @@ -436,11 +436,19 @@
>                  </if-empty>    
>                  <create-value value-name="newEntity"/>
>                  
> -                <!-- if new status is cancelled delete existing payment applications. -->
> -                <if-compare field-name="parameters.statusId" operator="equals" value="INVOICE_CANCELLED">
> -                    <set field="removePaymentApplicationMap.invoiceId" from-field="parameters.invoiceId"/>
> -                    <remove-by-and entity-name="PaymentApplication" map-name="removePaymentApplicationMap"/>
> -                </if-compare>
> +                <!-- if new status is cancelled/writeoff delete existing payment applications. -->
> +                <if>
> +                    <condition>
> +                        <or>
> +                            <if-compare field-name="parameters.statusId" operator="equals" value="INVOICE_CANCELLED"/>
> +                            <if-compare field-name="parameters.statusId" operator="equals" value="INVOICE_WRITEOFF"/>
> +                        </or>
> +                    </condition>
> +                    <then>
> +                        <set field="removePaymentApplicationMap.invoiceId" from-field="parameters.invoiceId"/>
> +                        <remove-by-and entity-name="PaymentApplication" map-name="removePaymentApplicationMap"/>
> +                    </then>
> +                </if>
>              </else>  
>              </if-empty>
>          </if-compare-field>
>
>  
> _______________________________________________
> Svn mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/svn
>
>
>
>
> ------------------------------------------------------------------------
>
>  
> _______________________________________________
> Dev mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/dev
 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev