Re: Dev - Mods to the TaxAuth services to display party's taxes in prices instead of product store's one

Posted by Jacopo Cappellato on Apr 26, 2006; 6:40pm
URL: http://ofbiz.116.s1.nabble.com/Dev-Mods-to-the-TaxAuth-services-to-display-party-s-taxes-in-prices-instead-of-product-store-s-one-tp167724p167750.html

David,

I've forgot to mention that I've moved to a wiki page the information
about the TaxAuthrity data model that you posted to this list some time ago:

http://ofbizwiki.go-integral.com/Wiki.jsp?page=TaxAuthorityDataModel

These notes are pure gold!

Jacopo

Jacopo Cappellato wrote:

> David,
>
> ok, I've reviewed the two TaxAuthorityServices responsible for tax
> calculations:
>
> * rateProductTaxCalc
> * rateProductTaxCalcForDisplay
>
> The former is used during checkout, the latter is used to display the
> tax with the price in the category and product details screens of the
> ecommerce site (when the ProductStore.showPricesWithVatTax is set to Y).
>
> I think that the main problem (but I'm probably missing something) is
> that the product store's vatTaxAuthGeoId and vatTaxAuthPartyId are only
> considered by the rateProductTaxCalcForDisplay service and not by the
> rateProductTaxCalc service: for this reason the taxes shown in the
> category pages are different by the taxes used in checkout.
>
> I'm not sure what was the original design, however I think that there
> are two possibilities:
>
> a) we leave rateProductTaxCalcForDisplay as is (i.e. to only consider
> the tax authority set in the product store); we patch the
> rateProductTaxCalc service to not consider the tax authorities
> associated to the shippingAddress of the client (but only the tax auth
> of the product store) IF the ProductStore.showPricesWithVatTax is set to Y
>
> b) we modify the rateProductTaxCalcForDisplay to work in the same way
> the rateProductTaxCalc service works if a party with a shippingAddress
> is available; if not available (i.e. anonymous user or logged in user
> with no postalAddress set) the tax auth of the product store is used
>
> What do you think of these?
>
> Thanks,
>
> Jacopo
>
>

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev